From 43b6c712052d5e081028f1cd0efc316ba643b750 Mon Sep 17 00:00:00 2001 From: Michael Teeuw Date: Tue, 13 Oct 2020 16:14:52 +0200 Subject: [PATCH] Revert "Fixes the un-hide problem with currentwether and weatherforcast modules." --- CHANGELOG.md | 1 - modules/default/currentweather/currentweather.js | 11 +++++------ modules/default/weatherforecast/weatherforecast.js | 8 +++----- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index efd7e19d..c360e511 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,7 +17,6 @@ _This release is scheduled to be released on 2021-01-01._ ### Fixed -- Fixed the "un-hide on update" problem with "currentwather" and "watherforcast" modules. - JSON Parse translation files with comments crashing UI. (#2149) - Calendar parsing where RRULE bug returns wrong date, add Windows timezone name support. (#2145, #2151) - Wrong node-ical version installed (package.json) requested version. (#2153) diff --git a/modules/default/currentweather/currentweather.js b/modules/default/currentweather/currentweather.js index 376732a9..0a43b23e 100644 --- a/modules/default/currentweather/currentweather.js +++ b/modules/default/currentweather/currentweather.js @@ -495,12 +495,11 @@ Module.register("currentweather", { this.sunriseSunsetTime = timeString; this.sunriseSunsetIcon = sunrise < now && sunset > now ? "wi-sunset" : "wi-sunrise"; - if (!this.hidden) { - this.show(this.config.animationSpeed, { lockString: this.identifier }); - this.loaded = true; - this.updateDom(this.config.animationSpeed); - this.sendNotification("CURRENTWEATHER_DATA", { data: data }); - } + + this.show(this.config.animationSpeed, { lockString: this.identifier }); + this.loaded = true; + this.updateDom(this.config.animationSpeed); + this.sendNotification("CURRENTWEATHER_DATA", { data: data }); }, /* scheduleUpdate() diff --git a/modules/default/weatherforecast/weatherforecast.js b/modules/default/weatherforecast/weatherforecast.js index f8550022..4ecc18aa 100644 --- a/modules/default/weatherforecast/weatherforecast.js +++ b/modules/default/weatherforecast/weatherforecast.js @@ -408,11 +408,9 @@ Module.register("weatherforecast", { } //Log.log(this.forecast); - if (!this.hidden) { - this.show(this.config.animationSpeed, { lockString: this.identifier }); - this.loaded = true; - this.updateDom(this.config.animationSpeed); - } + this.show(this.config.animationSpeed, { lockString: this.identifier }); + this.loaded = true; + this.updateDom(this.config.animationSpeed); }, /* scheduleUpdate()