From 0d3ad9812c19bce317371e8c0417d00fa75be079 Mon Sep 17 00:00:00 2001 From: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com> Date: Fri, 7 Apr 2023 19:24:27 +0200 Subject: [PATCH] Drop node v14 support (#3085) node v14 will have reached end-of-life by the next release. From April 18th we can use node v20 instead of v19 for testing. --- .github/CONTRIBUTING.md | 2 +- .github/ISSUE_TEMPLATE/custom.md | 2 +- .github/workflows/automated-tests.yaml | 2 +- CHANGELOG.md | 1 + package-lock.json | 2 +- package.json | 2 +- 6 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index ce7cccb4..6337c8dc 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -43,7 +43,7 @@ When submitting a new issue, please supply the following information: **Platform**: Place your platform here... give us your web browser/Electron version _and_ your hardware (Raspberry Pi 2/3/4, Windows, Mac, Linux, System V UNIX). -**Node Version**: Make sure it's version 14 or later (recommended is 16). +**Node Version**: Make sure it's version 16 or later (recommended is 18). **MagicMirror² Version**: Please let us know which version of MagicMirror² you are running. It can be found in the `package.json` file. diff --git a/.github/ISSUE_TEMPLATE/custom.md b/.github/ISSUE_TEMPLATE/custom.md index 087f41f1..047a2268 100644 --- a/.github/ISSUE_TEMPLATE/custom.md +++ b/.github/ISSUE_TEMPLATE/custom.md @@ -31,7 +31,7 @@ When submitting a new issue, please supply the following information: **Platform**: Place your platform here... give us your web browser/Electron version _and_ your hardware (Raspberry Pi 2/3/4, Windows, Mac, Linux, System V UNIX). -**Node Version**: Make sure it's version 14 or later (recommended is 16). +**Node Version**: Make sure it's version 16 or later (recommended is 18). **MagicMirror² Version**: Please let us know which version of MagicMirror² you are running. It can be found in the `package.json` file. diff --git a/.github/workflows/automated-tests.yaml b/.github/workflows/automated-tests.yaml index 28957b00..c9eb45b8 100644 --- a/.github/workflows/automated-tests.yaml +++ b/.github/workflows/automated-tests.yaml @@ -18,7 +18,7 @@ jobs: timeout-minutes: 30 strategy: matrix: - node-version: [14.x, 16.x, 18.x] + node-version: [16.x, 18.x, 19.x] steps: - name: "Checkout code" uses: actions/checkout@v3 diff --git a/CHANGELOG.md b/CHANGELOG.md index 4e36df17..53a24bee 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ _This release is scheduled to be released on 2023-07-01._ ### Updated - Update electron to v24 +- Use node v19 in github workflow (replacing v14). ### Fixed diff --git a/package-lock.json b/package-lock.json index 5848816a..43b551f5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -48,7 +48,7 @@ "suncalc": "^1.9.0" }, "engines": { - "node": ">=14" + "node": ">=16" }, "optionalDependencies": { "electron": "^24.0.0" diff --git a/package.json b/package.json index 762fab04..6d1270f2 100644 --- a/package.json +++ b/package.json @@ -95,6 +95,6 @@ "fetch": "js/fetch.js" }, "engines": { - "node": ">=14" + "node": ">=16" } }