From 0006099758400f9c1a49d57853395af8baa1bcc6 Mon Sep 17 00:00:00 2001 From: Julian Dinter Date: Sun, 4 Apr 2021 14:52:24 +0200 Subject: [PATCH 1/5] Changed log type of starting function of updatenotification module. --- CHANGELOG.md | 7 ++++++- modules/default/updatenotification/updatenotification.js | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index db772d7b..62f66df3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ This project adheres to [Semantic Versioning](https://semver.org/). ❤️ **Donate:** Enjoying MagicMirror²? [Please consider a donation!](https://magicmirror.builders/donate) With your help we can continue to improve the MagicMirror² +## [2.16.0] - + +### Fixed +- Fix calendar start function logging inconsistency +- Fix updatenotification start function logging inconsistency + ## [2.15.0] - 2021-04-01 Special thanks to the following contributors: @EdgardosReis, @MystaraTheGreat, @TheDuffman85, @ashishtank, @buxxi, @codac, @fewieden, @khassel, @klaernie, @qu1que, @rejas, @sdetweil & @thomasrockhu. @@ -68,7 +74,6 @@ Special thanks to the following contributors: @EdgardosReis, @MystaraTheGreat, @ - Fix calendar time/date adjustment when time with GMT offset is different day (#2488). - Fix calendar daylight savings offset calculation if recurring FULL DAY start date before 2007 (#2483). - Fix newsreaders template, for wrong test for nowrap in 2 places (should be if not). -- Fix calendar start function logging inconsistency ## [2.14.0] - 2021-01-01 diff --git a/modules/default/updatenotification/updatenotification.js b/modules/default/updatenotification/updatenotification.js index c67205a7..df4a2a80 100644 --- a/modules/default/updatenotification/updatenotification.js +++ b/modules/default/updatenotification/updatenotification.js @@ -17,7 +17,7 @@ Module.register("updatenotification", { start: function () { var self = this; - Log.log("Start updatenotification"); + Log.info("Start updatenotification"); setInterval(() => { self.moduleList = {}; self.updateDom(2); From 50cc1c56e535022102d183263977d0e5381f6c25 Mon Sep 17 00:00:00 2001 From: Julian Dinter Date: Sun, 4 Apr 2021 15:17:42 +0200 Subject: [PATCH 2/5] Consistent log text. --- modules/default/updatenotification/updatenotification.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/default/updatenotification/updatenotification.js b/modules/default/updatenotification/updatenotification.js index df4a2a80..c5a31c1b 100644 --- a/modules/default/updatenotification/updatenotification.js +++ b/modules/default/updatenotification/updatenotification.js @@ -17,7 +17,7 @@ Module.register("updatenotification", { start: function () { var self = this; - Log.info("Start updatenotification"); + Log.info("Starting module: " + this.name); setInterval(() => { self.moduleList = {}; self.updateDom(2); From c00bdf910ef714053f22b2f45906010ab95f23f9 Mon Sep 17 00:00:00 2001 From: Julian Dinter Date: Sun, 4 Apr 2021 15:22:12 +0200 Subject: [PATCH 3/5] Clean up code by adding comments. --- modules/default/updatenotification/updatenotification.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/modules/default/updatenotification/updatenotification.js b/modules/default/updatenotification/updatenotification.js index c5a31c1b..ffe8c9c6 100644 --- a/modules/default/updatenotification/updatenotification.js +++ b/modules/default/updatenotification/updatenotification.js @@ -5,6 +5,7 @@ * MIT Licensed. */ Module.register("updatenotification", { + // Define module defaults defaults: { updateInterval: 10 * 60 * 1000, // every 10 minutes refreshInterval: 24 * 60 * 60 * 1000, // one day @@ -15,6 +16,7 @@ Module.register("updatenotification", { suspended: false, moduleList: {}, + // Override start method. start: function () { var self = this; Log.info("Starting module: " + this.name); @@ -32,6 +34,7 @@ Module.register("updatenotification", { } }, + // Override socket notification handler. socketNotificationReceived: function (notification, payload) { if (notification === "STATUS") { this.updateUI(payload); From fb74fadec28a04c97afedf8f069cca7ad95e5fba Mon Sep 17 00:00:00 2001 From: Julian Dinter Date: Sun, 4 Apr 2021 15:37:47 +0200 Subject: [PATCH 4/5] Run 'npm run lint:prettier'. --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 62f66df3..0713bd19 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ This project adheres to [Semantic Versioning](https://semver.org/). ## [2.16.0] - ### Fixed + - Fix calendar start function logging inconsistency - Fix updatenotification start function logging inconsistency From b6d6ee45e0300435cc1e2e42abe92efdefef1680 Mon Sep 17 00:00:00 2001 From: Michael Teeuw Date: Thu, 8 Apr 2021 10:40:31 +0200 Subject: [PATCH 5/5] Fix linter issue. --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 803faacf..8cdcffd6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ _This release is scheduled to be released on 2021-04-01._ ### Removed ### Fixed + - Fix calendar start function logging inconsistency. - Fix updatenotification start function logging inconsistency.