kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-07-03 22:36:09 +00:00
Code Issues Projects Releases Wiki Activity

Run and test with node 23 (#3588)

Browse Source
This commit is contained in:
Kristjan ESPERANTO 2024-10-19 12:11:20 +02:00 committed by GitHub
parent fff31068ab
commit 0f024cff4e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/CONTRIBUTING.md vendored
View File

@ -43,7 +43,7 @@ When submitting a new issue, please supply the following information:
**Platform**: Place your platform here... give us your web browser/Electron version _and_ your hardware (Raspberry Pi 2/3/4, Windows, Mac, Linux, System V UNIX). **Platform**: Place your platform here... give us your web browser/Electron version _and_ your hardware (Raspberry Pi 2/3/4, Windows, Mac, Linux, System V UNIX).
**Node Version**: Make sure it's version 18 or later (recommended is 20). **Node Version**: Make sure it's version 20 or later (recommended is 22).
**MagicMirror² Version**: Please let us know which version of MagicMirror² you are running. It can be found in the `package.json` file. **MagicMirror² Version**: Please let us know which version of MagicMirror² you are running. It can be found in the `package.json` file.

2
.github/ISSUE_TEMPLATE.md vendored
View File

@ -35,7 +35,7 @@ When submitting a new issue, please supply the following information:
**Platform**: Place your platform here... give us your web browser/Electron version _and_ your hardware (Raspberry Pi 2/3/4, Windows, Mac, Linux, System V UNIX). **Platform**: Place your platform here... give us your web browser/Electron version _and_ your hardware (Raspberry Pi 2/3/4, Windows, Mac, Linux, System V UNIX).
**Node Version**: Make sure it's version 18 or later (recommended is 20). **Node Version**: Make sure it's version 20 or later (recommended is 22).
**MagicMirror² Version**: Please let us know which version of MagicMirror² you are running. It can be found in the `package.json` file. **MagicMirror² Version**: Please let us know which version of MagicMirror² you are running. It can be found in the `package.json` file.

2
.github/workflows/automated-tests.yaml vendored
View File

@ -18,7 +18,7 @@ jobs:
timeout-minutes: 30 timeout-minutes: 30
strategy: strategy:
matrix: matrix:
node-version: [20.9.0, 20.x, 22.x] node-version: [20.9.0, 20.x, 22.x, 23.x]
steps: steps:
- name: "Checkout code" - name: "Checkout code"
uses: actions/checkout@v4 uses: actions/checkout@v4

2
.github/workflows/electron-rebuild.yaml vendored
View File

@ -8,7 +8,7 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
strategy: strategy:
matrix: matrix:
node-version: [20.9.0, 20.x, 22.x] node-version: [20.9.0, 20.x, 22.x, 23.x]
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v4 uses: actions/checkout@v4

1
CHANGELOG.md
View File

@ -22,6 +22,7 @@ _This release is scheduled to be released on 2025-01-01._
- [repo] reactivated `stale.yaml` as github action to mark issues as stale after 60 days and close them 7 days later (if no activity) - [repo] reactivated `stale.yaml` as github action to mark issues as stale after 60 days and close them 7 days later (if no activity)
- [core] Update electron dependency to v32 (test electron rebuild) - [core] Update electron dependency to v32 (test electron rebuild)
- [tests] All test configs have been updated to allow full external access, allowing for easier debugging (especially when running as a container) - [tests] All test configs have been updated to allow full external access, allowing for easier debugging (especially when running as a container)
- [core] Run and test with node 23
### Fixed ### Fixed

2
package-lock.json generated
View File

@ -50,7 +50,7 @@
"stylelint-prettier": "^5.0.2" "stylelint-prettier": "^5.0.2"
}, },
"engines": { "engines": {
"node": ">=20.9.0 <21 || 22" "node": ">=20.9.0 <21 || 22 || >=23"
}, },
"optionalDependencies": { "optionalDependencies": {
"electron": "^32.2.0" "electron": "^32.2.0"

2
package.json
View File

@ -98,7 +98,7 @@
"electron": "^32.2.0" "electron": "^32.2.0"
}, },
"engines": { "engines": {
"node": ">=20.9.0 <21 || 22" "node": ">=20.9.0 <21 || 22 || >=23"
}, },
"_moduleAliases": { "_moduleAliases": {
"node_helper": "js/node_helper.js", "node_helper": "js/node_helper.js",