From fa1f35a89e1fb967c16511658fbf0ff21b43ac79 Mon Sep 17 00:00:00 2001 From: ccrlawrence Date: Sun, 26 Aug 2018 15:53:01 +0100 Subject: [PATCH 1/2] ClientOnly: Global variable name used in callback function. The global 'config' variable is used in the callback function, changed to local one. Unwanted behaviour when accessing server on docker or if using 0.0.0.0 or blank address in config file as it just passes this to electron to display. --- clientonly/index.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/clientonly/index.js b/clientonly/index.js index 28a45029..957ee114 100644 --- a/clientonly/index.js +++ b/clientonly/index.js @@ -62,13 +62,13 @@ // Only start the client if a non-local server was provided if (["localhost", "127.0.0.1", "::1", "::ffff:127.0.0.1", undefined].indexOf(config.address) === -1) { getServerConfig(`http://${config.address}:${config.port}/config/`) - .then(function (config) { + .then(function (configReturn) { // Pass along the server config via an environment variable var env = Object.create(process.env); var options = { env: env }; - config.address = config.address; - config.port = config.port; - env.config = JSON.stringify(config); + configReturn.address = config.address; + configReturn.port = config.port; + env.config = JSON.stringify(configReturn); // Spawn electron application const electron = require("electron"); From c9293327ce292664816846b74779a871abccf31c Mon Sep 17 00:00:00 2001 From: ccrlawrence Date: Sun, 26 Aug 2018 16:01:41 +0100 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3c242e50..f4c30462 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ This project adheres to [Semantic Versioning](http://semver.org/). --- +## [2.4.2] - 2018-08-26 + +### Fixed + +- Fixed issue with clientonly not updating with IP address and port provided on command line. + ## [2.4.1] - 2018-07-04 ### Fixed