kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-06-27 11:50:00 +00:00
Code Issues Projects Releases Wiki Activity

Add JSDoc description

Browse Source
This commit is contained in:
eouia 2022-04-26 17:37:23 +02:00
parent 0f39b7733c
commit 1d90c5e1fe
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/default/weather/weather.js
View File

@ -155,7 +155,7 @@ Module.register("weather", {
this.sendNotification("CURRENTWEATHER_TYPE", { type: this.weatherProvider.currentWeather().weatherType.replace("-", "_") }); this.sendNotification("CURRENTWEATHER_TYPE", { type: this.weatherProvider.currentWeather().weatherType.replace("-", "_") });
} }
let notificationPayload = { const notificationPayload = {
currentWeather: this.weatherProvider?.currentWeatherObject?.simpleClone() ?? null, currentWeather: this.weatherProvider?.currentWeatherObject?.simpleClone() ?? null,
forecastArray: this.weatherProvider?.weatherForecastArray?.map((ar) => ar.simpleClone()) ?? [], forecastArray: this.weatherProvider?.weatherForecastArray?.map((ar) => ar.simpleClone()) ?? [],
hourlyArray: this.weatherProvider?.weatherHourlyArray?.map((ar) => ar.simpleClone()) ?? [], hourlyArray: this.weatherProvider?.weatherHourlyArray?.map((ar) => ar.simpleClone()) ?? [],

7
modules/default/weather/weatherobject.js
View File

@ -148,9 +148,12 @@ class WeatherObject {
} }
/** /**
* Clone to simple object to prevent mutating and deprecated legacy library. * Clone to simple object to prevent mutating and deprecation of legacy library.
* *
* @returns {object} simple object cloned. * Before being handed to other modules, mutable values must be cloned safely.
* Especially 'moment' object is not immutable, so original 'date', 'sunrise', 'sunset' could be corrupted or changed by other modules.
*
* @returns {object} plained object clone of original weatherObject
*/ */
simpleClone() { simpleClone() {
const toFlat = ["date", "sunrise", "sunset"]; const toFlat = ["date", "sunrise", "sunset"];