kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-06-27 03:39:55 +00:00
Code Issues Projects Releases Wiki Activity

fix electron start loadurl on windows when address="0.0.0.0" (#3268)

Browse Source 
> - Does the pull request solve a **related** issue?
Fixes #2550 

> - What does the pull request accomplish? Use a list if needed.

changes the loadUrl to use localhost, as electron and MM are on this
same system
the mm 'server' is still listening on all adapters, including localhost
This commit is contained in:
sam detweiler 2023-11-15 12:44:08 -06:00 committed by GitHub
parent 70ddd80632
commit 247115d2e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -36,6 +36,7 @@ _This release is scheduled to be released on 2024-01-01._
- Fix issue template (#3167) - Fix issue template (#3167)
- Fix #3256 filter out bad results from rrule.between - Fix #3256 filter out bad results from rrule.between
- Fix calendar events sometimes not respecting deleted events (#3250) - Fix calendar events sometimes not respecting deleted events (#3250)
- Fix electron loadurl locally on Windows when address "0.0.0.0" (#2550)
## [2.25.0] - 2023-10-01 ## [2.25.0] - 2023-10-01

2
js/electron.js
View File

@ -77,7 +77,7 @@ function createWindow() {
prefix = "http://"; prefix = "http://";
} }
let address = (config.address === void 0) | (config.address === "") ? (config.address = "localhost") : config.address; let address = (config.address === void 0) | (config.address === "") | (config.address === "0.0.0.0") ? (config.address = "localhost") : config.address;
mainWindow.loadURL(`${prefix}${address}:${config.port}`); mainWindow.loadURL(`${prefix}${address}:${config.port}`);
// Open the DevTools if run with "npm start dev" // Open the DevTools if run with "npm start dev"