From 8b1ce26fa6fc5fba78e67c4ddbbdc20127117336 Mon Sep 17 00:00:00 2001 From: MystaraTheGreat Date: Sun, 7 Mar 2021 11:05:29 +0000 Subject: [PATCH 1/6] Added hiddenOnStartup flag to module configuration options to cause a module to be iniitally hidden after starting up --- js/loader.js | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/js/loader.js b/js/loader.js index 91a17329..a3c639d0 100644 --- a/js/loader.js +++ b/js/loader.js @@ -54,6 +54,16 @@ var Loader = (function () { // Notify core of loaded modules. MM.modulesStarted(moduleObjects); + + // Starting modules also hides any modules that have requeste dto be initially hidden + for (var m in moduleObjects) { + var module = moduleObjects[m]; + + if (module.data.hiddenOnStartup) { + Log.info("Initially hiding " + module.name); + module.hide(); + } + } }; /** @@ -97,6 +107,7 @@ var Loader = (function () { path: moduleFolder + "/", file: moduleName + ".js", position: moduleData.position, + hiddenOnStartup: moduleData.hiddenOnStartup, header: moduleData.header, configDeepMerge: typeof moduleData.configDeepMerge === "boolean" ? moduleData.configDeepMerge : false, config: moduleData.config, From 96be8d6fea04144c81531eebf5c2730e8b053eb6 Mon Sep 17 00:00:00 2001 From: MystaraTheGreat Date: Sun, 7 Mar 2021 11:14:23 +0000 Subject: [PATCH 2/6] Updated CHANGELOG.md --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index db1f60d0..50270e71 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ This project adheres to [Semantic Versioning](https://semver.org/). ❤️ **Donate:** Enjoying MagicMirror²? [Please consider a donation!](https://magicmirror.builders/donate) With your help we can continue to improve the MagicMirror² +## [2.14.1] - 2021-03-07 + +### Added + +- @MystaraTheGreat added hiddenOnStartup flag to module config (#2475) + ## [2.14.0] - 2021-01-01 Special thanks to the following contributors: @Alvinger, @AndyPoms, @ashishtank, @bluemanos, @flopp999, @jakemulley, @jakobsarwary1, @marvai-vgtu, @mirontoli, @rejas, @sdetweil, @Snille & @Sub028. From a467d900c9fe2cfa3abdc7eaf7e6549ccce2006b Mon Sep 17 00:00:00 2001 From: MystaraTheGreat Date: Sun, 7 Mar 2021 11:20:19 +0000 Subject: [PATCH 3/6] Changed iterative variable from m to n to appease tester --- js/loader.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/loader.js b/js/loader.js index a3c639d0..07baa648 100644 --- a/js/loader.js +++ b/js/loader.js @@ -56,8 +56,8 @@ var Loader = (function () { MM.modulesStarted(moduleObjects); // Starting modules also hides any modules that have requeste dto be initially hidden - for (var m in moduleObjects) { - var module = moduleObjects[m]; + for (var n in moduleObjects) { + var module = moduleObjects[n]; if (module.data.hiddenOnStartup) { Log.info("Initially hiding " + module.name); From d83e696a8d34f2ba1fc7316e7e4046f71633211a Mon Sep 17 00:00:00 2001 From: MystaraTheGreat Date: Sun, 7 Mar 2021 11:23:52 +0000 Subject: [PATCH 4/6] Changed variable name to appease tester --- js/loader.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/js/loader.js b/js/loader.js index 07baa648..ac7d4658 100644 --- a/js/loader.js +++ b/js/loader.js @@ -55,13 +55,13 @@ var Loader = (function () { // Notify core of loaded modules. MM.modulesStarted(moduleObjects); - // Starting modules also hides any modules that have requeste dto be initially hidden + // Starting modules also hides any modules that have requested to be initially hidden for (var n in moduleObjects) { - var module = moduleObjects[n]; + var thisModule = moduleObjects[n]; - if (module.data.hiddenOnStartup) { - Log.info("Initially hiding " + module.name); - module.hide(); + if (thisModule.data.hiddenOnStartup) { + Log.info("Initially hiding " + thisModule.name); + thisModule.hide(); } } }; From 49be3cbd6b6adba364d912b5db7b2e97a35be0e9 Mon Sep 17 00:00:00 2001 From: MystaraTheGreat Date: Sun, 7 Mar 2021 20:13:57 +0000 Subject: [PATCH 5/6] Changed var to let as requested --- js/loader.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/loader.js b/js/loader.js index ac7d4658..a5e45b4e 100644 --- a/js/loader.js +++ b/js/loader.js @@ -56,8 +56,8 @@ var Loader = (function () { MM.modulesStarted(moduleObjects); // Starting modules also hides any modules that have requested to be initially hidden - for (var n in moduleObjects) { - var thisModule = moduleObjects[n]; + for (let n in moduleObjects) { + let thisModule = moduleObjects[n]; if (thisModule.data.hiddenOnStartup) { Log.info("Initially hiding " + thisModule.name); From 8f2980c23dd531c6d4e5e3d06ae006ee4dc12462 Mon Sep 17 00:00:00 2001 From: MystaraTheGreat Date: Sun, 7 Mar 2021 20:34:26 +0000 Subject: [PATCH 6/6] Fixed unnecessarily verbose way of looping thanks to @rejas :) --- js/loader.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/js/loader.js b/js/loader.js index 48e74f71..f290ff44 100644 --- a/js/loader.js +++ b/js/loader.js @@ -56,9 +56,7 @@ var Loader = (function () { MM.modulesStarted(moduleObjects); // Starting modules also hides any modules that have requested to be initially hidden - for (let n in moduleObjects) { - let thisModule = moduleObjects[n]; - + for (let thisModule of moduleObjects) { if (thisModule.data.hiddenOnStartup) { Log.info("Initially hiding " + thisModule.name); thisModule.hide();