From 9ea7de8b44a45786f9151801a5c06c72bacefd55 Mon Sep 17 00:00:00 2001 From: Mike Bishop Date: Thu, 31 Dec 2020 10:01:47 -0500 Subject: [PATCH 1/2] Permit substituting a falsy value in translator variables --- js/translator.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/translator.js b/js/translator.js index 5dc50045..82eec53a 100644 --- a/js/translator.js +++ b/js/translator.js @@ -68,7 +68,7 @@ var Translator = (function () { template = variables.fallback; } return template.replace(new RegExp("{([^}]+)}", "g"), function (_unused, varName) { - return variables[varName] || "{" + varName + "}"; + return varName in variables ? variables[varName] : "{" + varName + "}"; }); } From c9fb38981e636faffb7e7372a75300281f8e38f7 Mon Sep 17 00:00:00 2001 From: Mike Bishop Date: Thu, 31 Dec 2020 10:11:43 -0500 Subject: [PATCH 2/2] CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index eef2f82d..bf5be0bd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -58,6 +58,7 @@ _This release is scheduled to be released on 2021-01-01._ - update node-ical version again, 0.12.5, change RRULE fix (#2371, #2379) - Added missing function call in module.show() - remove undefined objects from modules array (#2382) +- Translator variables can have falsy values (e.g. empty string) ## [2.13.0] - 2020-10-01