kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-07-01 21:43:26 +00:00
Code Issues Projects Releases Wiki Activity

Open-Meteo: Fix forecast and hourly weather to use real temperatures, not apparent temperatures (#3468)

Browse Source 
As discussed in #3466, the Open-Meteo provider is using the apparent
temperature ("Feels like") in the forecast and hourly weather reporting.
This is contrary to expected behavior.

Note: I'm a little unclear on how I should be editing the `CHANGELOG.md`
file with this PR - happy to update this PR with a little guidance. This
is my first attempted PR in this project.

Let me know if there are any questions.

---------

Co-authored-by: veeck <michael.veeck@nebenan.de>
This commit is contained in:
Brian O'Connor 2024-06-24 16:18:49 -04:00 committed by GitHub
parent 8d20832bc5
commit 3d9d72e64e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -27,10 +27,11 @@ Thanks to: @kleinmantara (to be continued before release)
### Fixed
- Fix crash possibility if `module: <name>` is not defined and on `postion: <positon>` misktake.
- [core] Fixed crash possibility if `module: <name>` is not defined and on `postion: <positon>` misktake.
- [weather] Fixed precipitationProbability in forecast for provider openmeteo (#3446)
- [weather] Fixed type=daily for provider openmeteo having no data when running after 23:00 (#3449)
- [weather] Fixed type=daily for provider openmeteo showing nightly icons in forecast when current time is "nightly" (#3458)
- [weather] Fixed forecast and hourly weather for provider openmeteo to use real temperatures, not apparent temperatures
## [2.27.0] - 2024-04-01

12
modules/default/weather/providers/openmeteo.js
View File

@ -398,9 +398,9 @@ WeatherProvider.register("openmeteo", {
currentWeather.windFromDirection = weather.winddirection_10m_dominant;
currentWeather.sunrise = weather.sunrise;
currentWeather.sunset = weather.sunset;
currentWeather.temperature = parseFloat((weather.apparent_temperature_max + weather.apparent_temperature_min) / 2);
currentWeather.minTemperature = parseFloat(weather.apparent_temperature_min);
currentWeather.maxTemperature = parseFloat(weather.apparent_temperature_max);
currentWeather.temperature = parseFloat((weather.temperature_2m_max + weather.temperature_2m_min) / 2);
currentWeather.minTemperature = parseFloat(weather.temperature_2m_min);
currentWeather.maxTemperature = parseFloat(weather.temperature_2m_max);
currentWeather.weatherType = this.convertWeatherType(weather.weathercode, true);
currentWeather.rain = parseFloat(weather.rain_sum);
currentWeather.snow = parseFloat(weather.snowfall_sum * 10);
@ -432,9 +432,9 @@ WeatherProvider.register("openmeteo", {
currentWeather.windFromDirection = weather.winddirection_10m;
currentWeather.sunrise = weathers.daily[h].sunrise;
currentWeather.sunset = weathers.daily[h].sunset;
currentWeather.temperature = parseFloat(weather.apparent_temperature);
currentWeather.minTemperature = parseFloat(weathers.daily[h].apparent_temperature_min);
currentWeather.maxTemperature = parseFloat(weathers.daily[h].apparent_temperature_max);
currentWeather.temperature = parseFloat(weather.temperature_2m);
currentWeather.minTemperature = parseFloat(weathers.daily[h].temperature_2m_min);
currentWeather.maxTemperature = parseFloat(weathers.daily[h].temperature_2m_max);
currentWeather.weatherType = this.convertWeatherType(weather.weathercode, currentWeather.isDayTime());
currentWeather.humidity = parseFloat(weather.relativehumidity_2m);
currentWeather.rain = parseFloat(weather.rain);