From ada40e36db891e1176754e1499a7f994d8a35ffb Mon Sep 17 00:00:00 2001
From: rejas <github@veeck.de>
Date: Sat, 17 Apr 2021 12:35:10 +0200
Subject: [PATCH 1/5] Add codecov yaml to set informational mode

---
 codecov.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 codecov.yaml

diff --git a/codecov.yaml b/codecov.yaml
new file mode 100644
index 00000000..3f76e9b5
--- /dev/null
+++ b/codecov.yaml
@@ -0,0 +1,6 @@
+coverage:
+  status:
+    project:
+      default:
+        # advanced settings
+        informational: true

From 552e82f44df30be6c7bc63dcc72360ad375af6b3 Mon Sep 17 00:00:00 2001
From: rejas <github@veeck.de>
Date: Sat, 17 Apr 2021 12:35:46 +0200
Subject: [PATCH 2/5] Update CHANGELOG

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index efbf122d..223bed12 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -20,6 +20,7 @@ _This release is scheduled to be released on 2021-04-01._
 ### Updated
 
 - Bump node-ical to v0.13.0 (now last runtime dependency using deprecated `request` package is removed).
+- Use codecov in informational mode
 
 ### Removed
 

From 0abebc1e3274dff10de5ac74f23d9ca6dd76aec3 Mon Sep 17 00:00:00 2001
From: rejas <github@veeck.de>
Date: Sat, 17 Apr 2021 12:44:47 +0200
Subject: [PATCH 3/5] Remove some tests to see if it still errors

---
 tests/e2e/modules/alert_spec.js              |   4 -
 tests/e2e/modules/weather_spec.js            |  16 ---
 tests/e2e/modules_display_spec.js            |  41 -------
 tests/unit/classes/class_spec.js             | 109 -------------------
 tests/unit/functions/weatherforecast_spec.js |  51 ---------
 5 files changed, 221 deletions(-)
 delete mode 100644 tests/e2e/modules_display_spec.js
 delete mode 100644 tests/unit/classes/class_spec.js

diff --git a/tests/e2e/modules/alert_spec.js b/tests/e2e/modules/alert_spec.js
index 515001bf..750559a5 100644
--- a/tests/e2e/modules/alert_spec.js
+++ b/tests/e2e/modules/alert_spec.js
@@ -29,9 +29,5 @@ describe("Alert module", function () {
 			// Set config sample for use in test
 			process.env.MM_CONFIG_FILE = "tests/configs/modules/alert/default.js";
 		});
-
-		it("should show the welcome message", function () {
-			return app.client.waitUntilTextExists(".ns-box .ns-box-inner .light.bright.small", "Welcome, start was successful!", 10000);
-		});
 	});
 });
diff --git a/tests/e2e/modules/weather_spec.js b/tests/e2e/modules/weather_spec.js
index 70c88512..d2fe4ba1 100644
--- a/tests/e2e/modules/weather_spec.js
+++ b/tests/e2e/modules/weather_spec.js
@@ -257,22 +257,6 @@ describe("Weather module", function () {
 			before(function () {
 				process.env.MM_CONFIG_FILE = "tests/configs/modules/weather/forecastweather_options.js";
 			});
-
-			it("should render custom table class", async function () {
-				const weather = generateWeatherForecast();
-				await setup({ template, data: weather });
-
-				await getElement(".weather table.myTableClass");
-			});
-
-			it("should render colored rows", async function () {
-				const weather = generateWeatherForecast();
-				await setup({ template, data: weather });
-
-				const rows = await app.client.$$(".weather table.myTableClass tr.colored");
-
-				expect(rows.length).to.be.equal(5);
-			});
 		});
 
 		describe("Forecast weather units", function () {
diff --git a/tests/e2e/modules_display_spec.js b/tests/e2e/modules_display_spec.js
deleted file mode 100644
index 3dfcf26f..00000000
--- a/tests/e2e/modules_display_spec.js
+++ /dev/null
@@ -1,41 +0,0 @@
-const helpers = require("./global-setup");
-
-const describe = global.describe;
-const it = global.it;
-
-describe("Display of modules", function () {
-	helpers.setupTimeout(this);
-
-	var app = null;
-
-	beforeEach(function () {
-		return helpers
-			.startApplication({
-				args: ["js/electron.js"]
-			})
-			.then(function (startedApp) {
-				app = startedApp;
-			});
-	});
-
-	afterEach(function () {
-		return helpers.stopApplication(app);
-	});
-
-	describe("Using helloworld", function () {
-		before(function () {
-			// Set config sample for use in test
-			process.env.MM_CONFIG_FILE = "tests/configs/modules/display.js";
-		});
-
-		it("should show the test header", async () => {
-			const elem = await app.client.$("#module_0_helloworld .module-header", 10000);
-			return elem.getText("#module_0_helloworld .module-header").should.eventually.equal("TEST_HEADER");
-		});
-
-		it("should show no header if no header text is specified", async () => {
-			const elem = await app.client.$("#module_1_helloworld .module-header", 10000);
-			return elem.getText("#module_1_helloworld .module-header").should.eventually.equal(false);
-		});
-	});
-});
diff --git a/tests/unit/classes/class_spec.js b/tests/unit/classes/class_spec.js
deleted file mode 100644
index b1af5c67..00000000
--- a/tests/unit/classes/class_spec.js
+++ /dev/null
@@ -1,109 +0,0 @@
-const expect = require("chai").expect;
-const path = require("path");
-const { JSDOM } = require("jsdom");
-
-describe("File js/class", function () {
-	describe("Test function cloneObject", function () {
-		let clone;
-		let dom;
-
-		before(function (done) {
-			dom = new JSDOM(
-				`<script>var Log = {log: function() {}};</script>\
-					<script src="file://${path.join(__dirname, "..", "..", "..", "js", "class.js")}">`,
-				{ runScripts: "dangerously", resources: "usable" }
-			);
-			dom.window.onload = function () {
-				const { cloneObject } = dom.window;
-				clone = cloneObject;
-				done();
-			};
-		});
-
-		it("should clone object", function () {
-			const expected = { name: "Rodrigo", web: "https://rodrigoramirez.com", project: "MagicMirror" };
-			const obj = clone(expected);
-			expect(obj).to.deep.equal(expected);
-			expect(expected === obj).to.equal(false);
-		});
-
-		it("should clone array", function () {
-			const expected = [1, null, undefined, "TEST"];
-			const obj = clone(expected);
-			expect(obj).to.deep.equal(expected);
-			expect(expected === obj).to.equal(false);
-		});
-
-		it("should clone number", function () {
-			let expected = 1;
-			let obj = clone(expected);
-			expect(obj).to.equal(expected);
-
-			expected = 1.23;
-			obj = clone(expected);
-			expect(obj).to.equal(expected);
-		});
-
-		it("should clone string", function () {
-			const expected = "Perfect stranger";
-			const obj = clone(expected);
-			expect(obj).to.equal(expected);
-		});
-
-		it("should clone undefined", function () {
-			const expected = undefined;
-			const obj = clone(expected);
-			expect(obj).to.equal(expected);
-		});
-
-		it("should clone null", function () {
-			const expected = null;
-			const obj = clone(expected);
-			expect(obj).to.equal(expected);
-		});
-
-		it("should clone nested object", function () {
-			const expected = {
-				name: "fewieden",
-				link: "https://github.com/fewieden",
-				versions: ["2.0", "2.1", "2.2"],
-				answerForAllQuestions: 42,
-				properties: {
-					items: [{ foo: "bar" }, { lorem: "ipsum" }],
-					invalid: undefined,
-					nothing: null
-				}
-			};
-			const obj = clone(expected);
-			expect(obj).to.deep.equal(expected);
-			expect(expected === obj).to.equal(false);
-			expect(expected.versions === obj.versions).to.equal(false);
-			expect(expected.properties === obj.properties).to.equal(false);
-			expect(expected.properties.items === obj.properties.items).to.equal(false);
-			expect(expected.properties.items[0] === obj.properties.items[0]).to.equal(false);
-			expect(expected.properties.items[1] === obj.properties.items[1]).to.equal(false);
-		});
-
-		describe("Test lockstring code", function () {
-			let log;
-
-			before(function () {
-				log = dom.window.Log.log;
-				dom.window.Log.log = function cmp(str) {
-					expect(str).to.equal("lockStrings");
-				};
-			});
-
-			after(function () {
-				dom.window.Log.log = log;
-			});
-
-			it("should clone object and log lockStrings", function () {
-				const expected = { name: "Module", lockStrings: "stringLock" };
-				const obj = clone(expected);
-				expect(obj).to.deep.equal(expected);
-				expect(expected === obj).to.equal(false);
-			});
-		});
-	});
-});
diff --git a/tests/unit/functions/weatherforecast_spec.js b/tests/unit/functions/weatherforecast_spec.js
index 96ddc77f..c2dcb486 100644
--- a/tests/unit/functions/weatherforecast_spec.js
+++ b/tests/unit/functions/weatherforecast_spec.js
@@ -15,57 +15,6 @@ describe("Functions module weatherforecast", function () {
 		Module.definitions.weatherforecast.config = {};
 	});
 
-	describe("roundValue", function () {
-		describe("this.config.roundTemp is true", function () {
-			before(function () {
-				Module.definitions.weatherforecast.config.roundTemp = true;
-			});
-
-			var values = [
-				// index 0 value
-				// index 1 expect
-				[1, "1"],
-				[1.0, "1"],
-				[1.02, "1"],
-				[10.12, "10"],
-				[2.0, "2"],
-				["2.12", "2"],
-				[10.1, "10"]
-			];
-
-			values.forEach((value) => {
-				it(`for ${value[0]} should be return ${value[1]}`, function () {
-					expect(Module.definitions.weatherforecast.roundValue(value[0])).to.equal(value[1]);
-				});
-			});
-		});
-
-		describe("this.config.roundTemp is false", function () {
-			before(function () {
-				Module.definitions.weatherforecast.config.roundTemp = false;
-			});
-
-			var values = [
-				// index 0 value
-				// index 1 expect
-				[1, "1.0"],
-				[1.0, "1.0"],
-				[1.02, "1.0"],
-				[10.12, "10.1"],
-				[2.0, "2.0"],
-				["2.12", "2.1"],
-				[10.1, "10.1"],
-				[10.1, "10.1"]
-			];
-
-			values.forEach((value) => {
-				it(`for ${value[0]} should be return ${value[1]}`, function () {
-					expect(Module.definitions.weatherforecast.roundValue(value[0])).to.equal(value[1]);
-				});
-			});
-		});
-	});
-
 	describe("forecastIcons", function () {
 		Log = {
 			error: function () {}

From 5eb66106b999cc95963eea1f0765876398d6f4d9 Mon Sep 17 00:00:00 2001
From: rejas <github@veeck.de>
Date: Sat, 17 Apr 2021 13:17:24 +0200
Subject: [PATCH 4/5] Rename yaml file

---
 codecov.yaml => codecov.yml | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename codecov.yaml => codecov.yml (100%)

diff --git a/codecov.yaml b/codecov.yml
similarity index 100%
rename from codecov.yaml
rename to codecov.yml

From 8e76cdcb57a69de33ceb0dd1482c0300b8c4a591 Mon Sep 17 00:00:00 2001
From: rejas <github@veeck.de>
Date: Sat, 17 Apr 2021 12:44:47 +0200
Subject: [PATCH 5/5] Revert "Remove some tests to see if it still errors"

This reverts commit 0abebc1e3274dff10de5ac74f23d9ca6dd76aec3.
---
 tests/e2e/modules/alert_spec.js              |   4 +
 tests/e2e/modules/weather_spec.js            |  16 +++
 tests/e2e/modules_display_spec.js            |  41 +++++++
 tests/unit/classes/class_spec.js             | 109 +++++++++++++++++++
 tests/unit/functions/weatherforecast_spec.js |  51 +++++++++
 5 files changed, 221 insertions(+)
 create mode 100644 tests/e2e/modules_display_spec.js
 create mode 100644 tests/unit/classes/class_spec.js

diff --git a/tests/e2e/modules/alert_spec.js b/tests/e2e/modules/alert_spec.js
index 750559a5..515001bf 100644
--- a/tests/e2e/modules/alert_spec.js
+++ b/tests/e2e/modules/alert_spec.js
@@ -29,5 +29,9 @@ describe("Alert module", function () {
 			// Set config sample for use in test
 			process.env.MM_CONFIG_FILE = "tests/configs/modules/alert/default.js";
 		});
+
+		it("should show the welcome message", function () {
+			return app.client.waitUntilTextExists(".ns-box .ns-box-inner .light.bright.small", "Welcome, start was successful!", 10000);
+		});
 	});
 });
diff --git a/tests/e2e/modules/weather_spec.js b/tests/e2e/modules/weather_spec.js
index d2fe4ba1..70c88512 100644
--- a/tests/e2e/modules/weather_spec.js
+++ b/tests/e2e/modules/weather_spec.js
@@ -257,6 +257,22 @@ describe("Weather module", function () {
 			before(function () {
 				process.env.MM_CONFIG_FILE = "tests/configs/modules/weather/forecastweather_options.js";
 			});
+
+			it("should render custom table class", async function () {
+				const weather = generateWeatherForecast();
+				await setup({ template, data: weather });
+
+				await getElement(".weather table.myTableClass");
+			});
+
+			it("should render colored rows", async function () {
+				const weather = generateWeatherForecast();
+				await setup({ template, data: weather });
+
+				const rows = await app.client.$$(".weather table.myTableClass tr.colored");
+
+				expect(rows.length).to.be.equal(5);
+			});
 		});
 
 		describe("Forecast weather units", function () {
diff --git a/tests/e2e/modules_display_spec.js b/tests/e2e/modules_display_spec.js
new file mode 100644
index 00000000..3dfcf26f
--- /dev/null
+++ b/tests/e2e/modules_display_spec.js
@@ -0,0 +1,41 @@
+const helpers = require("./global-setup");
+
+const describe = global.describe;
+const it = global.it;
+
+describe("Display of modules", function () {
+	helpers.setupTimeout(this);
+
+	var app = null;
+
+	beforeEach(function () {
+		return helpers
+			.startApplication({
+				args: ["js/electron.js"]
+			})
+			.then(function (startedApp) {
+				app = startedApp;
+			});
+	});
+
+	afterEach(function () {
+		return helpers.stopApplication(app);
+	});
+
+	describe("Using helloworld", function () {
+		before(function () {
+			// Set config sample for use in test
+			process.env.MM_CONFIG_FILE = "tests/configs/modules/display.js";
+		});
+
+		it("should show the test header", async () => {
+			const elem = await app.client.$("#module_0_helloworld .module-header", 10000);
+			return elem.getText("#module_0_helloworld .module-header").should.eventually.equal("TEST_HEADER");
+		});
+
+		it("should show no header if no header text is specified", async () => {
+			const elem = await app.client.$("#module_1_helloworld .module-header", 10000);
+			return elem.getText("#module_1_helloworld .module-header").should.eventually.equal(false);
+		});
+	});
+});
diff --git a/tests/unit/classes/class_spec.js b/tests/unit/classes/class_spec.js
new file mode 100644
index 00000000..b1af5c67
--- /dev/null
+++ b/tests/unit/classes/class_spec.js
@@ -0,0 +1,109 @@
+const expect = require("chai").expect;
+const path = require("path");
+const { JSDOM } = require("jsdom");
+
+describe("File js/class", function () {
+	describe("Test function cloneObject", function () {
+		let clone;
+		let dom;
+
+		before(function (done) {
+			dom = new JSDOM(
+				`<script>var Log = {log: function() {}};</script>\
+					<script src="file://${path.join(__dirname, "..", "..", "..", "js", "class.js")}">`,
+				{ runScripts: "dangerously", resources: "usable" }
+			);
+			dom.window.onload = function () {
+				const { cloneObject } = dom.window;
+				clone = cloneObject;
+				done();
+			};
+		});
+
+		it("should clone object", function () {
+			const expected = { name: "Rodrigo", web: "https://rodrigoramirez.com", project: "MagicMirror" };
+			const obj = clone(expected);
+			expect(obj).to.deep.equal(expected);
+			expect(expected === obj).to.equal(false);
+		});
+
+		it("should clone array", function () {
+			const expected = [1, null, undefined, "TEST"];
+			const obj = clone(expected);
+			expect(obj).to.deep.equal(expected);
+			expect(expected === obj).to.equal(false);
+		});
+
+		it("should clone number", function () {
+			let expected = 1;
+			let obj = clone(expected);
+			expect(obj).to.equal(expected);
+
+			expected = 1.23;
+			obj = clone(expected);
+			expect(obj).to.equal(expected);
+		});
+
+		it("should clone string", function () {
+			const expected = "Perfect stranger";
+			const obj = clone(expected);
+			expect(obj).to.equal(expected);
+		});
+
+		it("should clone undefined", function () {
+			const expected = undefined;
+			const obj = clone(expected);
+			expect(obj).to.equal(expected);
+		});
+
+		it("should clone null", function () {
+			const expected = null;
+			const obj = clone(expected);
+			expect(obj).to.equal(expected);
+		});
+
+		it("should clone nested object", function () {
+			const expected = {
+				name: "fewieden",
+				link: "https://github.com/fewieden",
+				versions: ["2.0", "2.1", "2.2"],
+				answerForAllQuestions: 42,
+				properties: {
+					items: [{ foo: "bar" }, { lorem: "ipsum" }],
+					invalid: undefined,
+					nothing: null
+				}
+			};
+			const obj = clone(expected);
+			expect(obj).to.deep.equal(expected);
+			expect(expected === obj).to.equal(false);
+			expect(expected.versions === obj.versions).to.equal(false);
+			expect(expected.properties === obj.properties).to.equal(false);
+			expect(expected.properties.items === obj.properties.items).to.equal(false);
+			expect(expected.properties.items[0] === obj.properties.items[0]).to.equal(false);
+			expect(expected.properties.items[1] === obj.properties.items[1]).to.equal(false);
+		});
+
+		describe("Test lockstring code", function () {
+			let log;
+
+			before(function () {
+				log = dom.window.Log.log;
+				dom.window.Log.log = function cmp(str) {
+					expect(str).to.equal("lockStrings");
+				};
+			});
+
+			after(function () {
+				dom.window.Log.log = log;
+			});
+
+			it("should clone object and log lockStrings", function () {
+				const expected = { name: "Module", lockStrings: "stringLock" };
+				const obj = clone(expected);
+				expect(obj).to.deep.equal(expected);
+				expect(expected === obj).to.equal(false);
+			});
+		});
+	});
+});
diff --git a/tests/unit/functions/weatherforecast_spec.js b/tests/unit/functions/weatherforecast_spec.js
index c2dcb486..96ddc77f 100644
--- a/tests/unit/functions/weatherforecast_spec.js
+++ b/tests/unit/functions/weatherforecast_spec.js
@@ -15,6 +15,57 @@ describe("Functions module weatherforecast", function () {
 		Module.definitions.weatherforecast.config = {};
 	});
 
+	describe("roundValue", function () {
+		describe("this.config.roundTemp is true", function () {
+			before(function () {
+				Module.definitions.weatherforecast.config.roundTemp = true;
+			});
+
+			var values = [
+				// index 0 value
+				// index 1 expect
+				[1, "1"],
+				[1.0, "1"],
+				[1.02, "1"],
+				[10.12, "10"],
+				[2.0, "2"],
+				["2.12", "2"],
+				[10.1, "10"]
+			];
+
+			values.forEach((value) => {
+				it(`for ${value[0]} should be return ${value[1]}`, function () {
+					expect(Module.definitions.weatherforecast.roundValue(value[0])).to.equal(value[1]);
+				});
+			});
+		});
+
+		describe("this.config.roundTemp is false", function () {
+			before(function () {
+				Module.definitions.weatherforecast.config.roundTemp = false;
+			});
+
+			var values = [
+				// index 0 value
+				// index 1 expect
+				[1, "1.0"],
+				[1.0, "1.0"],
+				[1.02, "1.0"],
+				[10.12, "10.1"],
+				[2.0, "2.0"],
+				["2.12", "2.1"],
+				[10.1, "10.1"],
+				[10.1, "10.1"]
+			];
+
+			values.forEach((value) => {
+				it(`for ${value[0]} should be return ${value[1]}`, function () {
+					expect(Module.definitions.weatherforecast.roundValue(value[0])).to.equal(value[1]);
+				});
+			});
+		});
+	});
+
 	describe("forecastIcons", function () {
 		Log = {
 			error: function () {}