From 581af762f9e022f635daa0186c564691a27ad9fd Mon Sep 17 00:00:00 2001 From: fewieden Date: Sat, 22 Apr 2017 11:35:42 +0200 Subject: [PATCH] bugfix for duplicated compliments --- CHANGELOG.md | 1 + modules/default/compliments/compliments.js | 7 +++---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a0816b3e..53257e4a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). ### Fixed - Fix instruction in README for using automatically installer script. +- Bug of duplicated compliments as described in [here](https://forum.magicmirror.builders/topic/2381/compliments-module-stops-cycling-compliments). ## [2.1.1] - 2017-04-01 diff --git a/modules/default/compliments/compliments.js b/modules/default/compliments/compliments.js index b9f2011e..6cca95fc 100644 --- a/modules/default/compliments/compliments.js +++ b/modules/default/compliments/compliments.js @@ -99,11 +99,11 @@ Module.register("compliments", { var compliments = null; if (hour >= 3 && hour < 12) { - compliments = this.config.compliments.morning; + compliments = this.config.compliments.morning.slice(0); } else if (hour >= 12 && hour < 17) { - compliments = this.config.compliments.afternoon; + compliments = this.config.compliments.afternoon.slice(0); } else { - compliments = this.config.compliments.evening; + compliments = this.config.compliments.evening.slice(0); } if (typeof compliments === "undefined") { @@ -117,7 +117,6 @@ Module.register("compliments", { compliments.push.apply(compliments, this.config.compliments.anytime); return compliments; - }, /* complimentFile(callback)