kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-06-27 11:50:00 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2447 from rejas/warn_dom

Browse Source 
Warn dom
This commit is contained in:
Michael Teeuw 2021-02-06 11:01:21 +01:00 committed by GitHub
commit 6fadc76fe3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -27,7 +27,8 @@ _This release is scheduled to be released on 2021-04-01._
- Converted newsfeed module to use templates. - Converted newsfeed module to use templates.
- Update documentation and help screen about invalid config files. - Update documentation and help screen about invalid config files.
- Moving weather provider specific code and configuration into each provider and making hourly part of the interface. - Moving weather provider specific code and configuration into each provider and making hourly part of the interface.
- Bump electron to v11 - Bump electron to v11.
- Dont update the DOM when a module is not displayed.
### Removed ### Removed

5
js/main.js
View File

@ -547,6 +547,11 @@ var MM = (function () {
return; return;
} }
if (!module.data.position) {
Log.warn("module tries to update the DOM without being displayed.");
return;
}
// Further implementation is done in the private method. // Further implementation is done in the private method.
updateDom(module, speed); updateDom(module, speed);
}, },