kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-06-27 19:53:36 +00:00
Code Issues Projects Releases Wiki Activity

Add (in Alert module) templateName parameter (#3009)

Browse Source 
This simple change allows to use your own templates (under "templates"
directory). The parameter `templateName` is optional (ignored on falsy
value - undefined, null, empty string, etc.) and independent of `type`.

Co-authored-by: Veeck <github@veeck.de>
This commit is contained in:
Piotr Rajnisz 2023-01-26 13:00:49 +01:00 committed by GitHub
parent f6dcfb5ca3
commit 7198ae5eae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -15,6 +15,7 @@ _This release is scheduled to be released on 2023-04-01._
- Added tests for hourly weather forecast - Added tests for hourly weather forecast
- Added possibility to ignore MagicMirror repo in updatenotification module - Added possibility to ignore MagicMirror repo in updatenotification module
- Added Pirate Weather as new weather provider (#3005) - Added Pirate Weather as new weather provider (#3005)
- Added possibility to use your own templates in Alert module
- Added error message if `<modulename>.js` file is missing in module folder to get a hint in the logs (#2403) - Added error message if `<modulename>.js` file is missing in module folder to get a hint in the logs (#2403)
### Removed ### Removed

4
modules/default/alert/alert.js
View File

@ -69,7 +69,7 @@ Module.register("alert", {
}, },
async showNotification(notification) { async showNotification(notification) {
const message = await this.renderMessage("notification", notification); const message = await this.renderMessage(notification.templateName || "notification", notification);
new NotificationFx({ new NotificationFx({
message, message,
@ -90,7 +90,7 @@ Module.register("alert", {
this.toggleBlur(true); this.toggleBlur(true);
} }
const message = await this.renderMessage("alert", alert); const message = await this.renderMessage(alert.templateName || "alert", alert);
// Store alert in this.alerts // Store alert in this.alerts
this.alerts[sender.name] = new NotificationFx({ this.alerts[sender.name] = new NotificationFx({