From 1dfec119bb98300c9bf931dd1b1708ce43ba32bc Mon Sep 17 00:00:00 2001 From: Fritz Jay Date: Tue, 12 Nov 2019 18:16:55 -0800 Subject: [PATCH 1/3] Fixed bug that was causing predicted amount of rain value to use DOT as a decimal separator regardless of the decimalSymbol config value. --- modules/default/weatherforecast/weatherforecast.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/default/weatherforecast/weatherforecast.js b/modules/default/weatherforecast/weatherforecast.js index c4d43ede..b8fab9e4 100644 --- a/modules/default/weatherforecast/weatherforecast.js +++ b/modules/default/weatherforecast/weatherforecast.js @@ -180,9 +180,9 @@ Module.register("weatherforecast",{ rainCell.innerHTML = ""; } else { if(config.units !== "imperial") { - rainCell.innerHTML = parseFloat(forecast.rain).toFixed(1) + " mm"; + rainCell.innerHTML = parseFloat(forecast.rain).toFixed(1).replace(".", this.config.decimalSymbol) + " mm"; } else { - rainCell.innerHTML = (parseFloat(forecast.rain) / 25.4).toFixed(2) + " in"; + rainCell.innerHTML = (parseFloat(forecast.rain) / 25.4).toFixed(2).replace(".", this.config.decimalSymbol) + " in"; } } rainCell.className = "align-right bright rain"; From 8900e069f331021c353c5767d76f470b4d2a3ea7 Mon Sep 17 00:00:00 2001 From: Fritz Jay Date: Tue, 12 Nov 2019 19:26:38 -0800 Subject: [PATCH 2/3] Updated changelog --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4c5fc3da..e42770a6 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,7 +25,8 @@ This project adheres to [Semantic Versioning](http://semver.org/). ### Updated ### Fixed - +- Fixed issue in weatherforecast module where predicated amount of rain was not using the decimal symbol specified in config.js. + ## [2.9.0] - 2019-10-01 ℹ️ **Note:** This update uses new dependencies. Please update using the following command: `git pull && npm install`. If you are having issues running Electron, make sure your [Raspbian is up to date](https://www.raspberrypi.org/documentation/raspbian/updating.md). From 24f74e1400a106fee87198544755bee1e2d9702b Mon Sep 17 00:00:00 2001 From: Fritz Jay Date: Tue, 12 Nov 2019 19:30:42 -0800 Subject: [PATCH 3/3] Fixed spelling error. --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e42770a6..38b1543f 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,7 +25,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). ### Updated ### Fixed -- Fixed issue in weatherforecast module where predicated amount of rain was not using the decimal symbol specified in config.js. +- Fixed issue in weatherforecast module where predicted amount of rain was not using the decimal symbol specified in config.js. ## [2.9.0] - 2019-10-01