From 35174b0348fe032b6ebdfcc08f46793454e615e0 Mon Sep 17 00:00:00 2001 From: Thierry Nischelwitzer Date: Sun, 7 Apr 2019 11:15:16 +0200 Subject: [PATCH 1/3] bugfixing calendar module --- modules/default/calendar/vendor/ical.js/node-ical.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/default/calendar/vendor/ical.js/node-ical.js b/modules/default/calendar/vendor/ical.js/node-ical.js index e42ce895..e35d856a 100644 --- a/modules/default/calendar/vendor/ical.js/node-ical.js +++ b/modules/default/calendar/vendor/ical.js/node-ical.js @@ -41,8 +41,10 @@ ical.objectHandlers['END'] = function(val, params, curr, stack){ rule = rule.replace(/\.[0-9]{3}/, ''); } for (var i in curr.exdates) { - rule += ' EXDATE:' + curr.exdates[i].toISOString().replace(/[-:]/g, ''); - rule = rule.replace(/\.[0-9]{3}/, ''); + if (typeof curr.exdates[i] === 'object') { + rule += ' EXDATE:' + curr.exdates[i].toISOString().replace(/[-:]/g, ''); + rule = rule.replace(/\.[0-9]{3}/, ''); + } } try { curr.rrule = rrulestr(rule); From 11c9a50931a7d020229a4dcfbbf0b6b88554d8f7 Mon Sep 17 00:00:00 2001 From: Thierry Nischelwitzer Date: Tue, 9 Jul 2019 10:20:02 +0200 Subject: [PATCH 2/3] send NEWS_FEED notification also for the first newsmessage which are shown --- modules/default/newsfeed/newsfeed.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/modules/default/newsfeed/newsfeed.js b/modules/default/newsfeed/newsfeed.js index f1cd53de..d358110c 100644 --- a/modules/default/newsfeed/newsfeed.js +++ b/modules/default/newsfeed/newsfeed.js @@ -327,6 +327,11 @@ Module.register("newsfeed",{ self.updateDom(self.config.animationSpeed); + // Broadcast NewsFeed if needed + if (self.config.broadcastNewsFeeds) { + self.sendNotification("NEWS_FEED", {items: self.newsItems}); + } + timer = setInterval(function() { self.activeItem++; self.updateDom(self.config.animationSpeed); From 312bfb85097e8a1d2104c510b2f8d44f879fa024 Mon Sep 17 00:00:00 2001 From: Thierry Nischelwitzer Date: Tue, 9 Jul 2019 10:24:43 +0200 Subject: [PATCH 3/3] add changes to changelog --- CHANGELOG.md | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bfcf5820..7981d439 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,11 @@ This project adheres to [Semantic Versioning](http://semver.org/). ❤️ **Donate:** Enjoying MagicMirror²? [Please consider a donation!](https://magicmirror.builders/donate) With your help we can continue to improve the MagicMirror² core. +## [2.9.0] - 2019-10-01 + +### Fixed +- Send `NEWS_FEED` Notification also for the first newsmessage which are shown + ## [2.8.0] - 2019-07-01 ℹ️ **Note:** This update uses new dependencies. Please update using the following command: `git pull && npm install`. If you are having issues running Electron, make sure your [Raspbian is up to date](https://www.raspberrypi.org/documentation/raspbian/updating.md). @@ -28,18 +33,18 @@ This project adheres to [Semantic Versioning](http://semver.org/). - Automatically try to fix eslint errors by passing `--fix` option to it - Added sunrise and sunset times to weathergov weather provider [#1705](https://github.com/MichMich/MagicMirror/issues/1705) - Added "useLocationAsHeader" to display "location" in `config.js` as header when location name is not returned -- Added to `newsfeed.js`: in order to design the news article better with css, three more class-names were introduced: newsfeed-desc, newsfeed-desc, newsfeed-desc +- Added to `newsfeed.js`: in order to design the news article better with css, three more class-names were introduced: newsfeed-desc, newsfeed-desc, newsfeed-desc ### Updated - English translation for "Feels" to "Feels like" - Fixed the example calender url in `config.js.sample` - Update `ical.js` to solve various calendar issues. -- Update weather city list url [#1676](https://github.com/MichMich/MagicMirror/issues/1676) +- Update weather city list url [#1676](https://github.com/MichMich/MagicMirror/issues/1676) - Only update clock once per minute when seconds aren't shown ### Fixed -- Fixed uncaught exception, race condition on module update -- Fixed issue [#1696](https://github.com/MichMich/MagicMirror/issues/1696), some ical files start date to not parse to date type +- Fixed uncaught exception, race condition on module update +- Fixed issue [#1696](https://github.com/MichMich/MagicMirror/issues/1696), some ical files start date to not parse to date type - Allowance HTML5 autoplay-policy (policy is changed from Chrome 66 updates) - Handle SIGTERM messages - Fixes sliceMultiDayEvents so it respects maximumNumberOfDays