From 7ba96aeb98cb17a7f590603a0ee4de5ada84e8bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= Date: Sun, 20 Aug 2023 13:14:21 +0200 Subject: [PATCH] Add Npmrc (#3135) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix engines check on npm install it will alow to check engine requirement of `package.json` actually: ```js "engines": { "node": ">=16" } ``` if requirements are not suitable, it's break installer ```sh bugsounet@Kubuntu:~/MagicMirror-dev$ npm install npm ERR! code EBADENGINE npm ERR! engine Unsupported engine npm ERR! engine Not compatible with your version of node/npm: magicmirror@2.24.0-develop npm ERR! notsup Not compatible with your version of node/npm: magicmirror@2.24.0-develop npm ERR! notsup Required: {"node":">=16"} npm ERR! notsup Actual: {"npm":"x.y.z","node":"v14.xx.yy"} ``` actually, it's just a warn: ```sh bugsounet@KUbuntu:~/MagicMirror-dev$ npm install npm WARN EBADENGINE Unsupported engine { npm WARN EBADENGINE package: 'magicmirror@2.24.0-develop', npm WARN EBADENGINE required: { node: '>=16' }, npm WARN EBADENGINE current: { node: 'v14.xx.yy', npm: 'x.y.z' } npm WARN EBADENGINE } ... ``` and don't break installation, this can causes errors in the main core of MM² --------- Co-authored-by: veeck --- .npmrc | 2 ++ CHANGELOG.md | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 .npmrc diff --git a/.npmrc b/.npmrc new file mode 100644 index 00000000..386ea9ae --- /dev/null +++ b/.npmrc @@ -0,0 +1,2 @@ +engine-strict=true +audit=false diff --git a/CHANGELOG.md b/CHANGELOG.md index c4b2885e..fb5157d4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,10 +21,11 @@ _This release is scheduled to be released on 2023-10-01._ - Update issue template - Update dependencies incl. electron to v26 - Replace pretty-quick by lint-staged () -- Minimum node version is now v18. v16 reached it's end of life. +- Update engine node >=18. v16 reached it's end of life. (#3170) ### Fixed +- Fix engine check on npm install (#3135) - Fix undefined formatTime method in clock module (#3143) - Fix clientonly startup fails after async added (#3151) - Fix electron width/heigth when using xrandr under bullseye