Wait till all node_helper are started before finishing startup (#2928)

In response to #2487 this implements a Promise.all for the node_helper
start calls

Co-authored-by: veeck <michael@veeck.de>

CHANGELOG.md

@@ -23,6 +23,7 @@ Special thanks to: @rejas, @sdetweil
 ### Updated
 
 - Cleaned up test directory
+- Wait for all modules to start before declaring the system ready (#2487)
 - Updated e2e tests (moved `done()` in helper functions) and use es6 syntax in all tests
 - Updated da translation
 - Rework weather module

js/app.js

@@ -226,12 +226,15 @@ function App() {
 				httpServer = new Server(config, function (app, io) {
 					Log.log("Server started ...");
 
+					const nodePromises = [];
+
 					for (let nodeHelper of nodeHelpers) {
 						nodeHelper.setExpressApp(app);
 						nodeHelper.setSocketIO(io);
-						nodeHelper.start();
+						nodePromises.push(nodeHelper.start());
 					}
 
+					Promise.allSettled(nodePromises).then(() => {
 						Log.log("Sockets connected & modules started ...");
 
 						if (typeof callback === "function") {
@@ -240,6 +243,7 @@ function App() {
 					});
 				});
 			});
+		});
 	};
 
 	/**