kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-06-27 11:50:00 +00:00
Code Issues Projects Releases Wiki Activity

[refactor] Replace deprecated constants (#3789)

Browse Source 
`fs.F_OK` and `fs.R_OK` are [deprecated since a while node
20.8.0](https://nodejs.org/api/deprecations.html#DEP0176).

Node 24 now complains about them when running server mode (`node --run
server`):

```bash
[2025-05-23 23:11:44.932] [ERROR] (node:37733) [DEP0176] DeprecationWarning: fs.F_OK is deprecated, use fs.constants.F_OK instead
(Use `node --trace-deprecation ...` to show where the warning was created) 
```

The replacements have been in place for a while, and this change should
work without any issues.
This commit is contained in:
Kristjan ESPERANTO 2025-05-23 23:57:50 +02:00 committed by GitHub
parent 4e3821c2ff
commit 85b4ece767
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@ -30,17 +30,18 @@ planned for 2025-07-01
- Replace `eslint-plugin-import` with `eslint-plugin-import-x` - Replace `eslint-plugin-import` with `eslint-plugin-import-x`
- Switch Stylelint config to flat format and simplify Stylelint scripts - Switch Stylelint config to flat format and simplify Stylelint scripts
- [workflow] Replace Node.js version v23 with v24 (#3770) - [workflow] Replace Node.js version v23 with v24 (#3770)
- [refactor] Replace deprecated constants `fs.F_OK` and `fs.R_OK` (#3789)
### Fixed ### Fixed
- [fix] Handle spellcheck issues (#3783) - [fix] Handle spellcheck issues (#3783)
- [calendar] fix fullday event rrule until with timezone offset (#3781) - [calendar] fix fullday event rrule until with timezone offset (#3781)
- [feat] Add rule `no-undef` in config file validation to fix #3785 (#3786) - [feat] Add rule `no-undef` in config file validation to fix #3785 (#3786)
- [fonts] Fix `roboto.css` to avoid error message `Unknown descriptor 'var(' in @font-face rule.` in firefox console - [fonts] Fix `roboto.css` to avoid error message `Unknown descriptor 'var(' in @font-face rule.` in firefox console (#3787)
### Updated ### Updated
- [core] Update dependencies incl. electron to v36 (#3774) - [core] Update dependencies incl. electron to v36 (#3774, #3788)
## [2.31.0] - 2025-04-01 ## [2.31.0] - 2025-04-01

8
js/app.js
View File

@ -77,7 +77,7 @@ function App () {
// check if templateFile exists // check if templateFile exists
try { try {
fs.accessSync(templateFile, fs.F_OK); fs.accessSync(templateFile, fs.constants.F_OK);
} catch (err) { } catch (err) {
templateFile = null; templateFile = null;
Log.log("config template file not exists, no envsubst"); Log.log("config template file not exists, no envsubst");
@ -126,7 +126,7 @@ function App () {
require(`${global.root_path}/js/check_config.js`); require(`${global.root_path}/js/check_config.js`);
try { try {
fs.accessSync(configFilename, fs.F_OK); fs.accessSync(configFilename, fs.constants.F_OK);
const c = require(configFilename); const c = require(configFilename);
if (Object.keys(c).length === 0) { if (Object.keys(c).length === 0) {
Log.error("WARNING! Config file appears empty, maybe missing module.exports last line?"); Log.error("WARNING! Config file appears empty, maybe missing module.exports last line?");
@ -198,7 +198,7 @@ function App () {
const moduleFile = `${moduleFolder}/${moduleName}.js`; const moduleFile = `${moduleFolder}/${moduleName}.js`;
try { try {
fs.accessSync(moduleFile, fs.R_OK); fs.accessSync(moduleFile, fs.constants.R_OK);
} catch (e) { } catch (e) {
Log.warn(`No ${moduleFile} found for module: ${moduleName}.`); Log.warn(`No ${moduleFile} found for module: ${moduleName}.`);
} }
@ -207,7 +207,7 @@ function App () {
let loadHelper = true; let loadHelper = true;
try { try {
fs.accessSync(helperPath, fs.R_OK); fs.accessSync(helperPath, fs.constants.R_OK);
} catch (e) { } catch (e) {
loadHelper = false; loadHelper = false;
Log.log(`No helper found for module: ${moduleName}.`); Log.log(`No helper found for module: ${moduleName}.`);

2
js/check_config.js
View File

@ -35,7 +35,7 @@ function checkConfigFile () {
// Check permission // Check permission
try { try {
fs.accessSync(configFileName, fs.F_OK); fs.accessSync(configFileName, fs.constants.F_OK);
} catch (error) { } catch (error) {
throw new Error(`${error}\nNo permission to access config file!`); throw new Error(`${error}\nNo permission to access config file!`);
} }