From 56c94a29868631a11be87994a06128e58c77d260 Mon Sep 17 00:00:00 2001 From: Nicholas Hubbard Date: Fri, 8 Apr 2016 20:45:14 -0400 Subject: [PATCH 1/5] Contribution: Part I --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index f2c88720..ceaf3b6e 100644 --- a/README.md +++ b/README.md @@ -2,6 +2,7 @@ [![Dependency Status](https://david-dm.org/MichMich/MagicMirror/v2-beta.svg)](https://david-dm.org/MichMich/MagicMirror/v2-beta) [![devDependency Status](https://david-dm.org/MichMich/MagicMirror/v2-beta/dev-status.svg)](https://david-dm.org/MichMich/MagicMirror/v2-beta#info=devDependencies) +[![Node Version](https://img.shields.io/badge/node-v5.10.1-brightgreen.svg)](https://nodejs.org/dist/latest) This version of the Magic Mirror software focusses on a modular plugin system. Besides that, the Magic Mirror software now also uses [Electron](http://electron.atom.io/), so no more webserver or browser installs necessary. @@ -31,7 +32,7 @@ This version of the Magic Mirror software focusses on a modular plugin system. B **Important:** `npm start` does **not** work via SSH, use `DISPLAY=:0 nohup npm start &` instead. This starts the mirror on the remote display. -#### Server only +#### Server Only In some cases, you want to start the application without an actual app window. In this case, exectute the following command from the MagicMirror folder: `node serveronly`. This will start the server, after which you can open the application in your browser of choice. From 838635ae4ddb6c89c0dd41b2f6217e5b76bc04f3 Mon Sep 17 00:00:00 2001 From: Nicholas Hubbard Date: Sat, 9 Apr 2016 09:12:51 -0400 Subject: [PATCH 2/5] Templating: Part I Create the issue template in the proper folder. --- .github/ISSUE_TEMPLATE.md | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 00000000..1553010e --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,2 @@ +* **Platform** [ Raspberry Pi 2/3, Windows, Mac OS X, Linux]: +* **Node Version** [ 0.12.13 or later ]: From 9ab020518efc4ab61c1b65d495d8af1192778830 Mon Sep 17 00:00:00 2001 From: Nicholas Hubbard Date: Sat, 9 Apr 2016 09:13:31 -0400 Subject: [PATCH 3/5] Templating: Part II Remove the improperly titled and saved issue template. --- issue_template.md | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 issue_template.md diff --git a/issue_template.md b/issue_template.md deleted file mode 100644 index a2cb168b..00000000 --- a/issue_template.md +++ /dev/null @@ -1,5 +0,0 @@ -Platform: [Raspberry Pi 2, Raspberry Pi 3, Mac, Windows, ...] -Operating System: [Jessie, OS X, Windows 10, ...] -Node version: - - From 8d29947e32e5779a58bef962a28d0c8a7d585eaa Mon Sep 17 00:00:00 2001 From: Nicholas Hubbard Date: Sat, 9 Apr 2016 09:17:25 -0400 Subject: [PATCH 4/5] Templating: Part III Create pull request template. --- .github/PULL_REQUEST_TEMPLATE.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..22782a1a --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,5 @@ +* Does the pull request solve a **related** issue? [yes | no] + +* If so, can you reference the issue? + +* What does the pull request accomplish? (please accomplish) From 239db35ba01897ad79ee4a89182fb6a7b445243a Mon Sep 17 00:00:00 2001 From: Nicholas Hubbard Date: Sat, 9 Apr 2016 14:21:40 -0400 Subject: [PATCH 5/5] Contribution: Part II --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 22782a1a..35c40ef3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,4 +2,4 @@ * If so, can you reference the issue? -* What does the pull request accomplish? (please accomplish) +* What does the pull request accomplish? (please list)