Add fetcher_helper for calendar and newsfeed

js/fetcher_helper.js

@@ -0,0 +1,12 @@
+const FetcherHelper = {
+	checkStatus: function (response) {
+		// response.status >= 200 && response.status < 300
+		if (response.ok) {
+			return response;
+		} else {
+			throw Error(response.statusText);
+		}
+	}
+};
+
+module.exports = FetcherHelper;

modules/default/calendar/calendarfetcher.js

@@ -5,6 +5,7 @@
  * MIT Licensed.
  */
 const CalendarUtils = require("./calendarutils");
+const FetcherHelper = require("fetcher_helper");
 const Log = require("logger");
 const ical = require("node-ical");
 const fetch = require("node-fetch");
@@ -62,17 +63,7 @@ const CalendarFetcher = function (url, reloadInterval, excludedEvents, maximumEn
 		}
 
 		fetcher
-			.catch((error) => {
-				fetchFailedCallback(this, error);
-				scheduleTimer();
-			})
-			.then((response) => {
-				if (response.status !== 200) {
-					fetchFailedCallback(this, response.statusText);
-					scheduleTimer();
-				}
-				return response;
-			})
+			.then(FetcherHelper.checkStatus)
 			.then((response) => response.text())
 			.then((responseData) => {
 				let data = [];
@@ -93,6 +84,10 @@ const CalendarFetcher = function (url, reloadInterval, excludedEvents, maximumEn
 				}
 				this.broadcastEvents();
 				scheduleTimer();
+			})
+			.catch((error) => {
+				fetchFailedCallback(this, error.message);
+				scheduleTimer();
 			});
 	};
 

modules/default/newsfeed/newsfeed.js

@@ -90,7 +90,7 @@ Module.register("newsfeed", {
 			this.loaded = true;
 			this.error = null;
 		} else if (notification === "FETCH_ERROR") {
-			this.error = `Could not fetch newsfeed ${payload.url}`;
+			this.error = `${payload.error}`;
 			this.scheduleUpdateInterval();
 		} else if (notification === "INCORRECT_URL") {
 			this.error = `Incorrect url: ${payload.url}`;

modules/default/newsfeed/newsfeedfetcher.js

@@ -5,6 +5,7 @@
  * MIT Licensed.
  */
 const Log = require("logger");
+const FetcherHelper = require("fetcher_helper");
 const FeedMe = require("feedme");
 const fetch = require("node-fetch");
 const iconv = require("iconv-lite");
@@ -84,12 +85,13 @@ const NewsfeedFetcher = function (url, reloadInterval, encoding, logFeedWarnings
 		};
 
 		fetch(url, { headers: headers })
-			.catch((error) => {
-				fetchFailedCallback(this, error);
-				scheduleTimer();
+			.then(FetcherHelper.checkStatus)
+			.then((response) => {
+				response.body.pipe(iconv.decodeStream(encoding)).pipe(parser);
 			})
-			.then((res) => {
-				res.body.pipe(iconv.decodeStream(encoding)).pipe(parser);
+			.catch((error) => {
+				fetchFailedCallback(this, error.message);
+				scheduleTimer();
 			});
 	};
 

package.json

@@ -87,6 +87,7 @@
 		"socket.io": "^4.1.2"
 	},
 	"_moduleAliases": {
+		"fetcher_helper": "js/fetcher_helper.js",
 		"node_helper": "js/node_helper.js",
 		"logger": "js/logger.js"
 	},