Merge pull request #1901 from kolbyjack/fix-97e5d92-regression

Fix regression causing 'undefined' to show up when config.hideTemp is…

CHANGELOG.md

@@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 - Force declaration of public ip adress in config file (ISSUE #1852)
 - Fixes `run-start.sh`: If running in docker-container, don't check the environment, just start electron (ISSUE #1859)
 - Fix calendar time offset for recurring events crossing Daylight Savings Time (ISSUE #1798)
+- Fix regression in currentweather module causing 'undefined' to show up when config.hideTemp is false
 
 ### Updated
 - Remove documentation from core repository and link to new dedicated docs site: [docs.magicmirror.builders](https://docs.magicmirror.builders).

modules/default/currentweather/currentweather.js

@@ -195,33 +195,33 @@ Module.register("currentweather",{
 		var large = document.createElement("div");
 		large.className = "large light";
 
+		var degreeLabel = "";
+		if (this.config.units === "metric" || this.config.units === "imperial") {
+			degreeLabel += "°";
+		}
+		if(this.config.degreeLabel) {
+			switch(this.config.units) {
+			case "metric":
+				degreeLabel += "C";
+				break;
+			case "imperial":
+				degreeLabel += "F";
+				break;
+			case "default":
+				degreeLabel += "K";
+				break;
+			}
+		}
+
+		if (this.config.decimalSymbol === "") {
+			this.config.decimalSymbol = ".";
+		}
+
 		if (this.config.hideTemp === true) {
 			var weatherIcon = document.createElement("span");
 			weatherIcon.className = "wi weathericon " + this.weatherType;
 			large.appendChild(weatherIcon);
 
-			var degreeLabel = "";
-			if (this.config.units === "metric" || this.config.units === "imperial") {
-				degreeLabel += "°";
-			}
-			if(this.config.degreeLabel) {
-				switch(this.config.units) {
-				case "metric":
-					degreeLabel += "C";
-					break;
-				case "imperial":
-					degreeLabel += "F";
-					break;
-				case "default":
-					degreeLabel += "K";
-					break;
-				}
-			}
-
-			if (this.config.decimalSymbol === "") {
-				this.config.decimalSymbol = ".";
-			}
-
 			var temperature = document.createElement("span");
 			temperature.className = "bright";
 			temperature.innerHTML = " " + this.temperature.replace(".", this.config.decimalSymbol) + degreeLabel;