From b373aa62503d9a610019157c4100e5a15b4566dc Mon Sep 17 00:00:00 2001 From: veeck Date: Thu, 17 Dec 2020 18:31:18 +0100 Subject: [PATCH 1/3] Hide alert overlay when dismissed manually --- modules/default/alert/alert.js | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/default/alert/alert.js b/modules/default/alert/alert.js index b2eb2eb2..f2849cd2 100644 --- a/modules/default/alert/alert.js +++ b/modules/default/alert/alert.js @@ -100,6 +100,7 @@ Module.register("alert", { message: image + message, effect: this.config.alert_effect, ttl: params.timer, + onClose: () => this.hide_alert(sender), al_no: "ns-alert" }); //Show alert From 8cf16f1049f31a03ddcb43dbba7dddf6f9a99eda Mon Sep 17 00:00:00 2001 From: veeck Date: Thu, 17 Dec 2020 18:32:01 +0100 Subject: [PATCH 2/3] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 02453bb4..17366c9c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -45,6 +45,7 @@ _This release is scheduled to be released on 2021-01-01._ - Fix non-fullday recurring rule processing (#2216) - Catch errors when parsing calendar data with ical (#2022) - Corrected logic for timeFormat "relative" and "absolute" +- Fix Default Alert Module does not hide black overlay when alert is dismissed manually (#2228) ## [2.13.0] - 2020-10-01 From a0366e794b915250925e19d252d7a46cb25d869d Mon Sep 17 00:00:00 2001 From: Michael Teeuw Date: Mon, 21 Dec 2020 10:57:18 +0100 Subject: [PATCH 3/3] Stupid commit to check github actions. --- modules/default/alert/alert.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modules/default/alert/alert.js b/modules/default/alert/alert.js index f2849cd2..8d175b39 100644 --- a/modules/default/alert/alert.js +++ b/modules/default/alert/alert.js @@ -103,8 +103,10 @@ Module.register("alert", { onClose: () => this.hide_alert(sender), al_no: "ns-alert" }); + //Show alert this.alerts[sender.name].show(); + //Add timer to dismiss alert and overlay if (params.timer) { setTimeout(() => {