Fix API version in yr weather provider call (#3223)

Fixes #3227 

and also
- removes unused code
- de-duplicates code fragments
- fixes typos
- inlines code
- adds more weather util tests

@martingron and @Justheretoreportanissue would you be so kind to check
if I didnt mess anything up?

CHANGELOG.md

@@ -20,6 +20,7 @@ _This release is scheduled to be released on 2024-01-01._
 ### Fixed
 
 - Fix the option eventClass on customEvents.
+- Fix yr API version in locationforecast call (#3227)
 
 ## [2.25.0] - 2023-10-01
 
@@ -75,6 +76,7 @@ Special thanks to @khassel, @rejas and @sdetweil for taking over most (if not al
 - Fix `Uncaught SyntaxError: Identifier 'getCorsUrl' has already been declared (at utils.js:1:1)` when using `clock` and `weather` module (#3204)
 - Fix overriding `config.js` when running tests (#3201)
 - Fix issue in weathergov provider with probability of precipitation not showing up on hourly or daily forecast
+- Fix yr weather provider after changes in yr API (#3189)
 
 ## [2.24.0] - 2023-07-01
 
@@ -117,7 +119,6 @@ Special thanks to @khassel, @rejas and @sdetweil for taking over most (if not al
 - Fix date not shown when clock in analog mode (#3100)
 - Fix envcanada today percentage-of-precipitation (#3106)
 - Fix updatenotification where no branch is checked out but e.g. a version tag (#3130)
-- Fix yr weather provider after changes in yr API (#3189)
 
 ## [2.23.0] - 2023-04-04
 

modules/default/weather/providers/yr.js

@@ -18,6 +18,8 @@ WeatherProvider.register("yr", {
 	defaults: {
 		useCorsProxy: true,
 		apiBase: "https://api.met.no/weatherapi",
+		forecastApiVersion: "3.0",
+		sunriseApiVersion: "3.0",
 		altitude: 0,
 		currentForecastHours: 1 //1, 6 or 12
 	},
@@ -44,8 +46,7 @@ WeatherProvider.register("yr", {
 	},
 
 	async getCurrentWeather() {
-		const getRequests = [this.getWeatherData(), this.getStellarData()];
-		const [weatherData, stellarData] = await Promise.all(getRequests);
+		const [weatherData, stellarData] = await Promise.all([this.getWeatherData(), this.getStellarData()]);
 		if (!stellarData) {
 			Log.warn("No stellar data available.");
 		}
@@ -170,7 +171,7 @@ WeatherProvider.register("yr", {
 			});
 	},
 
-	getForecastUrl() {
+	getConfigOptions() {
 		if (!this.config.lat) {
 			Log.error("Latitude not provided.");
 			throw new Error("Latitude not provided.");
@@ -183,6 +184,11 @@ WeatherProvider.register("yr", {
 		let lat = this.config.lat.toString();
 		let lon = this.config.lon.toString();
 		const altitude = this.config.altitude ?? 0;
+		return { lat, lon, altitude };
+	},
+
+	getForecastUrl() {
+		let { lat, lon, altitude } = this.getConfigOptions();
 
 		if (lat.includes(".") && lat.split(".")[1].length > 4) {
 			Log.warn("Latitude is too specific for weather data. Do not use more than four decimals. Trimming to maximum length.");
@@ -195,18 +201,13 @@ WeatherProvider.register("yr", {
 			lon = `${lonParts[0]}.${lonParts[1].substring(0, 4)}`;
 		}
 
-		return `${this.config.apiBase}/locationforecast/2.0/complete?&altitude=${altitude}&lat=${lat}&lon=${lon}`;
+		return `${this.config.apiBase}/locationforecast/${this.config.forecastApiVersion}/complete?&altitude=${altitude}&lat=${lat}&lon=${lon}`;
 	},
 
 	cacheWeatherData(weatherData) {
 		localStorage.setItem("weatherData", JSON.stringify(weatherData));
 	},
 
-	getAuthenticationString() {
-		if (!this.config.authenticationEmail) throw new Error("Authentication email not provided.");
-		return `${this.config.applicaitionName} ${this.config.authenticationEmail}`;
-	},
-
 	getStellarData() {
 		// If a user has several Yr-modules, for instance one current and one forecast, the API calls must be synchronized across classes.
 		// This is to avoid multiple similar calls to the API.
@@ -302,7 +303,7 @@ WeatherProvider.register("yr", {
 
 	getStellarDataFromYr(date, days = 1) {
 		const requestHeaders = [{ name: "Accept", value: "application/json" }];
-		return this.fetchData(this.getStellarDatatUrl(date, days), "json", requestHeaders)
+		return this.fetchData(this.getStellarDataUrl(date, days), "json", requestHeaders)
 			.then((data) => {
 				Log.debug("Got stellar data from yr.");
 				return data;
@@ -313,19 +314,8 @@ WeatherProvider.register("yr", {
 			});
 	},
 
-	getStellarDatatUrl(date, days) {
-		if (!this.config.lat) {
-			Log.error("Latitude not provided.");
-			throw new Error("Latitude not provided.");
-		}
-		if (!this.config.lon) {
-			Log.error("Longitude not provided.");
-			throw new Error("Longitude not provided.");
-		}
-
-		let lat = this.config.lat.toString();
-		let lon = this.config.lon.toString();
-		const altitude = this.config.altitude ?? 0;
+	getStellarDataUrl(date, days) {
+		let { lat, lon, altitude } = this.getConfigOptions();
 
 		if (lat.includes(".") && lat.split(".")[1].length > 4) {
 			Log.warn("Latitude is too specific for stellar data. Do not use more than four decimals. Trimming to maximum length.");
@@ -352,7 +342,7 @@ WeatherProvider.register("yr", {
 		if (hours.length < 2) {
 			hours = `0${hours}`;
 		}
-		return `${this.config.apiBase}/sunrise/2.3/sun?lat=${lat}&lon=${lon}&date=${date}&offset=${utcOffsetPrefix}${hours}%3A${minutes}`;
+		return `${this.config.apiBase}/sunrise/${this.config.sunriseApiVersion}/sun?lat=${lat}&lon=${lon}&date=${date}&offset=${utcOffsetPrefix}${hours}%3A${minutes}`;
 	},
 
 	cacheStellarData(data) {
@@ -472,15 +462,6 @@ WeatherProvider.register("yr", {
 		return weatherTypes.hasOwnProperty(weatherType) ? weatherTypes[weatherType] : null;
 	},
 
-	getStellarTimesFrom(stellarData, date) {
-		for (const time of stellarData.location.time) {
-			if (time.date === date) {
-				return time;
-			}
-		}
-		return undefined;
-	},
-
 	getForecastForXHoursFrom(weather) {
 		if (this.config.currentForecastHours === 1) {
 			if (weather.next_1_hours) {
@@ -522,8 +503,7 @@ WeatherProvider.register("yr", {
 	},
 
 	async getWeatherForecast(type) {
-		const getRequests = [this.getWeatherData(), this.getStellarData()];
-		const [weatherData, stellarData] = await Promise.all(getRequests);
+		const [weatherData, stellarData] = await Promise.all([this.getWeatherData(), this.getStellarData()]);
 		if (!weatherData.properties.timeseries || !weatherData.properties.timeseries[0]) {
 			Log.error("No weather data available.");
 			return;
@@ -573,7 +553,7 @@ WeatherProvider.register("yr", {
 			return days;
 		}, Object.create(null));
 
-		Object.keys(days).forEach(function (time, index) {
+		Object.keys(days).forEach(function (time) {
 			let minTemperature = undefined;
 			let maxTemperature = undefined;
 

package-lock.json

@@ -13,7 +13,7 @@
 				"colors": "^1.4.0",
 				"console-stamp": "^3.1.2",
 				"envsub": "^4.1.0",
-				"eslint": "^8.50.0",
+				"eslint": "^8.51.0",
 				"express": "^4.18.2",
 				"express-ipfilter": "^1.3.1",
 				"feedme": "^2.0.2",
@@ -31,16 +31,16 @@
 				"eslint-plugin-import": "^2.28.1",
 				"eslint-plugin-jest": "^27.4.2",
 				"eslint-plugin-jsdoc": "^46.8.2",
-				"eslint-plugin-prettier": "^5.0.0",
+				"eslint-plugin-prettier": "^5.0.1",
 				"express-basic-auth": "^1.2.1",
 				"husky": "^8.0.3",
 				"jest": "^29.7.0",
 				"jsdom": "^22.1.0",
 				"lint-staged": "^14.0.1",
 				"lodash": "^4.17.21",
-				"playwright": "^1.38.1",
+				"playwright": "^1.39.0",
 				"prettier": "^3.0.3",
-				"sinon": "^16.0.0",
+				"sinon": "^16.1.0",
 				"stylelint": "^15.10.3",
 				"stylelint-config-standard": "^34.0.0",
 				"stylelint-prettier": "^4.0.2",
@@ -50,7 +50,7 @@
 				"node": ">=18"
 			},
 			"optionalDependencies": {
-				"electron": "^26.2.4"
+				"electron": "^26.4.0"
 			}
 		},
 		"node_modules/@aashutoshrathi/word-wrap": {
@@ -159,18 +159,18 @@
 			}
 		},
 		"node_modules/@babel/compat-data": {
-			"version": "7.22.20",
-			"resolved": "https://registry.npmjs.org/@babel/compat-data/-/compat-data-7.22.20.tgz",
-			"integrity": "sha512-BQYjKbpXjoXwFW5jGqiizJQQT/aC7pFm9Ok1OWssonuguICi264lbgMzRp2ZMmRSlfkX6DsWDDcsrctK8Rwfiw==",
+			"version": "7.23.2",
+			"resolved": "https://registry.npmjs.org/@babel/compat-data/-/compat-data-7.23.2.tgz",
+			"integrity": "sha512-0S9TQMmDHlqAZ2ITT95irXKfxN9bncq8ZCoJhun3nHL/lLUxd2NKBJYoNGWH7S0hz6fRQwWlAWn/ILM0C70KZQ==",
 			"dev": true,
 			"engines": {
 				"node": ">=6.9.0"
 			}
 		},
 		"node_modules/@babel/core": {
-			"version": "7.23.0",
-			"resolved": "https://registry.npmjs.org/@babel/core/-/core-7.23.0.tgz",
-			"integrity": "sha512-97z/ju/Jy1rZmDxybphrBuI+jtJjFVoz7Mr9yUQVVVi+DNZE333uFQeMOqcCIy1x3WYBIbWftUSLmbNXNT7qFQ==",
+			"version": "7.23.2",
+			"resolved": "https://registry.npmjs.org/@babel/core/-/core-7.23.2.tgz",
+			"integrity": "sha512-n7s51eWdaWZ3vGT2tD4T7J6eJs3QoBXydv7vkUM06Bf1cbVD2Kc2UrkzhiQwobfV7NwOnQXYL7UBJ5VPU+RGoQ==",
 			"dev": true,
 			"dependencies": {
 				"@ampproject/remapping": "^2.2.0",
@@ -178,10 +178,10 @@
 				"@babel/generator": "^7.23.0",
 				"@babel/helper-compilation-targets": "^7.22.15",
 				"@babel/helper-module-transforms": "^7.23.0",
-				"@babel/helpers": "^7.23.0",
+				"@babel/helpers": "^7.23.2",
 				"@babel/parser": "^7.23.0",
 				"@babel/template": "^7.22.15",
-				"@babel/traverse": "^7.23.0",
+				"@babel/traverse": "^7.23.2",
 				"@babel/types": "^7.23.0",
 				"convert-source-map": "^2.0.0",
 				"debug": "^4.1.0",
@@ -354,13 +354,13 @@
 			}
 		},
 		"node_modules/@babel/helpers": {
-			"version": "7.23.1",
-			"resolved": "https://registry.npmjs.org/@babel/helpers/-/helpers-7.23.1.tgz",
-			"integrity": "sha512-chNpneuK18yW5Oxsr+t553UZzzAs3aZnFm4bxhebsNTeshrC95yA7l5yl7GBAG+JG1rF0F7zzD2EixK9mWSDoA==",
+			"version": "7.23.2",
+			"resolved": "https://registry.npmjs.org/@babel/helpers/-/helpers-7.23.2.tgz",
+			"integrity": "sha512-lzchcp8SjTSVe/fPmLwtWVBFC7+Tbn8LGHDVfDp9JGxpAY5opSaEFgt8UQvrnECWOTdji2mOWMz1rOhkHscmGQ==",
 			"dev": true,
 			"dependencies": {
 				"@babel/template": "^7.22.15",
-				"@babel/traverse": "^7.23.0",
+				"@babel/traverse": "^7.23.2",
 				"@babel/types": "^7.23.0"
 			},
 			"engines": {
@@ -656,9 +656,9 @@
 			}
 		},
 		"node_modules/@babel/traverse": {
-			"version": "7.23.0",
-			"resolved": "https://registry.npmjs.org/@babel/traverse/-/traverse-7.23.0.tgz",
-			"integrity": "sha512-t/QaEvyIoIkwzpiZ7aoSKK8kObQYeF7T2v+dazAYCb8SXtp58zEVkWW7zAnju8FNKNdr4ScAOEDmMItbyOmEYw==",
+			"version": "7.23.2",
+			"resolved": "https://registry.npmjs.org/@babel/traverse/-/traverse-7.23.2.tgz",
+			"integrity": "sha512-azpe59SQ48qG6nu2CzcMLbxUudtN+dOM9kDbUqGq3HXUJRlo7i8fvPoxQUzYgLZ4cMVmuZgm8vvBpNeRhd6XSw==",
 			"dev": true,
 			"dependencies": {
 				"@babel/code-frame": "^7.22.13",
@@ -841,9 +841,9 @@
 			}
 		},
 		"node_modules/@eslint-community/regexpp": {
-			"version": "4.9.0",
-			"resolved": "https://registry.npmjs.org/@eslint-community/regexpp/-/regexpp-4.9.0.tgz",
-			"integrity": "sha512-zJmuCWj2VLBt4c25CfBIbMZLGLyhkvs7LznyVX5HfpzeocThgIj5XQK4L+g3U36mMcx8bPMhGyPpwCATamC4jQ==",
+			"version": "4.9.1",
+			"resolved": "https://registry.npmjs.org/@eslint-community/regexpp/-/regexpp-4.9.1.tgz",
+			"integrity": "sha512-Y27x+MBLjXa+0JWDhykM3+JE+il3kHKAEqabfEWq3SDhZjLYb6/BHL/JKFnH3fe207JaXkyDo685Oc2Glt6ifA==",
 			"engines": {
 				"node": "^12.0.0 || ^14.0.0 || >=16.0.0"
 			}
@@ -871,9 +871,9 @@
 			}
 		},
 		"node_modules/@eslint/js": {
-			"version": "8.50.0",
-			"resolved": "https://registry.npmjs.org/@eslint/js/-/js-8.50.0.tgz",
-			"integrity": "sha512-NCC3zz2+nvYd+Ckfh87rA47zfu2QsQpvc6k1yzTk+b9KzRj0wkGa8LSoGOXN6Zv4lRf/EIoZ80biDh9HOI+RNQ==",
+			"version": "8.51.0",
+			"resolved": "https://registry.npmjs.org/@eslint/js/-/js-8.51.0.tgz",
+			"integrity": "sha512-HxjQ8Qn+4SI3/AFv6sOrDB+g6PpUTDwSJiQqOrnneEk8L71161srI9gjzzZvYVbzHiVg/BvcH95+cK/zfIt4pg==",
 			"engines": {
 				"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
 			}
@@ -1639,9 +1639,9 @@
 			"dev": true
 		},
 		"node_modules/@types/node": {
-			"version": "18.18.1",
-			"resolved": "https://registry.npmjs.org/@types/node/-/node-18.18.1.tgz",
-			"integrity": "sha512-3G42sxmm0fF2+Vtb9TJQpnjmP+uKlWvFa8KoEGquh4gqRmoUG/N0ufuhikw6HEsdG2G2oIKhog1GCTfz9v5NdQ=="
+			"version": "18.18.4",
+			"resolved": "https://registry.npmjs.org/@types/node/-/node-18.18.4.tgz",
+			"integrity": "sha512-t3rNFBgJRugIhackit2mVcLfF6IRc0JE4oeizPQL8Zrm8n2WY/0wOdpOPhdtG0V9Q2TlW/axbF1MJ6z+Yj/kKQ=="
 		},
 		"node_modules/@types/normalize-package-data": {
 			"version": "2.4.2",
@@ -1671,9 +1671,9 @@
 			"dev": true
 		},
 		"node_modules/@types/yargs": {
-			"version": "17.0.26",
-			"resolved": "https://registry.npmjs.org/@types/yargs/-/yargs-17.0.26.tgz",
-			"integrity": "sha512-Y3vDy2X6zw/ZCumcwLpdhM5L7jmyGpmBCTYMHDLqT2IKVMYRRLdv6ZakA+wxhra6Z/3bwhNbNl9bDGXaFU+6rw==",
+			"version": "17.0.28",
+			"resolved": "https://registry.npmjs.org/@types/yargs/-/yargs-17.0.28.tgz",
+			"integrity": "sha512-N3e3fkS86hNhtk6BEnc0rj3zcehaxx8QWhCROJkqpl5Zaoi7nAic3jH8q94jVD3zu5LGk+PUB6KAiDmimYOEQw==",
 			"dev": true,
 			"dependencies": {
 				"@types/yargs-parser": "*"
@@ -2614,9 +2614,9 @@
 			}
 		},
 		"node_modules/caniuse-lite": {
-			"version": "1.0.30001541",
-			"resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001541.tgz",
-			"integrity": "sha512-bLOsqxDgTqUBkzxbNlSBt8annkDpQB9NdzdTbO2ooJ+eC/IQcvDspDc058g84ejCelF7vHUx57KIOjEecOHXaw==",
+			"version": "1.0.30001547",
+			"resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001547.tgz",
+			"integrity": "sha512-W7CrtIModMAxobGhz8iXmDfuJiiKg1WADMO/9x7/CLNin5cpSbuBjooyoIUVB5eyCc36QuTVlkVa1iB2S5+/eA==",
 			"dev": true,
 			"funding": [
 				{
@@ -2658,9 +2658,9 @@
 			}
 		},
 		"node_modules/ci-info": {
-			"version": "3.8.0",
-			"resolved": "https://registry.npmjs.org/ci-info/-/ci-info-3.8.0.tgz",
-			"integrity": "sha512-eXTggHWSooYhq49F2opQhuHWgzucfF2YgODK4e1566GQs5BIfP30B0oenwBJHfWxAs2fyPB1s7Mg949zLf61Yw==",
+			"version": "3.9.0",
+			"resolved": "https://registry.npmjs.org/ci-info/-/ci-info-3.9.0.tgz",
+			"integrity": "sha512-NIxF55hv4nSqQswkAeiOi1r83xy8JldOFDTWiug55KBu9Jnblncd2U6ViHmYgHf01TPZS77NJBhBMKdWj9HQMQ==",
 			"dev": true,
 			"funding": [
 				{
@@ -3549,9 +3549,9 @@
 			"integrity": "sha512-WMwm9LhRUo+WUaRN+vRuETqG89IgZphVSNkdFgeb6sS/E4OrDIN7t48CAewSHXc6C8lefD8KKfr5vY61brQlow=="
 		},
 		"node_modules/electron": {
-			"version": "26.2.4",
-			"resolved": "https://registry.npmjs.org/electron/-/electron-26.2.4.tgz",
-			"integrity": "sha512-weMUSMyDho5E0DPQ3breba3D96IxwNvtYHjMd/4/wNN3BdI5s3+0orNnPVGJFcLhSvKoxuKUqdVonUocBPwlQA==",
+			"version": "26.4.0",
+			"resolved": "https://registry.npmjs.org/electron/-/electron-26.4.0.tgz",
+			"integrity": "sha512-FUEFwmIlflLxImRtTmDp8CWpH4KqlyAwga6vauaz6+882SmyC3bJRhgqOIT5s6rMbW25WezNiaqfKqHDJjz3pw==",
 			"hasInstallScript": true,
 			"optional": true,
 			"dependencies": {
@@ -3567,9 +3567,9 @@
 			}
 		},
 		"node_modules/electron-to-chromium": {
-			"version": "1.4.537",
-			"resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.4.537.tgz",
-			"integrity": "sha512-W1+g9qs9hviII0HAwOdehGYkr+zt7KKdmCcJcjH0mYg6oL8+ioT3Skjmt7BLoAQqXhjf40AXd+HlR4oAWMlXjA==",
+			"version": "1.4.551",
+			"resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.4.551.tgz",
+			"integrity": "sha512-/Ng/W/kFv7wdEHYzxdK7Cv0BHEGSkSB3M0Ssl8Ndr1eMiYeas/+Mv4cNaDqamqWx6nd2uQZfPz6g25z25M/sdw==",
 			"dev": true
 		},
 		"node_modules/emittery": {
@@ -3608,9 +3608,9 @@
 			}
 		},
 		"node_modules/engine.io": {
-			"version": "6.5.2",
-			"resolved": "https://registry.npmjs.org/engine.io/-/engine.io-6.5.2.tgz",
-			"integrity": "sha512-IXsMcGpw/xRfjra46sVZVHiSWo/nJ/3g1337q9KNXtS6YRzbW5yIzTCb9DjhrBe7r3GZQR0I4+nq+4ODk5g/cA==",
+			"version": "6.5.3",
+			"resolved": "https://registry.npmjs.org/engine.io/-/engine.io-6.5.3.tgz",
+			"integrity": "sha512-IML/R4eG/pUS5w7OfcDE0jKrljWS9nwnEfsxWCIJF5eO6AHo6+Hlv+lQbdlAYsiJPHzUthLm1RUjnBzWOs45cw==",
 			"dependencies": {
 				"@types/cookie": "^0.4.1",
 				"@types/cors": "^2.8.12",
@@ -3845,14 +3845,14 @@
 			}
 		},
 		"node_modules/eslint": {
-			"version": "8.50.0",
-			"resolved": "https://registry.npmjs.org/eslint/-/eslint-8.50.0.tgz",
-			"integrity": "sha512-FOnOGSuFuFLv/Sa+FDVRZl4GGVAAFFi8LecRsI5a1tMO5HIE8nCm4ivAlzt4dT3ol/PaaGC0rJEEXQmHJBGoOg==",
+			"version": "8.51.0",
+			"resolved": "https://registry.npmjs.org/eslint/-/eslint-8.51.0.tgz",
+			"integrity": "sha512-2WuxRZBrlwnXi+/vFSJyjMqrNjtJqiasMzehF0shoLaW7DzS3/9Yvrmq5JiT66+pNjiX4UBnLDiKHcWAr/OInA==",
 			"dependencies": {
 				"@eslint-community/eslint-utils": "^4.2.0",
 				"@eslint-community/regexpp": "^4.6.1",
 				"@eslint/eslintrc": "^2.1.2",
-				"@eslint/js": "8.50.0",
+				"@eslint/js": "8.51.0",
 				"@humanwhocodes/config-array": "^0.11.11",
 				"@humanwhocodes/module-importer": "^1.0.1",
 				"@nodelib/fs.walk": "^1.2.8",
@@ -4089,9 +4089,9 @@
 			"dev": true
 		},
 		"node_modules/eslint-plugin-prettier": {
-			"version": "5.0.0",
-			"resolved": "https://registry.npmjs.org/eslint-plugin-prettier/-/eslint-plugin-prettier-5.0.0.tgz",
-			"integrity": "sha512-AgaZCVuYDXHUGxj/ZGu1u8H8CYgDY3iG6w5kUFw4AzMVXzB7VvbKgYR4nATIN+OvUrghMbiDLeimVjVY5ilq3w==",
+			"version": "5.0.1",
+			"resolved": "https://registry.npmjs.org/eslint-plugin-prettier/-/eslint-plugin-prettier-5.0.1.tgz",
+			"integrity": "sha512-m3u5RnR56asrwV/lDC4GHorlW75DsFfmUcjfCYylTUs85dBRnB7VM6xG8eCMJdeDRnppzmxZVf1GEPJvl1JmNg==",
 			"dev": true,
 			"dependencies": {
 				"prettier-linter-helpers": "^1.0.0",
@@ -4546,11 +4546,11 @@
 			}
 		},
 		"node_modules/flat-cache": {
-			"version": "3.1.0",
-			"resolved": "https://registry.npmjs.org/flat-cache/-/flat-cache-3.1.0.tgz",
-			"integrity": "sha512-OHx4Qwrrt0E4jEIcI5/Xb+f+QmJYNj2rrK8wiIdQOIrB9WrrJL8cjZvXdXuBTkkEwEqLycb5BeZDV1o2i9bTew==",
+			"version": "3.1.1",
+			"resolved": "https://registry.npmjs.org/flat-cache/-/flat-cache-3.1.1.tgz",
+			"integrity": "sha512-/qM2b3LUIaIgviBQovTLvijfyOQXPtSRnRK26ksj2J7rzPIecePUIpJsZ4T02Qg+xiAEKIs5K8dsHEd+VaKa/Q==",
 			"dependencies": {
-				"flatted": "^3.2.7",
+				"flatted": "^3.2.9",
 				"keyv": "^4.5.3",
 				"rimraf": "^3.0.2"
 			},
@@ -4872,9 +4872,9 @@
 			}
 		},
 		"node_modules/globals": {
-			"version": "13.22.0",
-			"resolved": "https://registry.npmjs.org/globals/-/globals-13.22.0.tgz",
-			"integrity": "sha512-H1Ddc/PbZHTDVJSnj8kWptIRSD6AM3pK+mKytuIVF4uoBV7rshFlhhvA58ceJ5wp3Er58w6zj7bykMpYXt3ETw==",
+			"version": "13.23.0",
+			"resolved": "https://registry.npmjs.org/globals/-/globals-13.23.0.tgz",
+			"integrity": "sha512-XAmF0RjlrjY23MA51q3HltdlGxUpXPvg0GioKiD9X6HD28iMjo2dKC8Vqwm7lne4GNr78+RHTfliktR6ZH09wA==",
 			"dependencies": {
 				"type-fest": "^0.20.2"
 			},
@@ -5002,12 +5002,9 @@
 			}
 		},
 		"node_modules/has": {
-			"version": "1.0.3",
-			"resolved": "https://registry.npmjs.org/has/-/has-1.0.3.tgz",
-			"integrity": "sha512-f2dvO0VU6Oej7RkWJGrehjbzMAjFp5/VKPp5tTpWIV4JHHZK1/BxbFRtf/siA2SWTe09caDmVtYYzWEIbBS4zw==",
-			"dependencies": {
-				"function-bind": "^1.1.1"
-			},
+			"version": "1.0.4",
+			"resolved": "https://registry.npmjs.org/has/-/has-1.0.4.tgz",
+			"integrity": "sha512-qdSAmqLF6209RFj4VVItywPMbm3vWylknmB3nvNiUIs72xAimcM8nVYxYr7ncvZq5qzk9MKIZR8ijqD/1QuYjQ==",
 			"engines": {
 				"node": ">= 0.4.0"
 			}
@@ -5771,9 +5768,9 @@
 			}
 		},
 		"node_modules/istanbul-lib-instrument": {
-			"version": "6.0.0",
-			"resolved": "https://registry.npmjs.org/istanbul-lib-instrument/-/istanbul-lib-instrument-6.0.0.tgz",
-			"integrity": "sha512-x58orMzEVfzPUKqlbLd1hXCnySCxKdDKa6Rjg97CwuLLRI4g3FHTdnExu1OqffVFay6zeMW+T6/DowFLndWnIw==",
+			"version": "6.0.1",
+			"resolved": "https://registry.npmjs.org/istanbul-lib-instrument/-/istanbul-lib-instrument-6.0.1.tgz",
+			"integrity": "sha512-EAMEJBsYuyyztxMxW3g7ugGPkrZsV57v0Hmv3mm1uQsmB+QnZuepg731CRaIgeUVSdmsTngOkSnauNF8p7FIhA==",
 			"dev": true,
 			"dependencies": {
 				"@babel/core": "^7.12.3",
@@ -6583,9 +6580,9 @@
 			"dev": true
 		},
 		"node_modules/keyv": {
-			"version": "4.5.3",
-			"resolved": "https://registry.npmjs.org/keyv/-/keyv-4.5.3.tgz",
-			"integrity": "sha512-QCiSav9WaX1PgETJ+SpNnx2PRRapJ/oRSXM4VO5OGYGSjrxbKPVFVhB3l2OCbLCk329N8qyAtsJjSjvVBWzEug==",
+			"version": "4.5.4",
+			"resolved": "https://registry.npmjs.org/keyv/-/keyv-4.5.4.tgz",
+			"integrity": "sha512-oxVHkHR/EJf2CNXnWxRLW6mg7JyCCUcG0DtEGmL2ctUo1PNTin1PUil+r/+4r5MpVgC/fn1kjsx7mjSujKqIpw==",
 			"dependencies": {
 				"json-buffer": "3.0.1"
 			}
@@ -7898,12 +7895,12 @@
 			}
 		},
 		"node_modules/playwright": {
-			"version": "1.38.1",
-			"resolved": "https://registry.npmjs.org/playwright/-/playwright-1.38.1.tgz",
-			"integrity": "sha512-oRMSJmZrOu1FP5iu3UrCx8JEFRIMxLDM0c/3o4bpzU5Tz97BypefWf7TuTNPWeCe279TPal5RtPPZ+9lW/Qkow==",
+			"version": "1.39.0",
+			"resolved": "https://registry.npmjs.org/playwright/-/playwright-1.39.0.tgz",
+			"integrity": "sha512-naE5QT11uC/Oiq0BwZ50gDmy8c8WLPRTEWuSSFVG2egBka/1qMoSqYQcROMT9zLwJ86oPofcTH2jBY/5wWOgIw==",
 			"dev": true,
 			"dependencies": {
-				"playwright-core": "1.38.1"
+				"playwright-core": "1.39.0"
 			},
 			"bin": {
 				"playwright": "cli.js"
@@ -7916,9 +7913,9 @@
 			}
 		},
 		"node_modules/playwright-core": {
-			"version": "1.38.1",
-			"resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.38.1.tgz",
-			"integrity": "sha512-tQqNFUKa3OfMf4b2jQ7aGLB8o9bS3bOY0yMEtldtC2+spf8QXG9zvXLTXUeRsoNuxEYMgLYR+NXfAa1rjKRcrg==",
+			"version": "1.39.0",
+			"resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.39.0.tgz",
+			"integrity": "sha512-+k4pdZgs1qiM+OUkSjx96YiKsXsmb59evFoqv8SKO067qBA+Z2s/dCzJij/ZhdQcs2zlTAgRKfeiiLm8PQ2qvw==",
 			"dev": true,
 			"bin": {
 				"playwright-core": "cli.js"
@@ -8376,9 +8373,9 @@
 			"dev": true
 		},
 		"node_modules/resolve": {
-			"version": "1.22.6",
-			"resolved": "https://registry.npmjs.org/resolve/-/resolve-1.22.6.tgz",
-			"integrity": "sha512-njhxM7mV12JfufShqGy3Rz8j11RPdLy4xi15UurGJeoHLfJpVXKdh3ueuOqbYUcDZnffr6X739JBo5LzyahEsw==",
+			"version": "1.22.8",
+			"resolved": "https://registry.npmjs.org/resolve/-/resolve-1.22.8.tgz",
+			"integrity": "sha512-oKWePCxqpd6FlLvGV1VU0x7bkPmmCNolxzjMf4NczoDnQcIWrAF+cPtZn5i6n+RfD2d9i0tzpKnG6Yk168yIyw==",
 			"dev": true,
 			"dependencies": {
 				"is-core-module": "^2.13.0",
@@ -8800,9 +8797,9 @@
 			"dev": true
 		},
 		"node_modules/sinon": {
-			"version": "16.0.0",
-			"resolved": "https://registry.npmjs.org/sinon/-/sinon-16.0.0.tgz",
-			"integrity": "sha512-B8AaZZm9CT5pqe4l4uWJztfD/mOTa7dL8Qo0W4+s+t74xECOgSZDDQCBjNgIK3+n4kyxQrSTv2V5ul8K25qkiQ==",
+			"version": "16.1.0",
+			"resolved": "https://registry.npmjs.org/sinon/-/sinon-16.1.0.tgz",
+			"integrity": "sha512-ZSgzF0vwmoa8pq0GEynqfdnpEDyP1PkYmEChnkjW0Vyh8IDlyFEJ+fkMhCP0il6d5cJjPl2PUsnUSAuP5sttOQ==",
 			"dev": true,
 			"dependencies": {
 				"@sinonjs/commons": "^3.0.0",
@@ -8980,9 +8977,9 @@
 			}
 		},
 		"node_modules/spdx-license-ids": {
-			"version": "3.0.15",
-			"resolved": "https://registry.npmjs.org/spdx-license-ids/-/spdx-license-ids-3.0.15.tgz",
-			"integrity": "sha512-lpT8hSQp9jAKp9mhtBU4Xjon8LPGBvLIuBiSVhMEtmLecTh2mO0tlqrAMp47tBXzMr13NJMQ2lf7RpQGLJ3HsQ==",
+			"version": "3.0.16",
+			"resolved": "https://registry.npmjs.org/spdx-license-ids/-/spdx-license-ids-3.0.16.tgz",
+			"integrity": "sha512-eWN+LnM3GR6gPu35WxNgbGl8rmY1AEmoMDvL/QD6zYmPWgywxWqJWNdLGT+ke8dKNWrcYgYjPpG5gbTfghP8rw==",
 			"dev": true
 		},
 		"node_modules/sprintf-js": {
@@ -9962,25 +9959,19 @@
 			}
 		},
 		"node_modules/v8-to-istanbul": {
-			"version": "9.1.0",
-			"resolved": "https://registry.npmjs.org/v8-to-istanbul/-/v8-to-istanbul-9.1.0.tgz",
-			"integrity": "sha512-6z3GW9x8G1gd+JIIgQQQxXuiJtCXeAjp6RaPEPLv62mH3iPHPxV6W3robxtCzNErRo6ZwTmzWhsbNvjyEBKzKA==",
+			"version": "9.1.3",
+			"resolved": "https://registry.npmjs.org/v8-to-istanbul/-/v8-to-istanbul-9.1.3.tgz",
+			"integrity": "sha512-9lDD+EVI2fjFsMWXc6dy5JJzBsVTcQ2fVkfBvncZ6xJWG9wtBhOldG+mHkSL0+V1K/xgZz0JDO5UT5hFwHUghg==",
 			"dev": true,
 			"dependencies": {
 				"@jridgewell/trace-mapping": "^0.3.12",
 				"@types/istanbul-lib-coverage": "^2.0.1",
-				"convert-source-map": "^1.6.0"
+				"convert-source-map": "^2.0.0"
 			},
 			"engines": {
 				"node": ">=10.12.0"
 			}
 		},
-		"node_modules/v8-to-istanbul/node_modules/convert-source-map": {
-			"version": "1.9.0",
-			"resolved": "https://registry.npmjs.org/convert-source-map/-/convert-source-map-1.9.0.tgz",
-			"integrity": "sha512-ASFBup0Mz1uyiIjANan1jzLQami9z1PoYSZCiiYW2FczPbenXc45FZdBZLzOT+r6+iciuEModtmCti+hjaAk0A==",
-			"dev": true
-		},
 		"node_modules/validate-npm-package-license": {
 			"version": "3.0.4",
 			"resolved": "https://registry.npmjs.org/validate-npm-package-license/-/validate-npm-package-license-3.0.4.tgz",

package.json

@@ -53,29 +53,29 @@
 		"eslint-plugin-import": "^2.28.1",
 		"eslint-plugin-jest": "^27.4.2",
 		"eslint-plugin-jsdoc": "^46.8.2",
-		"eslint-plugin-prettier": "^5.0.0",
+		"eslint-plugin-prettier": "^5.0.1",
 		"express-basic-auth": "^1.2.1",
 		"husky": "^8.0.3",
 		"jest": "^29.7.0",
 		"jsdom": "^22.1.0",
 		"lint-staged": "^14.0.1",
 		"lodash": "^4.17.21",
-		"playwright": "^1.38.1",
+		"playwright": "^1.39.0",
 		"prettier": "^3.0.3",
-		"sinon": "^16.0.0",
+		"sinon": "^16.1.0",
 		"stylelint": "^15.10.3",
 		"stylelint-config-standard": "^34.0.0",
 		"stylelint-prettier": "^4.0.2",
 		"suncalc": "^1.9.0"
 	},
 	"optionalDependencies": {
-		"electron": "^26.2.4"
+		"electron": "^26.4.0"
 	},
 	"dependencies": {
 		"colors": "^1.4.0",
 		"console-stamp": "^3.1.2",
 		"envsub": "^4.1.0",
-		"eslint": "^8.50.0",
+		"eslint": "^8.51.0",
 		"express": "^4.18.2",
 		"express-ipfilter": "^1.3.1",
 		"feedme": "^2.0.2",

tests/unit/modules/default/weather/weather_utils_spec.js

@@ -2,6 +2,12 @@ const weather = require("../../../../../modules/default/weather/weatherutils");
 const WeatherUtils = require("../../../../../modules/default/weather/weatherutils");
 
 describe("Weather utils tests", () => {
+	describe("windspeed conversion", () => {
+		it("should convert temp correctly from Celsius to Fahrenheit", () => {
+			expect(Math.round(WeatherUtils.convertTemp(10, "imperial"))).toBe(50);
+		});
+	});
+
 	describe("windspeed conversion", () => {
 		it("should convert windspeed correctly from mps to beaufort", () => {
 			expect(Math.round(WeatherUtils.convertWind(5, "beaufort"))).toBe(3);
@@ -32,6 +38,7 @@ describe("Weather utils tests", () => {
 	describe("wind direction conversion", () => {
 		it("should convert wind direction correctly from cardinal to value", () => {
 			expect(WeatherUtils.convertWindDirection("SSE")).toBe(157);
+			expect(WeatherUtils.convertWindDirection("XXX")).toBe(null);
 		});
 	});