diff --git a/CHANGELOG.md b/CHANGELOG.md index d8e76fc9..de0802f4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). ### Fixed - Fix instruction in README for using automatically installer script. +- Bug of duplicated compliments as described in [here](https://forum.magicmirror.builders/topic/2381/compliments-module-stops-cycling-compliments). - Fix double message about port when server is starting ## [2.1.1] - 2017-04-01 diff --git a/modules/default/compliments/compliments.js b/modules/default/compliments/compliments.js index b9f2011e..a0af458d 100644 --- a/modules/default/compliments/compliments.js +++ b/modules/default/compliments/compliments.js @@ -96,14 +96,14 @@ Module.register("compliments", { */ complimentArray: function() { var hour = moment().hour(); - var compliments = null; + var compliments; - if (hour >= 3 && hour < 12) { - compliments = this.config.compliments.morning; - } else if (hour >= 12 && hour < 17) { - compliments = this.config.compliments.afternoon; - } else { - compliments = this.config.compliments.evening; + if (hour >= 3 && hour < 12 && this.config.compliments.hasOwnProperty("morning")) { + compliments = this.config.compliments.morning.slice(0); + } else if (hour >= 12 && hour < 17 && this.config.compliments.hasOwnProperty("afternoon")) { + compliments = this.config.compliments.afternoon.slice(0); + } else if(this.config.compliments.hasOwnProperty("evening")) { + compliments = this.config.compliments.evening.slice(0); } if (typeof compliments === "undefined") { @@ -117,7 +117,6 @@ Module.register("compliments", { compliments.push.apply(compliments, this.config.compliments.anytime); return compliments; - }, /* complimentFile(callback)