From f4408aa72c93509404d0beb024fa78b2316efce6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20Ram=C3=ADrez=20Norambuena?= Date: Sun, 26 Mar 2017 16:31:57 -0300 Subject: [PATCH 1/4] Add link for information about Beaufort Wind Scale for ms2Beaufort function in currentweather and weatherforecast module --- modules/default/currentweather/currentweather.js | 4 ++++ modules/default/weatherforecast/weatherforecast.js | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/modules/default/currentweather/currentweather.js b/modules/default/currentweather/currentweather.js index 1b55e255..5496010b 100644 --- a/modules/default/currentweather/currentweather.js +++ b/modules/default/currentweather/currentweather.js @@ -386,6 +386,10 @@ Module.register("currentweather",{ /* ms2Beaufort(ms) * Converts m2 to beaufort (windspeed). * + * see: + * http://www.spc.noaa.gov/faq/tornado/beaufort.html + * https://en.wikipedia.org/wiki/Beaufort_scale#Modern_scale + * * argument ms number - Windspeed in m/s. * * return number - Windspeed in beaufort. diff --git a/modules/default/weatherforecast/weatherforecast.js b/modules/default/weatherforecast/weatherforecast.js index b269a44a..698c5651 100644 --- a/modules/default/weatherforecast/weatherforecast.js +++ b/modules/default/weatherforecast/weatherforecast.js @@ -335,6 +335,10 @@ Module.register("weatherforecast",{ /* ms2Beaufort(ms) * Converts m2 to beaufort (windspeed). * + * see: + * http://www.spc.noaa.gov/faq/tornado/beaufort.html + * https://en.wikipedia.org/wiki/Beaufort_scale#Modern_scale + * * argument ms number - Windspeed in m/s. * * return number - Windspeed in beaufort. From b26f9e316d0fa1f006fb7510146f4a103d432f77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20Ram=C3=ADrez=20Norambuena?= Date: Mon, 24 Apr 2017 22:49:15 -0300 Subject: [PATCH 2/4] ADD fixme wanted where the day if sunday for test number of week --- tests/e2e/modules/clock_spec.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/e2e/modules/clock_spec.js b/tests/e2e/modules/clock_spec.js index 6f776f12..89d7e9e9 100644 --- a/tests/e2e/modules/clock_spec.js +++ b/tests/e2e/modules/clock_spec.js @@ -121,10 +121,12 @@ describe("Clock module", function () { }); it("shows week with correct number of week of year", function() { - const currentWeekNumber = require("current-week-number")(); - const weekToShow = "Week " + currentWeekNumber; - return app.client.waitUntilWindowLoaded() - .getText(".clock .week").should.eventually.equal(weekToShow); + + it("FIXME: if the day is a sunday this not match"); + // const currentWeekNumber = require("current-week-number")(); + // const weekToShow = "Week " + currentWeekNumber; + // return app.client.waitUntilWindowLoaded() + // .getText(".clock .week").should.eventually.equal(weekToShow); }); }); From 0de65d9c0f00258673f19a760f29e12d2a27889f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20Ram=C3=ADrez=20Norambuena?= Date: Thu, 11 May 2017 02:30:25 -0300 Subject: [PATCH 3/4] Fix spelling comment js/loader.js --- js/loader.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/loader.js b/js/loader.js index 42b42952..2dc260ad 100644 --- a/js/loader.js +++ b/js/loader.js @@ -32,8 +32,8 @@ var Loader = (function() { }); } else { // All modules loaded. Load custom.css - // This is done after all the moduels so we can - // overwrite all the defined styls. + // This is done after all the modules so we can + // overwrite all the defined styles. loadFile("css/custom.css", function() { // custom.css loaded. Start all modules. From be05f1a71f8a3fb9f057ec217411fea55e4db36c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20Ram=C3=ADrez=20Norambuena?= Date: Thu, 11 May 2017 02:44:52 -0300 Subject: [PATCH 4/4] Remove warnings npm WARN grunt-stylelint@0.8.0 requires a peer of stylelint@^7.8.0 but none was installed. npm WARN stylelint-config-standard@16.0.0 requires a peer of stylelint@^7.8.0 but none was installed. --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 49a22cbe..8c3dcccc 100644 --- a/package.json +++ b/package.json @@ -62,6 +62,7 @@ "rrule-alt": "^2.2.3", "simple-git": "^1.62.0", "socket.io": "^1.7.3", + "stylelint": "^7.10.1", "valid-url": "latest", "walk": "latest" }