From afa0fb8da123bd04c89be4938413faa7a2324d53 Mon Sep 17 00:00:00 2001 From: Chris van Marle Date: Thu, 31 Aug 2017 18:03:23 +0200 Subject: [PATCH] Fix JavaScript error in weatherforecast Change 5568e0c2adc73aa20bebb5bfc47df65fea273b05 introduces JavaScript errors, because it's calling toUpperCase() on a boolean value. --- modules/default/weatherforecast/weatherforecast.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/default/weatherforecast/weatherforecast.js b/modules/default/weatherforecast/weatherforecast.js index f54467e5..0168e559 100644 --- a/modules/default/weatherforecast/weatherforecast.js +++ b/modules/default/weatherforecast/weatherforecast.js @@ -142,10 +142,10 @@ Module.register("weatherforecast",{ var maxTempCell = document.createElement("td"); maxTempCell.innerHTML = forecast.maxTemp; - if(this.config.scale.toUpperCase() == "C") { + if(typeof(this.config.scale) == "string" && this.config.scale.toUpperCase() == "C") { maxTempCell.innerHTML += " °C"; } else { - if(this.config.scale.toUpperCase() == "F") { + if(typeof(this.config.scale) == "string" && this.config.scale.toUpperCase() == "F") { maxTempCell.innerHTML += " °F"; } } @@ -154,10 +154,10 @@ Module.register("weatherforecast",{ var minTempCell = document.createElement("td"); minTempCell.innerHTML = forecast.minTemp; - if(this.config.scale.toUpperCase() == "C") { + if(typeof(this.config.scale) == "string" && this.config.scale.toUpperCase() == "C") { minTempCell.innerHTML += " °C"; } else { - if(this.config.scale.toUpperCase() == "F") { + if(typeof(this.config.scale) == "string" && this.config.scale.toUpperCase() == "F") { minTempCell.innerHTML += " °F"; } }