kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-06-28 12:12:20 +00:00
Code Issues Projects Releases Wiki Activity

[newsfeed] Fix bug where the newsfeed sometimes stops (#3361)

Browse Source 
It appears that #3336 introduced a bug where a newsfeed with >1 items
would stop updating after a while (usually after `activeItem` wraps
around the end of the list). Sorry! My bad, I hadn't tested that case
well enough.
This commit is contained in:
Ross Younger 2024-01-19 00:05:26 +13:00 committed by GitHub
parent 35e4dfb3fe
commit b005a8f30e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -26,6 +26,7 @@ _This release is scheduled to be released on 2024-04-01._
- [newsfeed] Suppress unsightly animation cases when there are 0 or 1 active news items (#3336) - [newsfeed] Suppress unsightly animation cases when there are 0 or 1 active news items (#3336)
- [newsfeed] Always compute the feed item URL using the same helper function (#3336) - [newsfeed] Always compute the feed item URL using the same helper function (#3336)
- Ignore all custom css files (#3359) - Ignore all custom css files (#3359)
- [newsfeed] Fix newsfeed stall issue introduced by #3336 (#3361)
### Deleted ### Deleted

2
modules/default/newsfeed/newsfeed.js
View File

@ -335,7 +335,7 @@ Module.register("newsfeed", {
* *
* (N.B. We set activeItemCount and activeItemHash in getTemplateData().) * (N.B. We set activeItemCount and activeItemHash in getTemplateData().)
*/ */
if (this.newsItems.length !== this.activeItemCount || this.activeItemHash !== this.newsItems[0]?.hash) { if (this.newsItems.length > 1 || this.newsItems.length !== this.activeItemCount || this.activeItemHash !== this.newsItems[0]?.hash) {
this.activeItem++; // this is OK if newsItems.Length==1; getTemplateData will wrap it around this.activeItem++; // this is OK if newsItems.Length==1; getTemplateData will wrap it around
this.updateDom(this.config.animationSpeed); this.updateDom(this.config.animationSpeed);
} }