From be957af6a6eaa24eef2fc6c1e9593db1af06e81e Mon Sep 17 00:00:00 2001 From: Karsten Hassel Date: Thu, 4 Sep 2025 07:07:15 +0200 Subject: [PATCH] bump minimal node version to v22.18.0 (#3877) electron uses node v22.18 in its [current releases](https://releases.electronjs.org/), so we should go hand in hand and use that as the minimal node version --- .github/workflows/automated-tests.yaml | 2 +- .github/workflows/electron-rebuild.yaml | 2 +- CHANGELOG.md | 2 ++ Collaboration.md | 2 +- package-lock.json | 2 +- package.json | 2 +- 6 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/automated-tests.yaml b/.github/workflows/automated-tests.yaml index e0edc064..93c3eed3 100644 --- a/.github/workflows/automated-tests.yaml +++ b/.github/workflows/automated-tests.yaml @@ -38,7 +38,7 @@ jobs: timeout-minutes: 30 strategy: matrix: - node-version: [22.14.0, 22.x, 24.x] + node-version: [22.18.0, 22.x, 24.x] steps: - name: Install electron dependencies and labwc run: | diff --git a/.github/workflows/electron-rebuild.yaml b/.github/workflows/electron-rebuild.yaml index be737d05..7ecdf913 100644 --- a/.github/workflows/electron-rebuild.yaml +++ b/.github/workflows/electron-rebuild.yaml @@ -8,7 +8,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [22.14.0, 22.x, 24.x] + node-version: [22.18.0, 22.x, 24.x] steps: - name: Checkout code uses: actions/checkout@v5 diff --git a/CHANGELOG.md b/CHANGELOG.md index 9a30cf1e..b8c10b89 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,8 @@ planned for 2025-10-01 Thanks to: @dathbe. +> ⚠️ This release needs nodejs version `v22.18.0 or higher` + ### Added - Added configuration option for `User-Agent`, used by calendar & news module (#3255) diff --git a/Collaboration.md b/Collaboration.md index 403a9fe1..140a9af7 100644 --- a/Collaboration.md +++ b/Collaboration.md @@ -35,7 +35,7 @@ Are done by - [ ] test `prep-release` branch - [ ] update `CHANGELOG.md` - [ ] add all contributor names: `...` - - [ ] add min. node version: > ⚠️ This release needs nodejs version `v22.14.0` or higher + - [ ] add min. node version: > ⚠️ This release needs nodejs version `v22.18.0` or higher - [ ] check release link at the bottom of the file - [ ] commit and push all changes - [ ] create pull request from `prep-release` to `develop` branch with title `Prepare Release 2.xx.0` diff --git a/package-lock.json b/package-lock.json index 16a628ba..4415926c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -57,7 +57,7 @@ "stylelint-prettier": "^5.0.3" }, "engines": { - "node": ">=22.14.0" + "node": ">=22.18.0" }, "optionalDependencies": { "electron": "^38.0.0" diff --git a/package.json b/package.json index 09b9dcf0..16029831 100644 --- a/package.json +++ b/package.json @@ -119,7 +119,7 @@ "electron": "^38.0.0" }, "engines": { - "node": ">=22.14.0" + "node": ">=22.18.0" }, "_moduleAliases": { "node_helper": "js/node_helper.js",