From beea7545143aa3f7b524d9d2926d9dc238f01be8 Mon Sep 17 00:00:00 2001 From: buxxi Date: Sat, 11 Mar 2023 16:42:13 +0100 Subject: [PATCH] Fix empty news feed stopping the feed from ever updating again (#3062) If a news feed returns an empty file it will cause the feed to only show the previous entries forever since no new fetch is scheduled. --- CHANGELOG.md | 1 + modules/default/newsfeed/newsfeedfetcher.js | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5374f6af..550d3cf4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -53,6 +53,7 @@ _This release is scheduled to be released on 2023-04-01._ - The wind direction arrow now points in the direction the wind is flowing, not into the wind (#3019) - Fix precipitation css styles and rounding value - Fix wrong vertical alignment of calendar title column when wrapEvents is true (#3053) +- Fix empty news feed stopping the reload forever ## [2.22.0] - 2023-01-01 diff --git a/modules/default/newsfeed/newsfeedfetcher.js b/modules/default/newsfeed/newsfeedfetcher.js index be979b93..6ee3d91b 100644 --- a/modules/default/newsfeed/newsfeedfetcher.js +++ b/modules/default/newsfeed/newsfeedfetcher.js @@ -72,7 +72,6 @@ const NewsfeedFetcher = function (url, reloadInterval, encoding, logFeedWarnings parser.on("end", () => { this.broadcastItems(); - scheduleTimer(); }); parser.on("error", (error) => { @@ -80,6 +79,11 @@ const NewsfeedFetcher = function (url, reloadInterval, encoding, logFeedWarnings scheduleTimer(); }); + //"end" event is not broadcast if the feed is empty but "finish" is used for both + parser.on("finish", () => { + scheduleTimer(); + }); + parser.on("ttl", (minutes) => { try { // 86400000 = 24 hours is mentioned in the docs as maximum value: