From c7c0e67c1d20b9ab8488485fc8aca0ba63d1470b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= <github@bugsounet.fr>
Date: Fri, 20 Jun 2025 17:12:24 +0200
Subject: [PATCH] review logger factory code part: use switch/case (#3812)

Styling code of `logger.js`:

Just use `switch/case` instead of `if/else if`

---------

Co-authored-by: Veeck <github@veeck.de>
---
 CHANGELOG.md |  1 +
 js/logger.js | 37 +++++++++++++++++++++++--------------
 2 files changed, 24 insertions(+), 14 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 98828ce4..d16efdda 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -52,6 +52,7 @@ planned for 2025-07-01
 
 - [core] Update dependencies including electron to v36 (#3774, #3788, #3811, #3804)
 - [core] Update package type to `commonjs`
+- [logger] Review factory code part: use `switch/case` instead of `if/else if` (#3812)
 
 ## [2.31.0] - 2025-04-01
 
diff --git a/js/logger.js b/js/logger.js
index 18709871..272c82c8 100644
--- a/js/logger.js
+++ b/js/logger.js
@@ -11,26 +11,35 @@
 					label: (arg) => {
 						const { method, defaultTokens } = arg;
 						let label = defaultTokens.label(arg);
-						if (method === "error") {
-							label = styleText("red", label);
-						} else if (method === "warn") {
-							label = styleText("yellow", label);
-						} else if (method === "debug") {
-							label = styleText("bgBlue", label);
-						} else if (method === "info") {
-							label = styleText("blue", label);
+						switch (method) {
+							case "error":
+								label = styleText("red", label);
+								break;
+							case "warn":
+								label = styleText("yellow", label);
+								break;
+							case "debug":
+								label = styleText("bgBlue", label);
+								break;
+							case "info":
+								label = styleText("blue", label);
+								break;
 						}
 						return label;
 					},
 					msg: (arg) => {
 						const { method, defaultTokens } = arg;
 						let msg = defaultTokens.msg(arg);
-						if (method === "error") {
-							msg = styleText("red", msg);
-						} else if (method === "warn") {
-							msg = styleText("yellow", msg);
-						} else if (method === "info") {
-							msg = styleText("blue", msg);
+						switch (method) {
+							case "error":
+								msg = styleText("red", msg);
+								break;
+							case "warn":
+								msg = styleText("yellow", msg);
+								break;
+							case "info":
+								msg = styleText("blue", msg);
+								break;
 						}
 						return msg;
 					}