Prevent getModules() selectors from returning duplicate entries.

CHANGELOG.md

@@ -2,6 +2,11 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## Unpublished
+
+### Fixed
+- Prevent `getModules()` selectors from returning duplicate entries.
+
 ## [2.0.3] - 2016-07-12
 ### Added
 - Add max newsitems parameter to the newsfeed module.

js/main.js

@@ -1,4 +1,5 @@
 /* global  Log, Loader, Module, config, defaults */
+/* jshint -W020 */
 
 /* Magic Mirror
  * Main System
@@ -225,25 +226,24 @@ var MM = (function() {
 		 * return array - Filtered collection of modules.
 		 */
 		var withClass = function(className) {
-			var newModules = [];
-
 			var searchClasses = className;
 			if (typeof className === "string") {
 				searchClasses = className.split(" ");
 			}
 
-			for (var m in modules) {
+			var newModules = modules.filter(function(module) {
-				var module = modules[m];
 				var classes = module.data.classes.toLowerCase().split(" ");
 
 				for (var c in searchClasses) {
 					var searchClass = searchClasses[c];
 					if (classes.indexOf(searchClass.toLowerCase()) !== -1) {
-						newModules.push(module);
+						return true;
-					}
 					}
 				}
 
+				return false;
+			});
+
 			setSelectionMethodsForModules(newModules);
 			return newModules;
 		};
@@ -256,29 +256,24 @@ var MM = (function() {
 		 * return array - Filtered collection of modules.
 		 */
 		var exceptWithClass  = function(className) {
-			var newModules = [];
-
 			var searchClasses = className;
 			if (typeof className === "string") {
 				searchClasses = className.split(" ");
 			}
 
-			for (var m in modules) {
+			var newModules = modules.filter(function(module) {
-				var module = modules[m];
 				var classes = module.data.classes.toLowerCase().split(" ");
-				var foundClass = false;
+
 				for (var c in searchClasses) {
 					var searchClass = searchClasses[c];
 					if (classes.indexOf(searchClass.toLowerCase()) !== -1) {
-						foundClass = true;
+						return false;
-						break;
-					}
-				}
-				if (!foundClass) {
-					newModules.push(module);
 					}
 				}
 
+				return true;
+			});
+
 			setSelectionMethodsForModules(newModules);
 			return newModules;
 		};
@@ -291,14 +286,9 @@ var MM = (function() {
 		 * return array - Filtered collection of modules.
 		 */
 		var exceptModule = function(module) {
-			var newModules = [];
+			var newModules = modules.filter(function(mod) {
-
+				return mod.identifier !== module.identifier;
-			for (var m in modules) {
+			});
-				var mod = modules[m];
-				if (mod.identifier !== module.identifier) {
-					newModules.push(mod);
-				}
-			}
 
 			setSelectionMethodsForModules(newModules);
 			return newModules;
@@ -310,10 +300,9 @@ var MM = (function() {
 		 * argument callback function - The function to execute with the module as an argument.
 		 */
 		var enumerate = function(callback) {
-			for (var m in modules) {
+			modules.map(function(module) {
-				var module = modules[m];
 				callback(module);
-			}
+			});
 		};
 
 		if (typeof modules.withClass === "undefined") { Object.defineProperty(modules, "withClass",  {value: withClass, enumerable: false}); }