From 853085e755d88f778ef31e754e32128f9163f78e Mon Sep 17 00:00:00 2001 From: Christoph Hagedorn Date: Sat, 15 Jun 2019 11:32:03 +0200 Subject: [PATCH 1/2] added null check for moduleWrapper (fixes race condition if element is updated) --- js/main.js | 1 + 1 file changed, 1 insertion(+) diff --git a/js/main.js b/js/main.js index 2330d3ee..382bc820 100644 --- a/js/main.js +++ b/js/main.js @@ -203,6 +203,7 @@ var MM = (function() { */ var updateModuleContent = function(module, newHeader, newContent) { var moduleWrapper = document.getElementById(module.identifier); + if (moduleWrapper === null) return; var headerWrapper = moduleWrapper.getElementsByClassName("module-header"); var contentWrapper = moduleWrapper.getElementsByClassName("module-content"); From a5fca87dd0b25c0ba70cea0ce72e5169f116cbe6 Mon Sep 17 00:00:00 2001 From: Christoph Hagedorn Date: Sat, 15 Jun 2019 11:49:57 +0200 Subject: [PATCH 2/2] updated info: fixed race condition on module update --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2d129716..315851f8 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -35,6 +35,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). - Only update clock once per minute when seconds aren't shown ### Fixed +- fixed uncaught exception, race condition on module update - fixed issue [#1696](https://github.com/MichMich/MagicMirror/issues/1696), some ical files start date to not parse to date type - Allowance HTML5 autoplay-policy (policy is changed from Chrome 66 updates) - Handle SIGTERM messages