From d2b3414ac689f65253228bfa90c05e7b471adaf6 Mon Sep 17 00:00:00 2001
From: buxxi <buxxi@omfilm.net>
Date: Sat, 13 Mar 2021 12:02:56 +0100
Subject: [PATCH] changelog for zombie processes and fixing linting error

---
 CHANGELOG.md                                      | 1 +
 modules/default/updatenotification/node_helper.js | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1f7a96e4..2367b770 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -52,6 +52,7 @@ _This release is scheduled to be released on 2021-04-01._
 - Fix socket.io backward compatibility with socket v2 clients
 - 3rd party module language loading if language is English
 - Fix e2e tests after spectron update
+- Fix updatenotification creating zombie processes by setting a timeout for the git process
 
 ## [2.14.0] - 2021-01-01
 
diff --git a/modules/default/updatenotification/node_helper.js b/modules/default/updatenotification/node_helper.js
index fa355233..e2e5617c 100644
--- a/modules/default/updatenotification/node_helper.js
+++ b/modules/default/updatenotification/node_helper.js
@@ -66,7 +66,7 @@ module.exports = NodeHelper.create({
 	},
 
 	performFetch: async function () {
-		for (sg of simpleGits) {
+		for (let sg of simpleGits) {
 			try {
 				let fetchData = await sg.git.fetch(["--dry-run"]).status();
 				let logData = await sg.git.log({ "-1": null });