From d3c0b9a4385ca7542837df002e8ff7e27fea7726 Mon Sep 17 00:00:00 2001 From: Joseph Bethge Date: Sat, 28 Jan 2017 12:26:52 +0100 Subject: [PATCH] fix module hidden status --- CHANGELOG.md | 1 + js/main.js | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6a3d7332..9f233c2a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,6 +37,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). - Fix an issue where the analog clock looked scrambled. ([#611](https://github.com/MichMich/MagicMirror/issues/611)) - If units is set to imperial, the showRainAmount option of weatherforecast will show the correct unit. - Module currentWeather: check if temperature received from api is defined. +- Fix an issue with module hidden status changing to `true` although lock string prevented showing it ## [2.1.0] - 2016-12-31 diff --git a/js/main.js b/js/main.js index 325a7efe..fde5564d 100644 --- a/js/main.js +++ b/js/main.js @@ -232,6 +232,8 @@ var MM = (function() { return; } + module.hidden = false; + // If forced show, clean current lockstrings. if (module.lockStrings.length !== 0 && options.force === true) { Log.log("Force show of module: " + module.name); @@ -504,7 +506,7 @@ var MM = (function() { * argument options object - Optional settings for the hide method. */ showModule: function(module, speed, callback, options) { - module.hidden = false; + // do not change module.hidden yet, only if we really show it later showModule(module, speed, callback, options); } };