kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-06-28 12:12:20 +00:00
Code Issues Projects Releases Wiki Activity

Fix for #3345 - precipitation probability not displayed when it is 0% (#3346)

Browse Source 
Fixes issue #3345. 

I think I submitted this correctly, but don't do this often so let me
know if anything needs to be corrected.

---------

Co-authored-by: Veeck <github@veeck.de>
This commit is contained in:
vppencilsharpener 2024-03-21 09:11:23 -04:00 committed by GitHub
parent c5f90501ef
commit d970214a0e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -33,6 +33,7 @@ _This release is scheduled to be released on 2024-04-01._
- Worked around several issues in the RRULE library that were causing deleted calender events to still show, some - Worked around several issues in the RRULE library that were causing deleted calender events to still show, some
initial and recurring events to not show, and some event times to be off an hour. (#3291) initial and recurring events to not show, and some event times to be off an hour. (#3291)
- Skip changelog requirement when running tests for dependency updates (#3320) - Skip changelog requirement when running tests for dependency updates (#3320)
- Display precipitation probability when it is 0% instead of blank/empty (#3345)
- [newsfeed] Suppress unsightly animation cases when there are 0 or 1 active news items (#3336) - [newsfeed] Suppress unsightly animation cases when there are 0 or 1 active news items (#3336)
- [newsfeed] Always compute the feed item URL using the same helper function (#3336) - [newsfeed] Always compute the feed item URL using the same helper function (#3336)
- Ignore all custom css files (#3359) - Ignore all custom css files (#3359)

2
modules/default/weather/weather.js
View File

@ -233,7 +233,7 @@ Module.register("weather", {
} }
} }
} else if (type === "precip") { } else if (type === "precip") {
if (value === null || isNaN(value) || value === 0 || value.toFixed(2) === "0.00") { if (value === null || isNaN(value)) {
formattedValue = ""; formattedValue = "";
} else { } else {
formattedValue = WeatherUtils.convertPrecipitationUnit(value, valueUnit, this.config.units); formattedValue = WeatherUtils.convertPrecipitationUnit(value, valueUnit, this.config.units);