kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-06-27 11:50:00 +00:00
Code Issues Projects Releases Wiki Activity

Use single config backup file when config.template is used (#3104)

Browse Source 
Copy `config.js` to a single `config.js-old` file whenever a
`config.template` is present, instead of using `Date()` as a suffix.
Creating files with a timestamp suffix means that whenever Magic Mirror
is restarted or recreated a new file is written into the config
directory.

Benefits:
* Single backup file will avoid excessive writing of files
* Saves space and usage on SD cards.
* Makes the folder cleaner and easier to overview, compared to ending up
with something like this as time goes on:

![image](https://github.com/MichMich/MagicMirror/assets/17575446/9b66a99c-e760-471e-884c-9daa19689702)
This commit is contained in:
Oscar Björkman 2023-05-15 20:11:23 +02:00 committed by GitHub
parent d832d795df
commit e09d60d1d1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -71,6 +71,7 @@ Special thanks to @khassel, @rejas and @sdetweil for taking over most (if not al
- Update Eslint config, add new rule and handle issue - Update Eslint config, add new rule and handle issue
- Convert lots of callbacks to async/await - Convert lots of callbacks to async/await
- Revise require imports (#3071 and #3072) - Revise require imports (#3071 and #3072)
- Use `config.js-old` instead of file with timestamp suffix when backing up config with a `config.template` in use (#3104)
### Fixed ### Fixed

2
js/app.js
View File

@ -76,7 +76,7 @@ function App() {
// save current config.js // save current config.js
try { try {
if (fs.existsSync(configFilename)) { if (fs.existsSync(configFilename)) {
fs.copyFileSync(configFilename, `${configFilename}_${Date.now()}`); fs.copyFileSync(configFilename, `${configFilename}-old`);
} }
} catch (err) { } catch (err) {
Log.warn(`Could not copy ${configFilename}: ${err.message}`); Log.warn(`Could not copy ${configFilename}: ${err.message}`);