From 6f1c7d62538a2190fd4a87e15c7ea8fb4a2fd48b Mon Sep 17 00:00:00 2001 From: Brandon Marlowe Date: Tue, 28 Jul 2020 23:51:38 -0400 Subject: [PATCH 1/2] added --dry-run option to prevent updatenotification module from consuming fetch result --- modules/default/updatenotification/node_helper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/default/updatenotification/node_helper.js b/modules/default/updatenotification/node_helper.js index 0c206c5f..973dca51 100644 --- a/modules/default/updatenotification/node_helper.js +++ b/modules/default/updatenotification/node_helper.js @@ -72,7 +72,7 @@ module.exports = NodeHelper.create({ performFetch: function () { var self = this; simpleGits.forEach((sg) => { - sg.git.fetch().status((err, data) => { + sg.git.fetch(["--dry-run"]).status((err, data) => { data.module = sg.module; if (!err) { sg.git.log({ "-1": null }, (err, data2) => { From a0d4e8dafcbd0cdfb80ef9017932d388f9fb976a Mon Sep 17 00:00:00 2001 From: Brandon Marlowe Date: Tue, 28 Jul 2020 23:55:39 -0400 Subject: [PATCH 2/2] updated changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0f75d5e1..05446f80 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,9 @@ _This release is scheduled to be released on 2020-10-01._ ### Added +- `--dry-run` option adde in fetch call within updatenotification node_helper. This is to prevent + MagicMirror from consuming any fetch result. Causes conflict with MMPM when attempting to check + for updates to MagicMirror and/or MagicMirror modules. - Test coverage with Istanbul, run it with `npm run test:coverage`. - Add lithuanian language. - Added support in weatherforecast for OpenWeather onecall API.