From f4910f0a8ef049ae52b307a12208ee5ed96a726d Mon Sep 17 00:00:00 2001 From: Shameer Ashraf Date: Fri, 29 Jun 2018 00:23:04 -0400 Subject: [PATCH 1/4] Fixed Heat Index for Kelvin --- modules/default/currentweather/currentweather.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/default/currentweather/currentweather.js b/modules/default/currentweather/currentweather.js index 106b7920..09f582bf 100644 --- a/modules/default/currentweather/currentweather.js +++ b/modules/default/currentweather/currentweather.js @@ -437,7 +437,7 @@ Module.register("currentweather",{ case "imperial": this.feelsLike = Hindex.toFixed(0); break; case "default": - var tc = Hindex - 273.15; + var tc = parseFloat((Hindex - 32) / 1.8) + 273.15; this.feelsLike = tc.toFixed(0); break; } From 34e5f294192e2bbcf439ae2f22b0dae7c51cca5e Mon Sep 17 00:00:00 2001 From: Shameer Ashraf Date: Fri, 29 Jun 2018 01:00:20 -0400 Subject: [PATCH 2/4] Fixed Wind Chill in Kelvin --- modules/default/currentweather/currentweather.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/default/currentweather/currentweather.js b/modules/default/currentweather/currentweather.js index 09f582bf..18ae3c71 100644 --- a/modules/default/currentweather/currentweather.js +++ b/modules/default/currentweather/currentweather.js @@ -417,7 +417,7 @@ Module.register("currentweather",{ case "imperial": this.feelsLike = windChillInF.toFixed(0); break; case "default": - var tc = windChillInC - 273.15; + var tc = windChillInC + 273.15; this.feelsLike = tc.toFixed(0); break; } From 4eb49d872b1b3ac457ff1b176dd2377e10dd7831 Mon Sep 17 00:00:00 2001 From: Shameer Ashraf Date: Fri, 29 Jun 2018 13:24:28 -0400 Subject: [PATCH 3/4] Updated changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3eca6d25..47710c87 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). - Newsfeed now remembers to show the description when `"ARTICLE_LESS_DETAILS"` is called if the user wants to always show the description. [#1282](https://github.com/MichMich/MagicMirror/issues/1282) - `clientonly/*.js` is now linted, and one linting error is fixed - Fix issue #1196 by changing underscore to hyphen in locale id, in align with momentjs. +- Fixed issue where heat index and wind chill were reporting incorrect values in Kelvin. ### Updated - Updated Italian translation From 5c01a446449e5ad0024a542c656c5d3ad7ab2363 Mon Sep 17 00:00:00 2001 From: Shameer Ashraf Date: Fri, 29 Jun 2018 13:27:55 -0400 Subject: [PATCH 4/4] Updated changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 47710c87..6b726c5d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,7 +40,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). - Newsfeed now remembers to show the description when `"ARTICLE_LESS_DETAILS"` is called if the user wants to always show the description. [#1282](https://github.com/MichMich/MagicMirror/issues/1282) - `clientonly/*.js` is now linted, and one linting error is fixed - Fix issue #1196 by changing underscore to hyphen in locale id, in align with momentjs. -- Fixed issue where heat index and wind chill were reporting incorrect values in Kelvin. +- Fixed issue where heat index and wind chill were reporting incorrect values in Kelvin. [#1263](https://github.com/MichMich/MagicMirror/issues/1263) ### Updated - Updated Italian translation