Karsten Hassel
a41aa48dd1
add .gitattributes and fix prettier/js warnings ( #3094 )
...
see title, as discussed in
https://github.com/MichMich/MagicMirror/pull/3093
2023-04-22 09:29:51 +02:00
Kristjan ESPERANTO
d276a7ddb9
Use template literals instead of string concatenation ( #3066 )
...
We have used it inconsistently till now. Template literals are more
modern and easier to maintain in my opinion.
Because that's a large amount of changes, here's a way to reproduce it:
I added the rule `"prefer-template": "error"` to the `.eslintrc.json`
and did an autofix. Since this caused a new problem in line 409 of
`newsfeed.js`, I reversed it in that line and also removed the rule from
the eslint config file.
The rule is described here:
https://eslint.org/docs/latest/rules/prefer-template
Note: I've played around with some other linter rules as well, and some
seem to point to some specific, non-cosmetic, issues. But before I dive
even deeper and then introduce even bigger and hardly understandable
changes at once, I thought I'd start with this simple cosmetic rule.
2023-03-19 14:32:23 +01:00
Veeck
498b440174
Convert module-start to async ( #3049 )
...
Similar to the node_helper async start PR...
---------
Co-authored-by: veeck <michael@veeck.de>
2023-02-22 18:58:29 +01:00
Veeck
a2624442cc
Cleanup compliments module ( #2965 )
...
Lots of small fixes and cleanups:
- only render something when there is a compliment
- cleanup naming
- use es6 notations
- use fetch instead of XMLHttpRequest in compliments
Co-authored-by: veeck <michael@veeck.de>
Co-authored-by: Karsten Hassel <hassel@gmx.de>
2022-12-10 21:23:00 +01:00
Karsten Hassel
ad4dbd786a
added new electron tests supporting date mocking ( #2947 )
...
first PR for #2942
- added new electron tests for calendar which test new css classes from
https://github.com/MichMich/MagicMirror/pull/2939
- moved some compliments tests from `e2e` to `electron` because of date
mocking
- removed mock stuff from compliments module
2022-10-17 07:20:23 +02:00
Kristjan SCHMIDT
a5668b1b99
Magic Mirror -> MagicMirror²
...
Consistent spelling
2022-01-26 23:09:26 +01:00
rejas
4b1c7da171
Update jsdoc
2021-05-19 11:12:56 +02:00
rejas
bda8f26511
Use es6 notation in compliments module and cleanup jsdoc
2021-04-17 16:29:38 +02:00
rejas
e0d43a4c1e
Add new Event CURRENTWEATHER_TYPE
...
- send it from the weather and currentweather module
- use it in the compliments module directly instead of the data
2021-01-15 21:47:14 +01:00
Michael Teeuw
42c13fa584
Update compliments.js
2020-06-24 09:49:14 +02:00
Veeck
94f212a411
Fix travis error due to merge before prettier run
2020-05-25 20:00:59 +02:00
Michael Teeuw
4e1dce70a3
Merge pull request #2013 from rejas/prettier
...
Add Prettier for an even cleaner code-experience
2020-05-25 18:46:36 +02:00
ndo@ndo3
a35e8f3315
update: spaces -> tabs
2020-05-14 15:00:09 +02:00
ndo@ndo3
205de7233e
add: advice api to compliments module
2020-05-14 14:56:38 +02:00
Veeck
abb5dc5739
Run prettier over ALL files once
...
No other changes done in this commit
2020-05-11 22:22:32 +02:00
Veeck
7fc7d626bc
Add Module to globals, cleanup comments
2020-05-05 14:55:15 +02:00
rejas
b9d19cfcb4
First round of undef fixes
2020-05-03 12:40:48 +02:00
rejas
d8f093b226
Cleanup some globals
2020-05-02 10:33:24 +02:00
rejas
e7fc4ef1e7
Replace unsecure links with https ones
2020-04-28 23:05:28 +02:00
Michael Teeuw
2464d01891
Fix date test.
2020-04-01 10:57:50 +02:00
Michael Teeuw
2674bf22d8
Let's use sensible defaults. :)
2020-04-01 09:44:22 +02:00
rejas
ff7dc95e93
Implement suggestions from Michael
2020-03-28 09:24:30 +01:00
rejas
65e1b60fb7
Fix error when no compliments are set
2020-03-25 06:40:23 +01:00
rejas
2a31ece0c6
Refactor code
2020-03-25 06:40:23 +01:00
rejas
cafa4211a6
Update changelog and add another birtday
2020-03-25 06:40:23 +01:00
rejas
82b50d3059
Add basic compliment on a specific day of the year
2020-03-25 06:39:24 +01:00
Kurtis Blankenship
8aa745471b
fix: Issue #1798 - fixing recurrent calendar events crosstime DST
2020-01-17 22:53:14 -06:00
Sam Detweiler
42bab052e0
fix comment
2019-12-08 10:07:55 -06:00
Sam Detweiler
0cb377618e
add support for sequential compliments usage
2019-12-08 09:28:50 -06:00
Sam Detweiler
5e4d25b957
add support for newline (\n) in compliment text
2019-12-08 08:50:00 -06:00
rejas
2bce15dc6e
Remove multiple-empty-lines
2019-06-05 10:03:28 +02:00
rejas
5c08bde0fa
More == -> === and != -> !== fixes
2019-06-05 09:32:10 +02:00
ubertao
ba428c6cfe
Use 'white-space: pre-line' for multi-line compliment.
2018-09-24 23:01:17 +08:00
ubertao
cad7debc5b
Replace innerHTML() with createElement() and appendChild() for security.
2018-09-20 08:49:17 +08:00
ubertao
6034891fed
Support multi-line compliments.
2018-09-17 00:51:37 +08:00
idoodler
b140ef3b7a
Ability to fetch compliments from a remote server
2018-06-03 15:47:56 +02:00
Chris Pickett
6bb4db3842
Midori 0.4.3 support
2018-04-07 20:01:53 -05:00
vvzvlad
649652e373
Merge branch 'develop' into vvzvlad_local
2018-02-07 14:10:43 +03:00
vvzvlad
f9a525068b
add variable morning afternoon times
2018-02-05 18:15:02 +03:00
henrysun18
6802d152da
Show remote compliments at boot instead of after one updateInterval
2018-01-31 23:19:47 -05:00
fewieden
c4282a3593
null isn't typeof undefined
2017-04-22 12:25:51 +02:00
fewieden
778107aae9
add edge case anytime only
2017-04-22 12:09:52 +02:00
fewieden
581af762f9
bugfix for duplicated compliments
2017-04-22 11:35:42 +02:00
LAPTOP-KAUR\race2
90f60f95f7
formating fix so that grunt passes
2017-02-08 19:29:52 +02:00
LAPTOP-KAUR\race2
cbafaf5d56
compliments,js handles remoteFile without default daytimes defined
2017-02-08 02:35:09 +02:00
Kyle Carson
79c79146a5
Support anytime compliment group.
2017-02-05 19:28:42 -06:00
Michael Teeuw
48db615ac8
Merge pull request #553 from roramirez/grunt-eslint-modules
...
Grunt eslint modules
2016-12-13 12:58:43 +01:00
Rodrigo Ramírez Norambuena
53d2c7e89f
compliments: add abilty to set classes for compliments module
2016-12-09 10:49:49 -03:00
Rodrigo Ramírez Norambuena
83ee0534f2
fixed eslint error into modules for Javascript files
2016-12-02 23:23:54 -03:00
Brian
950fa84d1c
Added capability to load compliments from the host file system.
2016-11-30 10:30:49 -05:00
