Veeck
7e58b38ddf
Add no-param-reassign from eslint ( #3089 )
...
While waiting for the easterbunny I cleaned up some bad coding practice
:-)
Very open for comments especially regarding the places I commented
myself...
---------
Co-authored-by: veeck <michael@veeck.de>
2023-04-16 17:38:39 +02:00
Kristjan ESPERANTO
d276a7ddb9
Use template literals instead of string concatenation ( #3066 )
...
We have used it inconsistently till now. Template literals are more
modern and easier to maintain in my opinion.
Because that's a large amount of changes, here's a way to reproduce it:
I added the rule `"prefer-template": "error"` to the `.eslintrc.json`
and did an autofix. Since this caused a new problem in line 409 of
`newsfeed.js`, I reversed it in that line and also removed the rule from
the eslint config file.
The rule is described here:
https://eslint.org/docs/latest/rules/prefer-template
Note: I've played around with some other linter rules as well, and some
seem to point to some specific, non-cosmetic, issues. But before I dive
even deeper and then introduce even bigger and hardly understandable
changes at once, I thought I'd start with this simple cosmetic rule.
2023-03-19 14:32:23 +01:00
Veeck
1b2785cc56
Cleanup more callback things ( #3051 )
...
Looks quite stable on my computers, so maybe we give it a try?
---------
Co-authored-by: veeck <michael@veeck.de>
2023-02-26 18:36:47 +01:00
Veeck
2b792cdbb8
Convert translator callbacks to async/await ( #3048 )
...
Co-authored-by: veeck <michael@veeck.de>
2023-02-21 22:58:18 +01:00
veeck
0b01e9dbe0
Fix jsdoc error
2022-11-06 17:51:15 +01:00
Kristjan SCHMIDT
6f27e5ae07
MagicMirror -> MagicMirror²
2022-01-26 23:47:51 +01:00
Kristjan SCHMIDT
a5668b1b99
Magic Mirror -> MagicMirror²
...
Consistent spelling
2022-01-26 23:09:26 +01:00
Tom Hirschberger
1ba4213910
set the hidden class by classList features instead of string manipulation now
2022-01-11 15:54:45 +01:00
Tom Hirschberger
b3dd531abb
removed adding of shown class
2022-01-11 15:52:00 +01:00
Tom Hirschberger
4325fcdca2
automatically add/remove a hidden/shown class to the module wrappers if they get hidden or shown
2022-01-11 15:20:33 +01:00
veeck
214614f740
Cleanup jsdoc via eslint
2021-06-09 12:49:57 +02:00
rejas
de93b3294f
Use es6 notation in main.js
2021-04-18 15:29:10 +02:00
Michael Teeuw
b2a21b937d
Change error string.
2021-02-23 14:11:54 +01:00
Felix Wiedenbach
652e1a528f
Merge branch 'develop' into feature/add-error-to-callback
...
# Conflicts:
# CHANGELOG.md
2021-02-13 08:43:23 +01:00
Felix Wiedenbach
9d85baee37
move error callback into options and rename it
2021-02-13 08:29:13 +01:00
veeck
8c83dc9494
Cleanup jsdoc
2021-02-06 22:20:49 +01:00
Felix Wiedenbach
88ed5ed373
add error separate callback
2021-02-06 21:22:13 +01:00
Felix Wiedenbach
84995c9252
Merge branch 'develop' into feature/add-error-to-callback
...
# Conflicts:
# CHANGELOG.md
2021-02-06 11:29:17 +01:00
rejas
88c80973f1
Dont updateDOM when the module is not displayed
2021-02-05 22:40:05 +01:00
Felix Wiedenbach
41da6f455a
use error object for callback to include stack trace
2021-01-28 21:23:48 +01:00
Felix Wiedenbach
d2a7a3b0bb
more error like message
2021-01-28 21:13:17 +01:00
Felix Wiedenbach
2324579057
add error to module show callback
2021-01-28 07:33:02 +01:00
Karsten Hassel
e507f95b2a
added suggestion from @rejas
2020-12-29 21:45:35 +01:00
Karsten Hassel
61cf92c67a
removes undefined objects from modules array, see issue #2382
2020-12-29 21:14:42 +01:00
rejas
ec08cb32aa
Set visibility of header more explicitly
2020-08-13 21:51:18 +02:00
rejas
02779ef725
Cleanup main jsdoc
2020-08-01 17:06:46 +02:00
Stephan Huber
377e42affc
fix display style for older browsers
2020-07-10 23:12:17 +02:00
rejas
9f5e1b59fb
Set logLevel after loading config
2020-07-04 22:02:39 +02:00
Veeck
abb5dc5739
Run prettier over ALL files once
...
No other changes done in this commit
2020-05-11 22:22:32 +02:00
Veeck
7fc7d626bc
Add Module to globals, cleanup comments
2020-05-05 14:55:15 +02:00
rejas
b9d19cfcb4
First round of undef fixes
2020-05-03 12:40:48 +02:00
rejas
d8f093b226
Cleanup some globals
2020-05-02 10:33:24 +02:00
rejas
e7fc4ef1e7
Replace unsecure links with https ones
2020-04-28 23:05:28 +02:00
rejas
b1fb177e4b
Undo "fix" in main.js that broke the tests
2020-04-21 12:38:29 +02:00
Veeck
ec187fe109
Update changelog and commen tags
2020-04-21 12:23:50 +02:00
Veeck
9ec329b7ae
Final fixes for eslint:recommended
2020-04-21 12:23:50 +02:00
Michael Teeuw
fe6645a420
Merge pull request #1955 from rejas/jshint
...
Remove jshint dependency
2020-03-24 21:16:12 +01:00
Michael Teeuw
a49816f4eb
Merge pull request #1948 from rejas/lint
...
Run linter tests on travis (was: Run linter before commit)
2020-03-24 21:15:41 +01:00
bugsounet
8aa7a55559
issue #1956
2020-03-19 19:03:25 +01:00
rejas
a91f2de26a
Remove jshint dependency, use eslint for config verification
2020-03-15 20:38:52 +01:00
rejas
5a4ae99283
Add no-multi-spaces rule to eslint and run it
2020-03-15 15:49:34 +01:00
Thomas Bouron
d8b7292d4b
Fix module header update if using customising from module.getHeaders()
2019-12-26 14:07:13 +00:00
Rodrigo Ramírez Norambuena
82ee051c1a
linter fixes
2019-07-26 01:25:26 -04:00
Christoph Hagedorn
f06ce55626
Merge remote-tracking branch 'upstream/develop' into develop
2019-06-15 11:33:44 +02:00
Christoph Hagedorn
853085e755
added null check for moduleWrapper
...
(fixes race condition if element is updated)
2019-06-15 11:32:03 +02:00
rejas
5c08bde0fa
More == -> === and != -> !== fixes
2019-06-05 09:32:10 +02:00
rejas
ea1715384e
Revert "Revert "Fix some == with ===""
...
This reverts commit d9a4ee4f658171e4a7854ef856adba5f904fbfbe.
2019-06-05 08:48:22 +02:00
rejas
d9a4ee4f65
Revert "Fix some == with ==="
...
This reverts commit 5d39d8521575c30b203380d977a71e7590a524ba.
2019-06-04 11:04:47 +02:00
rejas
5d39d85215
Fix some == with ===
2019-06-04 09:51:51 +02:00
rejas
99b4c43fd5
Fix typos and some whitespaces
2019-06-04 09:33:53 +02:00
