mirror of
https://github.com/MichMich/MagicMirror.git
synced 2025-12-12 09:52:37 +00:00
9d713ffd69
`node-libgpiod` uses deprecated NAN which is incompatible with Electron v39+. `serialport` uses N-API ensuring compatibility with current and future Electron versions. `node-libgpiod` is only used by 1 of ~1300 3rd-party-modules (MMM-PresenceScreenControl), while serialport is used by at least 4 modules (MMM-Serial-Notification, MMM-RadarPresence, MMM-LKY-TIC and MMM-Gestures), making it a better test candidate. Also updates Electron to v39. Fixes #3933
29 lines
811 B
YAML
29 lines
811 B
YAML
name: "Electron Rebuild Testing"
|
|
|
|
on: [pull_request]
|
|
|
|
jobs:
|
|
rebuild:
|
|
name: Run electron-rebuild
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
matrix:
|
|
node-version: [22.20.0, 22.x, 24.x]
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v5
|
|
- name: "Use Node.js ${{ matrix.node-version }}"
|
|
uses: actions/setup-node@v6
|
|
with:
|
|
node-version: ${{ matrix.node-version }}
|
|
check-latest: true
|
|
- name: Install MagicMirror
|
|
run: node --run install-mm
|
|
- name: Install @electron/rebuild
|
|
run: npm install @electron/rebuild
|
|
- name: Install test library (serialport) to be rebuilt
|
|
run: npm install serialport
|
|
- name: Run electron-rebuild
|
|
run: npx electron-rebuild
|
|
continue-on-error: false
|