mirror of
https://github.com/MichMich/MagicMirror.git
synced 2025-06-27 19:53:36 +00:00
We have used it inconsistently till now. Template literals are more modern and easier to maintain in my opinion. Because that's a large amount of changes, here's a way to reproduce it: I added the rule `"prefer-template": "error"` to the `.eslintrc.json` and did an autofix. Since this caused a new problem in line 409 of `newsfeed.js`, I reversed it in that line and also removed the rule from the eslint config file. The rule is described here: https://eslint.org/docs/latest/rules/prefer-template Note: I've played around with some other linter rules as well, and some seem to point to some specific, non-cosmetic, issues. But before I dive even deeper and then introduce even bigger and hardly understandable changes at once, I thought I'd start with this simple cosmetic rule.
29 lines
956 B
JavaScript
29 lines
956 B
JavaScript
const helpers = require("./helpers/global-setup");
|
|
|
|
describe("All font files from roboto.css should be downloadable", () => {
|
|
const fontFiles = [];
|
|
// Statements below filters out all 'url' lines in the CSS file
|
|
const fileContent = require("fs").readFileSync(`${__dirname}/../../fonts/roboto.css`, "utf8");
|
|
const regex = /\burl\(['"]([^'"]+)['"]\)/g;
|
|
let match = regex.exec(fileContent);
|
|
while (match !== null) {
|
|
// Push 1st match group onto fontFiles stack
|
|
fontFiles.push(match[1]);
|
|
// Find the next one
|
|
match = regex.exec(fileContent);
|
|
}
|
|
|
|
beforeAll(async () => {
|
|
await helpers.startApplication("tests/configs/without_modules.js");
|
|
});
|
|
afterAll(async () => {
|
|
await helpers.stopApplication();
|
|
});
|
|
|
|
test.each(fontFiles)("should return 200 HTTP code for file '%s'", async (fontFile) => {
|
|
const fontUrl = `http://localhost:8080/fonts/${fontFile}`;
|
|
const res = await helpers.fetch(fontUrl);
|
|
expect(res.status).toBe(200);
|
|
});
|
|
});
|