mirror of
https://github.com/MichMich/MagicMirror.git
synced 2025-06-27 19:53:36 +00:00
# Added Yr.no as a weather provider Yr.no is a free Norwegian weather service. The configuration is quite simple: ```js { weatherProvider: "yr", lat: 59.9171, lon: 10.7276, altitude: 30 } ``` The latitude and longitude cannot have more than 4 decimals, but that should be plenty. To quote yr: "There is no need to ask for weather forecasts with nanometer precision!". The altitude should be meters above sea level and defaults to 0. If `type` is set to `current` the symbol can display the next 1, 6 or 12 hours by setting `currentForecastHours` (default is 1). It states in [Getting started-guide](https://developer.yr.no/doc/GettingStarted/) that users of the API should cache the results and use the `Expires`-header to know when to ask for new data. By using the `If-Modified-Since`-header we can avoid downloading the same data over and over again. I chose not to override the `User-Agent`-header set in [`server.js`](https://github.com/MichMich/MagicMirror/blob/a328ce5/js/server.js#L97) even though it does not comply with [the terms of service](https://developer.yr.no/doc/TermsOfService/). It currently works with the default header, and by searching the web for MagicMirror the GitHub-repo should be easy to find without an explicit link. I also had to make some minor changes to `server.js` and `weatherprovider.js` to be able to send and return HTTP headers. To handle the HTTP 304 response without body I chose to return `undefined` so we easily can use the response as a condition: `if (response) ...`. The documentation for the API is available here: - [API Reference overview](https://api.met.no/weatherapi/) - [Locationforecast](https://api.met.no/weatherapi/locationforecast/2.0/) - Used to get the weather forecast - [Sunrise](https://api.met.no/weatherapi/sunrise/2.0/documentation) - used to find sunrise and sunset times Co-authored-by: Veeck <github@veeck.de>
112 lines
3.4 KiB
JavaScript
112 lines
3.4 KiB
JavaScript
const { performWebRequest } = require("../../../../modules/default/utils.js");
|
|
const nodeVersion = process.version.match(/^v(\d+)\.*/)[1];
|
|
|
|
describe("Utils tests", () => {
|
|
describe("The performWebRequest-method", () => {
|
|
if (nodeVersion > 18) {
|
|
const locationHost = "localhost:8080";
|
|
const locationProtocol = "http";
|
|
|
|
let fetchResponse;
|
|
let fetchMock;
|
|
let url;
|
|
|
|
beforeEach(() => {
|
|
fetchResponse = new Response();
|
|
global.fetch = jest.fn(() => Promise.resolve(fetchResponse));
|
|
fetchMock = global.fetch;
|
|
|
|
url = "www.test.com";
|
|
});
|
|
|
|
describe("When using cors proxy", () => {
|
|
Object.defineProperty(global, "location", {
|
|
value: {
|
|
host: locationHost,
|
|
protocol: locationProtocol
|
|
}
|
|
});
|
|
|
|
test("Calls correct URL once", async () => {
|
|
const urlToCall = "http://www.test.com/path?param1=value1";
|
|
url = urlToCall;
|
|
|
|
await performWebRequest(url, "json", true);
|
|
|
|
expect(fetchMock.mock.calls.length).toBe(1);
|
|
expect(fetchMock.mock.calls[0][0]).toBe(`${locationProtocol}//${locationHost}/cors?url=${urlToCall}`);
|
|
});
|
|
|
|
test("Sends correct headers", async () => {
|
|
const urlToCall = "http://www.test.com/path?param1=value1";
|
|
url = urlToCall;
|
|
const headers = [
|
|
{ name: "header1", value: "value1" },
|
|
{ name: "header2", value: "value2" }
|
|
];
|
|
|
|
await performWebRequest(url, "json", true, headers);
|
|
|
|
expect(fetchMock.mock.calls.length).toBe(1);
|
|
expect(fetchMock.mock.calls[0][0]).toBe(`${locationProtocol}//${locationHost}/cors?sendheaders=header1:value1,header2:value2&url=${urlToCall}`);
|
|
});
|
|
});
|
|
|
|
describe("When not using cors proxy", () => {
|
|
test("Calls correct URL once", async () => {
|
|
const urlToCall = "http://www.test.com/path?param1=value1";
|
|
url = urlToCall;
|
|
|
|
await performWebRequest(url);
|
|
|
|
expect(fetchMock.mock.calls.length).toBe(1);
|
|
expect(fetchMock.mock.calls[0][0]).toBe(urlToCall);
|
|
});
|
|
|
|
test("Sends correct headers", async () => {
|
|
const urlToCall = "http://www.test.com/path?param1=value1";
|
|
url = urlToCall;
|
|
const headers = [
|
|
{ name: "header1", value: "value1" },
|
|
{ name: "header2", value: "value2" }
|
|
];
|
|
|
|
await performWebRequest(url, "json", false, headers);
|
|
|
|
const expectedHeaders = { headers: { header1: "value1", header2: "value2" } };
|
|
expect(fetchMock.mock.calls.length).toBe(1);
|
|
expect(fetchMock.mock.calls[0][1]).toStrictEqual(expectedHeaders);
|
|
});
|
|
});
|
|
|
|
describe("When receiving json format", () => {
|
|
test("Returns undefined when no data is received", async () => {
|
|
const response = await performWebRequest(url);
|
|
|
|
expect(response).toBe(undefined);
|
|
});
|
|
|
|
test("Returns object when data is received", async () => {
|
|
fetchResponse = new Response('{"body": "some content"}');
|
|
|
|
const response = await performWebRequest(url);
|
|
|
|
expect(response.body).toBe("some content");
|
|
});
|
|
|
|
test("Returns expected headers when data is received", async () => {
|
|
fetchResponse = new Response('{"body": "some content"}', { headers: { header1: "value1", header2: "value2" } });
|
|
|
|
const response = await performWebRequest(url, "json", false, undefined, ["header1"]);
|
|
|
|
expect(response.headers.length).toBe(1);
|
|
expect(response.headers[0].name).toBe("header1");
|
|
expect(response.headers[0].value).toBe("value1");
|
|
});
|
|
});
|
|
} else {
|
|
test("Always ok, need one test", () => {});
|
|
}
|
|
});
|
|
});
|