mirror of
https://github.com/MichMich/MagicMirror.git
synced 2025-07-03 14:26:07 +00:00
While working on the translations (in #3792 and #3794) I realised that the e2e "Same keys" tests were not working entirely. There was also a TODO entry for this in the test, as well as a try-catch-block workaround. I therefore fixed and refactored it. I also sorted the translations in `translations/translations.js`, so that the test outputs are alphabetically.
235 lines
7.2 KiB
JavaScript
235 lines
7.2 KiB
JavaScript
const fs = require("node:fs");
|
|
const path = require("node:path");
|
|
const helmet = require("helmet");
|
|
const { JSDOM } = require("jsdom");
|
|
const express = require("express");
|
|
const sinon = require("sinon");
|
|
const translations = require("../../translations/translations");
|
|
|
|
describe("Translations", () => {
|
|
let server;
|
|
|
|
beforeAll(() => {
|
|
const app = express();
|
|
app.use(helmet());
|
|
app.use((req, res, next) => {
|
|
res.header("Access-Control-Allow-Origin", "*");
|
|
next();
|
|
});
|
|
app.use("/translations", express.static(path.join(__dirname, "..", "..", "translations")));
|
|
|
|
server = app.listen(3000);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await server.close();
|
|
});
|
|
|
|
it("should have a translation file in the specified path", () => {
|
|
for (let language in translations) {
|
|
const file = fs.statSync(translations[language]);
|
|
expect(file.isFile()).toBe(true);
|
|
}
|
|
});
|
|
|
|
describe("loadTranslations", () => {
|
|
let dom;
|
|
|
|
beforeEach(() => {
|
|
dom = new JSDOM(
|
|
`<script>var Translator = {}; var Log = {log: () => {}}; var config = {language: 'de'};</script>\
|
|
<script src="file://${path.join(__dirname, "..", "..", "js", "class.js")}"></script>\
|
|
<script src="file://${path.join(__dirname, "..", "..", "js", "module.js")}"></script>`,
|
|
{ runScripts: "dangerously", resources: "usable" }
|
|
);
|
|
});
|
|
|
|
it("should load translation file", () => {
|
|
return new Promise((done) => {
|
|
dom.window.onload = async () => {
|
|
const { Translator, Module, config } = dom.window;
|
|
config.language = "en";
|
|
Translator.load = sinon.stub().callsFake((_m, _f, _fb) => null);
|
|
|
|
Module.register("name", { getTranslations: () => translations });
|
|
const MMM = Module.create("name");
|
|
|
|
await MMM.loadTranslations();
|
|
|
|
expect(Translator.load.args).toHaveLength(1);
|
|
expect(Translator.load.calledWith(MMM, "translations/en.json", false)).toBe(true);
|
|
|
|
done();
|
|
};
|
|
});
|
|
});
|
|
|
|
it("should load translation + fallback file", () => {
|
|
return new Promise((done) => {
|
|
dom.window.onload = async () => {
|
|
const { Translator, Module } = dom.window;
|
|
Translator.load = sinon.stub().callsFake((_m, _f, _fb) => null);
|
|
|
|
Module.register("name", { getTranslations: () => translations });
|
|
const MMM = Module.create("name");
|
|
|
|
await MMM.loadTranslations();
|
|
|
|
expect(Translator.load.args).toHaveLength(2);
|
|
expect(Translator.load.calledWith(MMM, "translations/de.json", false)).toBe(true);
|
|
expect(Translator.load.calledWith(MMM, "translations/en.json", true)).toBe(true);
|
|
|
|
done();
|
|
};
|
|
});
|
|
});
|
|
|
|
it("should load translation fallback file", () => {
|
|
return new Promise((done) => {
|
|
dom.window.onload = async () => {
|
|
const { Translator, Module, config } = dom.window;
|
|
config.language = "--";
|
|
Translator.load = sinon.stub().callsFake((_m, _f, _fb) => null);
|
|
|
|
Module.register("name", { getTranslations: () => translations });
|
|
const MMM = Module.create("name");
|
|
|
|
await MMM.loadTranslations();
|
|
|
|
expect(Translator.load.args).toHaveLength(1);
|
|
expect(Translator.load.calledWith(MMM, "translations/en.json", true)).toBe(true);
|
|
|
|
done();
|
|
};
|
|
});
|
|
});
|
|
|
|
it("should load no file", () => {
|
|
return new Promise((done) => {
|
|
dom.window.onload = async () => {
|
|
const { Translator, Module } = dom.window;
|
|
Translator.load = sinon.stub();
|
|
|
|
Module.register("name", {});
|
|
const MMM = Module.create("name");
|
|
|
|
await MMM.loadTranslations();
|
|
|
|
expect(Translator.load.callCount).toBe(0);
|
|
|
|
done();
|
|
};
|
|
});
|
|
});
|
|
});
|
|
|
|
const mmm = {
|
|
name: "TranslationTest",
|
|
file (file) {
|
|
return `http://localhost:3000/${file}`;
|
|
}
|
|
};
|
|
|
|
describe("Parsing language files through the Translator class", () => {
|
|
for (let language in translations) {
|
|
it(`should parse ${language}`, () => {
|
|
return new Promise((done) => {
|
|
const dom = new JSDOM(
|
|
`<script>var translations = ${JSON.stringify(translations)}; var Log = {log: () => {}};</script>\
|
|
<script src="file://${path.join(__dirname, "..", "..", "js", "translator.js")}">`,
|
|
{ runScripts: "dangerously", resources: "usable" }
|
|
);
|
|
dom.window.onload = async () => {
|
|
const { Translator } = dom.window;
|
|
|
|
await Translator.load(mmm, translations[language], false);
|
|
expect(typeof Translator.translations[mmm.name]).toBe("object");
|
|
expect(Object.keys(Translator.translations[mmm.name]).length).toBeGreaterThanOrEqual(1);
|
|
done();
|
|
};
|
|
});
|
|
});
|
|
}
|
|
});
|
|
|
|
describe("Same keys", () => {
|
|
let base;
|
|
|
|
// Some expressions are not easy to translate automatically. For the sake of a working test, we filter them out.
|
|
const COMMON_EXCEPTIONS = ["WEEK_SHORT"];
|
|
|
|
// Some languages don't have certain words, so we need to filter those language specific exceptions.
|
|
const LANGUAGE_EXCEPTIONS = {
|
|
ca: ["DAYBEFOREYESTERDAY"],
|
|
cv: ["DAYBEFOREYESTERDAY"],
|
|
cy: ["DAYBEFOREYESTERDAY"],
|
|
en: ["DAYAFTERTOMORROW", "DAYBEFOREYESTERDAY"],
|
|
fy: ["DAYBEFOREYESTERDAY"],
|
|
gl: ["DAYBEFOREYESTERDAY"],
|
|
hu: ["DAYBEFOREYESTERDAY"],
|
|
id: ["DAYBEFOREYESTERDAY"],
|
|
it: ["DAYBEFOREYESTERDAY"],
|
|
"pt-br": ["DAYAFTERTOMORROW"],
|
|
tr: ["DAYBEFOREYESTERDAY"]
|
|
};
|
|
|
|
// Function to initialize JSDOM and load translations
|
|
const initializeTranslationDOM = (language) => {
|
|
const dom = new JSDOM("", { runScripts: "dangerously", resources: "usable" });
|
|
dom.window.Log = { log: jest.fn() };
|
|
dom.window.translations = translations;
|
|
const translatorJs = fs.readFileSync(path.join(__dirname, "..", "..", "js", "translator.js"), "utf-8");
|
|
dom.window.eval(translatorJs);
|
|
|
|
return new Promise((resolve) => {
|
|
dom.window.onload = async () => {
|
|
const { Translator } = dom.window;
|
|
await Translator.load(mmm, translations[language], false);
|
|
resolve(Translator.translations[mmm.name]);
|
|
};
|
|
});
|
|
};
|
|
|
|
beforeAll(async () => {
|
|
// Using German as the base rather than English, since
|
|
// some words do not have a direct translation in English.
|
|
const germanTranslations = await initializeTranslationDOM("de");
|
|
base = Object.keys(germanTranslations).sort();
|
|
});
|
|
|
|
for (const language in translations) {
|
|
if (language === "de") continue;
|
|
|
|
describe(`Translation keys of ${language}`, () => {
|
|
let keys;
|
|
|
|
beforeAll(async () => {
|
|
const languageTranslations = await initializeTranslationDOM(language);
|
|
keys = Object.keys(languageTranslations).sort();
|
|
});
|
|
|
|
it(`${language} should not contain keys that are not in base language`, () => {
|
|
keys.forEach((key) => {
|
|
expect(base).toContain(key, `Translation key '${key}' in language '${language}' is not present in base language`);
|
|
});
|
|
});
|
|
|
|
it(`${language} should contain all base keys (excluding defined exceptions)`, () => {
|
|
let filteredBase = base.filter((key) => !COMMON_EXCEPTIONS.includes(key));
|
|
let filteredKeys = keys.filter((key) => !COMMON_EXCEPTIONS.includes(key));
|
|
|
|
if (LANGUAGE_EXCEPTIONS[language]) {
|
|
const exceptions = LANGUAGE_EXCEPTIONS[language];
|
|
filteredBase = filteredBase.filter((key) => !exceptions.includes(key));
|
|
filteredKeys = filteredKeys.filter((key) => !exceptions.includes(key));
|
|
}
|
|
|
|
filteredBase.forEach((baseKey) => {
|
|
expect(filteredKeys).toContain(baseKey, `Translation key '${baseKey}' is missing in language '${language}'`);
|
|
});
|
|
});
|
|
});
|
|
}
|
|
});
|
|
});
|