mirror of
https://github.com/MichMich/MagicMirror.git
synced 2025-06-27 03:39:55 +00:00
We have used it inconsistently till now. Template literals are more modern and easier to maintain in my opinion. Because that's a large amount of changes, here's a way to reproduce it: I added the rule `"prefer-template": "error"` to the `.eslintrc.json` and did an autofix. Since this caused a new problem in line 409 of `newsfeed.js`, I reversed it in that line and also removed the rule from the eslint config file. The rule is described here: https://eslint.org/docs/latest/rules/prefer-template Note: I've played around with some other linter rules as well, and some seem to point to some specific, non-cosmetic, issues. But before I dive even deeper and then introduce even bigger and hardly understandable changes at once, I thought I'd start with this simple cosmetic rule.
119 lines
4.3 KiB
JavaScript
119 lines
4.3 KiB
JavaScript
const helpers = require("../helpers/global-setup");
|
|
const weatherFunc = require("../helpers/weather-functions");
|
|
|
|
describe("Weather module: Weather Forecast", () => {
|
|
afterAll(async () => {
|
|
await helpers.stopApplication();
|
|
});
|
|
|
|
describe("Default configuration", () => {
|
|
beforeAll(async () => {
|
|
await weatherFunc.startApp("tests/configs/modules/weather/forecastweather_default.js", {});
|
|
});
|
|
|
|
const days = ["Today", "Tomorrow", "Sun", "Mon", "Tue"];
|
|
for (const [index, day] of days.entries()) {
|
|
it(`should render day ${day}`, async () => {
|
|
await weatherFunc.getText(`.weather table.small tr:nth-child(${index + 1}) td:nth-child(1)`, day);
|
|
});
|
|
}
|
|
|
|
const icons = ["day-cloudy", "rain", "day-sunny", "day-sunny", "day-sunny"];
|
|
for (const [index, icon] of icons.entries()) {
|
|
it(`should render icon ${icon}`, async () => {
|
|
const elem = await helpers.waitForElement(`.weather table.small tr:nth-child(${index + 1}) td:nth-child(2) span.wi-${icon}`);
|
|
expect(elem).not.toBe(null);
|
|
});
|
|
}
|
|
|
|
const maxTemps = ["24.4°", "21.0°", "22.9°", "23.4°", "20.6°"];
|
|
for (const [index, temp] of maxTemps.entries()) {
|
|
it(`should render max temperature ${temp}`, async () => {
|
|
await weatherFunc.getText(`.weather table.small tr:nth-child(${index + 1}) td:nth-child(3)`, temp);
|
|
});
|
|
}
|
|
|
|
const minTemps = ["15.3°", "13.6°", "13.8°", "13.9°", "10.9°"];
|
|
for (const [index, temp] of minTemps.entries()) {
|
|
it(`should render min temperature ${temp}`, async () => {
|
|
await weatherFunc.getText(`.weather table.small tr:nth-child(${index + 1}) td:nth-child(4)`, temp);
|
|
});
|
|
}
|
|
|
|
const opacities = [1, 1, 0.8, 0.5333333333333333, 0.2666666666666667];
|
|
for (const [index, opacity] of opacities.entries()) {
|
|
it(`should render fading of rows with opacity=${opacity}`, async () => {
|
|
const elem = await helpers.waitForElement(`.weather table.small tr:nth-child(${index + 1})`);
|
|
expect(elem).not.toBe(null);
|
|
expect(elem.outerHTML).toContain(`<tr style="opacity: ${opacity};">`);
|
|
});
|
|
}
|
|
});
|
|
|
|
describe("Absolute configuration", () => {
|
|
beforeAll(async () => {
|
|
await weatherFunc.startApp("tests/configs/modules/weather/forecastweather_absolute.js", {});
|
|
});
|
|
|
|
const days = ["Fri", "Sat", "Sun", "Mon", "Tue"];
|
|
for (const [index, day] of days.entries()) {
|
|
it(`should render day ${day}`, async () => {
|
|
await weatherFunc.getText(`.weather table.small tr:nth-child(${index + 1}) td:nth-child(1)`, day);
|
|
});
|
|
}
|
|
});
|
|
|
|
describe("Configuration Options", () => {
|
|
beforeAll(async () => {
|
|
await weatherFunc.startApp("tests/configs/modules/weather/forecastweather_options.js", {});
|
|
});
|
|
|
|
it("should render custom table class", async () => {
|
|
const elem = await helpers.waitForElement(".weather table.myTableClass");
|
|
expect(elem).not.toBe(null);
|
|
});
|
|
|
|
it("should render colored rows", async () => {
|
|
const table = await helpers.waitForElement(".weather table.myTableClass");
|
|
expect(table).not.toBe(null);
|
|
expect(table.rows).not.toBe(null);
|
|
expect(table.rows.length).toBe(5);
|
|
});
|
|
|
|
const precipitations = [undefined, "2.51 mm"];
|
|
for (const [index, precipitation] of precipitations.entries()) {
|
|
if (precipitation) {
|
|
it(`should render precipitation amount ${precipitation}`, async () => {
|
|
await weatherFunc.getText(`.weather table tr:nth-child(${index + 1}) td.precipitation-amount`, precipitation);
|
|
});
|
|
}
|
|
}
|
|
});
|
|
|
|
describe("Forecast weather with imperial units", () => {
|
|
beforeAll(async () => {
|
|
await weatherFunc.startApp("tests/configs/modules/weather/forecastweather_units.js", {});
|
|
});
|
|
|
|
describe("Temperature units", () => {
|
|
const temperatures = ["75_9°", "69_8°", "73_2°", "74_1°", "69_1°"];
|
|
for (const [index, temp] of temperatures.entries()) {
|
|
it(`should render custom decimalSymbol = '_' for temp ${temp}`, async () => {
|
|
await weatherFunc.getText(`.weather table.small tr:nth-child(${index + 1}) td:nth-child(3)`, temp);
|
|
});
|
|
}
|
|
});
|
|
|
|
describe("Precipitation units", () => {
|
|
const precipitations = [undefined, "0.10 in"];
|
|
for (const [index, precipitation] of precipitations.entries()) {
|
|
if (precipitation) {
|
|
it(`should render precipitation amount ${precipitation}`, async () => {
|
|
await weatherFunc.getText(`.weather table.small tr:nth-child(${index + 1}) td.precipitation-amount`, precipitation);
|
|
});
|
|
}
|
|
}
|
|
});
|
|
});
|
|
});
|