mirror of
https://github.com/MichMich/MagicMirror.git
synced 2025-06-27 03:39:55 +00:00
d276a7ddb9
We have used it inconsistently till now. Template literals are more modern and easier to maintain in my opinion. Because that's a large amount of changes, here's a way to reproduce it: I added the rule `"prefer-template": "error"` to the `.eslintrc.json` and did an autofix. Since this caused a new problem in line 409 of `newsfeed.js`, I reversed it in that line and also removed the rule from the eslint config file. The rule is described here: https://eslint.org/docs/latest/rules/prefer-template Note: I've played around with some other linter rules as well, and some seem to point to some specific, non-cosmetic, issues. But before I dive even deeper and then introduce even bigger and hardly understandable changes at once, I thought I'd start with this simple cosmetic rule.
23 lines
820 B
JavaScript
23 lines
820 B
JavaScript
const helpers = require("./helpers/global-setup");
|
|
|
|
describe("Position of modules", () => {
|
|
beforeAll(async () => {
|
|
await helpers.startApplication("tests/configs/modules/positions.js");
|
|
await helpers.getDocument();
|
|
});
|
|
afterAll(async () => {
|
|
await helpers.stopApplication();
|
|
});
|
|
|
|
const positions = ["top_bar", "top_left", "top_center", "top_right", "upper_third", "middle_center", "lower_third", "bottom_left", "bottom_center", "bottom_right", "bottom_bar", "fullscreen_above", "fullscreen_below"];
|
|
|
|
for (const position of positions) {
|
|
const className = position.replace("_", ".");
|
|
it(`should show text in ${position}`, async () => {
|
|
const elem = await helpers.waitForElement(`.${className}`);
|
|
expect(elem).not.toBe(null);
|
|
expect(elem.textContent).toContain(`Text in ${position}`);
|
|
});
|
|
}
|
|
});
|