mirror of
https://github.com/MichMich/MagicMirror.git
synced 2025-12-12 18:02:15 +00:00
f29f424a62
### 1. Replace `XMLHttpRequest` with the modern `fetch` API for loading translation files #### Changes - **translator.js**: Use `fetch` with `async/await` instead of XHR callbacks - **loader.js**: Align URL handling and add error handling (follow-up to fetch migration) - **Tests**: Update infrastructure for `fetch` compatibility #### Benefits - Modern standard API - Cleaner, more readable code - Better error handling and fallback mechanisms ### 2. Migrate e2e tests to Playwright This wasn't originally planned for this PR, but is related. While investigating suspicious log entries which surfaced after the fetch migration I kept running into JSDOM’s limitations. That pushed me to migrate the E2E suite to Playwright instead. #### Changes - switch e2e harness to Playwright (`tests/e2e/helpers/global-setup.js`) - rewrite specs to use Playwright locators + shared `expectTextContent` - install Chromium via `npx playwright install --with-deps` in CI #### Benefits - much closer to real browser behaviour - and no more fighting JSDOM’s quirks
75 lines
2.6 KiB
JavaScript
75 lines
2.6 KiB
JavaScript
const { expect } = require("playwright/test");
|
|
const helpers = require("../helpers/global-setup");
|
|
const weatherFunc = require("../helpers/weather-functions");
|
|
|
|
describe("Weather module: Weather Hourly Forecast", () => {
|
|
let page;
|
|
|
|
afterAll(async () => {
|
|
await weatherFunc.stopApplication();
|
|
});
|
|
|
|
describe("Default configuration", () => {
|
|
beforeAll(async () => {
|
|
await weatherFunc.startApplication("tests/configs/modules/weather/hourlyweather_default.js", {});
|
|
page = helpers.getPage();
|
|
});
|
|
|
|
const minTemps = ["7:00 pm", "8:00 pm", "9:00 pm", "10:00 pm", "11:00 pm"];
|
|
for (const [index, hour] of minTemps.entries()) {
|
|
it(`should render forecast for hour ${hour}`, async () => {
|
|
const dayCell = page.locator(`.weather table.small tr:nth-child(${index + 1}) td.day`);
|
|
await expect(dayCell).toHaveText(hour);
|
|
});
|
|
}
|
|
});
|
|
|
|
describe("Hourly weather options", () => {
|
|
beforeAll(async () => {
|
|
await weatherFunc.startApplication("tests/configs/modules/weather/hourlyweather_options.js", {});
|
|
page = helpers.getPage();
|
|
});
|
|
|
|
describe("Hourly increments of 2", () => {
|
|
const minTemps = ["7:00 pm", "9:00 pm", "11:00 pm", "1:00 am", "3:00 am"];
|
|
for (const [index, hour] of minTemps.entries()) {
|
|
it(`should render forecast for hour ${hour}`, async () => {
|
|
const dayCell = page.locator(`.weather table.small tr:nth-child(${index + 1}) td.day`);
|
|
await expect(dayCell).toHaveText(hour);
|
|
});
|
|
}
|
|
});
|
|
});
|
|
|
|
describe("Show precipitations", () => {
|
|
beforeAll(async () => {
|
|
await weatherFunc.startApplication("tests/configs/modules/weather/hourlyweather_showPrecipitation.js", {});
|
|
page = helpers.getPage();
|
|
});
|
|
|
|
describe("Shows precipitation amount", () => {
|
|
const amounts = [undefined, undefined, undefined, "0.13 mm", "0.13 mm"];
|
|
for (const [index, amount] of amounts.entries()) {
|
|
if (amount) {
|
|
it(`should render precipitation amount ${amount}`, async () => {
|
|
const amountCell = page.locator(`.weather table.small tr:nth-child(${index + 1}) td.precipitation-amount`);
|
|
await expect(amountCell).toHaveText(amount);
|
|
});
|
|
}
|
|
}
|
|
});
|
|
|
|
describe("Shows precipitation probability", () => {
|
|
const probabilities = [undefined, undefined, "12 %", "36 %", "44 %"];
|
|
for (const [index, probability] of probabilities.entries()) {
|
|
if (probability) {
|
|
it(`should render probability ${probability}`, async () => {
|
|
const probabilityCell = page.locator(`.weather table.small tr:nth-child(${index + 1}) td.precipitation-prob`);
|
|
await expect(probabilityCell).toHaveText(probability);
|
|
});
|
|
}
|
|
}
|
|
});
|
|
});
|
|
});
|