mirror of
https://github.com/MichMich/MagicMirror.git
synced 2025-12-12 09:52:37 +00:00
f29f424a62
### 1. Replace `XMLHttpRequest` with the modern `fetch` API for loading translation files #### Changes - **translator.js**: Use `fetch` with `async/await` instead of XHR callbacks - **loader.js**: Align URL handling and add error handling (follow-up to fetch migration) - **Tests**: Update infrastructure for `fetch` compatibility #### Benefits - Modern standard API - Cleaner, more readable code - Better error handling and fallback mechanisms ### 2. Migrate e2e tests to Playwright This wasn't originally planned for this PR, but is related. While investigating suspicious log entries which surfaced after the fetch migration I kept running into JSDOM’s limitations. That pushed me to migrate the E2E suite to Playwright instead. #### Changes - switch e2e harness to Playwright (`tests/e2e/helpers/global-setup.js`) - rewrite specs to use Playwright locators + shared `expectTextContent` - install Chromium via `npx playwright install --with-deps` in CI #### Benefits - much closer to real browser behaviour - and no more fighting JSDOM’s quirks
77 lines
2.3 KiB
YAML
77 lines
2.3 KiB
YAML
# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
|
|
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
|
|
|
|
name: "Run Automated Tests"
|
|
|
|
on:
|
|
push:
|
|
branches: [master, develop]
|
|
pull_request:
|
|
branches: [master, develop]
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
code-style-check:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 15
|
|
steps:
|
|
- name: "Checkout code"
|
|
uses: actions/checkout@v5
|
|
- name: "Use Node.js"
|
|
uses: actions/setup-node@v6
|
|
with:
|
|
node-version: lts/*
|
|
cache: "npm"
|
|
- name: "Install dependencies"
|
|
run: |
|
|
node --run install-mm:dev
|
|
- name: "Run linter tests"
|
|
run: |
|
|
node --run test:prettier
|
|
node --run test:js
|
|
node --run test:css
|
|
node --run test:markdown
|
|
test:
|
|
runs-on: ubuntu-24.04
|
|
timeout-minutes: 30
|
|
strategy:
|
|
matrix:
|
|
node-version: [22.20.0, 22.x, 24.x]
|
|
steps:
|
|
- name: Install electron dependencies and labwc
|
|
run: |
|
|
sudo apt-get update
|
|
sudo apt-get install -y libnss3 libasound2t64 labwc
|
|
- name: "Checkout code"
|
|
uses: actions/checkout@v5
|
|
- name: "Use Node.js ${{ matrix.node-version }}"
|
|
uses: actions/setup-node@v6
|
|
with:
|
|
node-version: ${{ matrix.node-version }}
|
|
check-latest: true
|
|
cache: "npm"
|
|
- name: "Install MagicMirror²"
|
|
run: |
|
|
node --run install-mm:dev
|
|
- name: "Install Playwright browsers"
|
|
run: |
|
|
npx playwright install --with-deps chromium
|
|
- name: "Prepare environment for tests"
|
|
run: |
|
|
# Fix chrome-sandbox permissions:
|
|
sudo chown root:root ./node_modules/electron/dist/chrome-sandbox
|
|
sudo chmod 4755 ./node_modules/electron/dist/chrome-sandbox
|
|
# Start labwc
|
|
WLR_BACKENDS=headless WLR_LIBINPUT_NO_DEVICES=1 WLR_RENDERER=pixman labwc &
|
|
touch css/custom.css
|
|
- name: "Run tests"
|
|
run: |
|
|
export WAYLAND_DISPLAY=wayland-0
|
|
node --run test
|