mirror of
https://github.com/asterisk/asterisk.git
synced 2025-11-20 16:50:14 +00:00
remove almost all of the checks of the result from ast_strdupa() or alloca().
As it turns out, all of these checks were useless, because alloca will never return NULL. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@26451 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -294,8 +294,7 @@ static struct agent_pvt *add_agent(char *agent, int pending)
|
||||
char *agt = NULL;
|
||||
struct agent_pvt *p;
|
||||
|
||||
if (!(parse = ast_strdupa(agent)))
|
||||
return NULL;
|
||||
parse = ast_strdupa(agent);
|
||||
|
||||
/* Extract username (agt), password and name from agent (args). */
|
||||
AST_NONSTANDARD_APP_ARGS(args, parse, ',');
|
||||
@@ -1751,10 +1750,7 @@ static int __login_exec(struct ast_channel *chan, void *data, int callbackmode)
|
||||
|
||||
LOCAL_USER_ADD(u);
|
||||
|
||||
if (!(parse = ast_strdupa(data))) {
|
||||
LOCAL_USER_REMOVE(u);
|
||||
return -1;
|
||||
}
|
||||
parse = ast_strdupa(data);
|
||||
|
||||
AST_STANDARD_APP_ARGS(args, parse);
|
||||
|
||||
@@ -2486,8 +2482,7 @@ static int function_agent(struct ast_channel *chan, char *cmd, char *data, char
|
||||
return -1;
|
||||
}
|
||||
|
||||
if (!(parse = ast_strdupa(data)))
|
||||
return -1;
|
||||
parse = ast_strdupa(data);
|
||||
|
||||
AST_NONSTANDARD_APP_ARGS(args, parse, ':');
|
||||
if (!args.item)
|
||||
|
||||
Reference in New Issue
Block a user